Search options (Page 230 of 247)

Only 2 files use the  $_SESSION["wa_current_user"]->loginname variable:

Line 82 in includes/errors.inc:

        $user = @$_SESSION["wa_current_user"]->loginname;

and Line 55 in reporting/includes/printer_class.inc:

        $ctrl = "H".$server."\nP". substr($_SESSION["wa_current_user"]->loginname,0,31) 

It is always the same as $_SESSION["wa_current_user"]->username - would the devs want to standardize?.

In includes/session.inc, outside of the class definition, in the function login_timeout() line 402 is:

$_SESSION["wa_current_user"] = new current_user();

Class current_user is defined in includes/current_user.inc, having class variables $loginname, $name and $username all set to empty strings in the constructor at line 42.

current_user::login() method on successful authorisation at line 81:

$myrow = get_user_by_login($loginname);

and sets the current_user class variables

                $this->name = $myrow["real_name"];
                $this->pos = $myrow["pos"];
                $this->loginname = $loginname;
                $this->username = $this->loginname;
                $this->prefs = new user_prefs($myrow);
                $this->user = @$myrow["id"];

If the session variable user is available, ordinarily from the above code, the session variable name should also be available.

When a login timeout occurs, this may not get executed fully and some session variables may get unset (needs to be checked).

Somewhere the session variablenameis getting set to an empty string after having been logged in, if it is empty.

Hence check by replacing the line 269 in reporting/includes/pdf_report.inc with any of the following:

$this->user = $_SESSION["wa_current_user"]->loginname;

// or

$this->user = $_SESSION["wa_current_user"]->username;

and see what happens!

Line 269 in reporting/includes/pdf_report.inc, the function Info() sets:

$this->user = $_SESSION["wa_current_user"]->name;

Since it is taken from session variable, and the function Info() is not called anywhere within the FrontReport class at all, it is called by it's instance in each report.

Each report file repXXX.php has some function(s) that make an instance like $rep = new FrontReport(.... followed by $rep->Info($params, $cols, $headers, $aligns); This will set the $user FrontReport class variable

The FrontReport class method End() in lines 993-995 includes:

require_once($path_to_root . "/reporting/includes/class.mail.inc");
mail = new email(str_replace(",", "", $this->company['coy_name']),
    $this->company['email']);

This method End() is called at the very end of each repXXX.php file.

All seems fine and hence the syntax to set the $this->user is wrong.

includes/session.inc provides the correct syntax:

$user = $_SESSION["wa_current_user"]->user;

Therefore Line 269 in reporting/includes/pdf_report.inc should be::

$this->user = $_SESSION["wa_current_user"]->user;

From the PHP mail() manual:

If the $this->user correctly enters the from header variable, it can be made to enter the same value into a $reply-to variable and used as above.

There is a $sender variable that gets populated as well?
Or just use the from header directly for the 'Reply-to' header.

How did you fix the return path? Was it the addition of a reply-to header in the script or in the class.mail.inc ?

$this->user is the currently logged in user whose email should be in the users table.

Anyone integrated PHPMailer in the place of the existing class.mail.inc ? This will enable sending using a relay SMTP server like gmail.

class.mail.inc is called and instantiated only in sales/includes/db/sales_order_db.inc and reporting/includes/pdf_report.inc. Hence such integration with PHPMailer would be easy.

Lines 994-996 in reporting/includes/pdf_report.inc:

                        $mail = new email(str_replace(",", "", $this->company['coy_name']),
                            $this->company['email']);
                        $mail->charset = $this->encoding;

Line 104 in sales/includes/db/sales_order_db.inc:

        $mail = new email($company['coy_name'], $company['email']);

The charset is missing and the coy_name is not stripped of commas in the latter case.

The latter should be:

$mail = new email(str_replace(",", "", $this->company['coy_name']),    $this->company['email']);

Better still would be to move the stripping of the commas to the class method constructor itself by inserting the following in line 47 of reporting/includes/class.mail.inc:

$name = str_replace(",", "", $name);

and removing the str_replace from both files that use the class.

Just zip it up and archive it. Remove the install folder as there is no install needed.

If you used the file diffs then there would be no install folder.

Please see Post 6 of the Release Announcement and take the diff files set from there. Just overwrite your existing ones. No DB Changes.

Incorporate new variables and new options for existing variables from the config.default.php into your existing config.php with appropriate values.

Check for any new entries in the #_sys_prefs table in the en_US-new.sql file compared with your existing db being used and add them in.

Placed content in Wiki

Did you mean:

    if ($editkey) {
        set_editor('customer', $name, $editkey);
        set_editor('item', $name, $editkey);
    }

A matching empty.po for both FA and FA install is attached for hg 3165.