FA v2.4 development (Page 2 of 2)

Developments to the Unstable branch FA v2.4 have now been synched with changes from the Stable FA v2.3 on the release of FA v2.3.23. Further changes have been committed to the Unstable branch. This set of changes discerned since last reported pertain to this Hg snapshot.

The error reported in the 22nd post in this thread is still present in this snapshot.

The error in the sql/en_US-demo.sql for field definition is now rectified and the demo CoA installs correctly. The CoAs still have redundant indices - the devs have been informed.

Typos:
jiurnal => journal in comment on line 156 in sql/alter2.4.sql
multiply => multiple in comment on line 195 in sql/alter2.4.sql
hiddn => hidden in comment in line 96 in includes/ui/ui_input.inc

SQL Changes:
Improved journal trans: added currency support, tax and source document date and allow multiple customer/supplier allocations to single journal transaction:

New table 0_journal added - full support for any journal transaction
- no demo CoA entries as yet
- populate with:

INSERT INTO `0_journal` (`type`, `trans_no`, `tran_date`, `reference`, `event_date`,`doc_date`,`currency`,`amount`)
 SELECT `gl`.`type`, `gl`.`type_no`, `gl`.`tran_date`, `ref`.`reference`, `gl`.`tran_date`,
   `gl`.`tran_date`, `sys_curr`.`value`, SUM(IF(`gl`.`amount`>0,`gl`.`amount`,0))
 FROM `0_gl_trans` gl LEFT JOIN `0_refs` ref ON gl.type = ref.type AND gl.type_no=ref.id
 LEFT JOIN `0_sys_prefs` sys_curr ON `sys_curr`.`name`='curr_default'
 WHERE `gl`.`type` IN(0, 35)
 GROUP BY `type`,`type_no`;

0_cust_allocations.person_id field added and made part of unique key
0_debtor_trans.debtor_no populated into 0_cust_allocations.person_id

0_supp_allocations.person_id field added and made part of unique key
0_supp_trans.supplier_id populated into 0_supp_allocations.person_id

Added memo, usage fields to Quick Entries:
0_quick_entries.usage field added as a description field to denote where it should be used
0_quick_entry_lines.memo field added as a description field

Tax algorithm handling on supplier side is reverted as impractical:
0_suppliers.tax_algorithm field removed
0_supp_trans.tax_algorithm field removed

0_sys_prefs has a tax_algorithm entry default for customers only
includes/sysnames.inc has:

$tax_algorithms = array( 
 TCA_LINES => _("Sum per line taxes"), 
 TCA_TOTALS => _("Taxes from totals")
);

and is used in function get_tax_for_items() defined in taxes/tax_calc.inc

0_trans_tax_details.reg_type TINYINT added (0, 1 or NULL in the demo CoA data) and is populated with:

UPDATE `0_trans_tax_details` reg
 SET reg.reg_type=1
 WHERE reg.trans_type IN(20, 21); -- ST_SUPPINVOICE, ST_SUPPCREDIT

UPDATE `0_trans_tax_details` reg
 SET reg.reg_type=0
 WHERE reg.trans_type IN(10, 11); -- ST_SALESINVOICE, ST_CUSTCREDIT

New defines in includes/types.inc:

// tax register type
define('TR_OUTPUT', 0); // sales
define('TR_INPUT', 1); // purchase

0_gl_trans.type_no field definition in sql/en_US-demo.sql now stands corrected

Theme and cleanup changes:
Code cleanup for standard themes ported from FA 2.3 but inter-theme renderer.php files do not yet have their whitespace synched.
General code cleanup and HTML 4.01 compliance ported from FA 2.3 - some tag endings "/>" now become ">" whilst certain tag attribute values are quoted.
Improved error messages in transaction voiding
Sales invoice voiding is blocked when sales credit was issued against the invoice.

Class sys_prefs Method renamed:
$SysPrefs->refresh_company_prefs() => $SysPrefs->refresh()

New functions in UI:
tab_opened($name, $tab)
tab_closed($name, $tab)
tab_visible($name, $tab)
display_caption($msg) to display in <caption> tag added

//Confirm dialog to be used optionally in final form checking routine.
//Displays warning conditionally unless it was displayed
display_confirmation($msg)

New gl function for counter party name:
get_subaccount_data($code_id, $person_id)

Functions moved:
function write_journal_entries(&$cart) moved from gl/includes/db/gl_db_trans.inc to gl/includes/db/gl_journal.inc with single argument
function void_journal_trans($type, $type_no, $use_transaction=true) moved from includes/db/gl_db_trans.inc to new file gl/includes/db/gl_journal.inc

New file gl/includes/db/gl_journal.inc added

Now officially part of 0_sys_prefs table in CoA:
bcc_email
alternative_tax_include_on_docs
suppress_tax_rates

grn_clearing_act
default_receival_required
default_quote_valid_days
no_zero_lines_amount
show_po_item_codes
accounts_alpha
loc_notification
print_invoice_no
allow_negative_prices
print_item_images_on_quote

Theme fix for cool and default themes that still refer to the now defunct variable $allow_demo_mode along with white space synch is attached herein. The devs have been notified to make the necessary change.

The version 2.4's CoAs seem to have an extra area (permission) for practically all roles - 775 (Edit other users transactions).
Is this intended?
This is appended to the end of the areas field value.

Changes in the FA 2.4 Unstable branch till 2015-04-08:

The error reported in the 22nd post in this thread is still present in this snapshot.

The Security Role fix has yet to be ported in from FA 2.3.

1. Removed $type in argument of function add_stock_transfer()
2. $line_item->qty from form field used instead of $increase from POST in Inventory Adjustments
3. Reorganised many SQLs to have table aliases
4. Field stock_move.person_id now no longer in rep3xx.php Inventory Reports and stock movements inquiry
5. function get_stock_movements() moved from inventory/includes/db/movement_types_db.inc to inventory/includes/inventory_db.inc
6. Removed Inventory &Movement Types Menu item from Inventory menu
7. Moved Inventory &Locations Menu link from left side to right side.
8. Removed files inventory/includes/db/movement_types_db.inc
9. Removed inventory/manage/movement_types.php
10. Removed stock_movement functions
11. item cart is now updated directly from the form field's $line_item->stock_id

Removed stock_move.person_id field

ALTER TABLE `0_stock_moves` DROP COLUMN `person_id`;

Removed 0_movement_types table

DROP TABLE IF EXISTS `0_movement_types`;

FA 2.4 is heading towards PHP 5.4 and UTF-8 fully. Use "UTF-8 without BOM" in your IDE.

Is default '' illegal for text fields?

See if there have been changes in the latest FA 2.4 build.

I see you have forked the official FA Unstable as well - that is the way to go - not a fork of my frontac24.

FA v2.4 is now fully installable and the reports display with correct paths in Windows thanks to Joe's commit reverting to FA v2.3 config variable $comp_path assignment.

The above commit now means that relative path addressing listed in the 22nd post in this thread is no longer valid.

Screenshots of FA 2.4 Beta - Install, Usage and Extensions available.

FA v2.4 beta can be installed after incorporating the fix detailed in this post.

sys_types and movement_types tables are still present in en_US-demo.sql while being absent in en_US-new.sql - not used in FA 2.4.

journal, reflines and wo_costing are the new tables introduced in FA v2.4.

If you have installed the en_US-demo.sql, then update the currency symbols with:

UPDATE `0_currencies` SET `curr_symbol`='£' WHERE `curr_abrev`='GBP'; 
UPDATE `0_currencies` SET `curr_symbol`='€' WHERE `curr_abrev`='EUR'; 

The demo data has been pruned and computer images (items) have been replaced with the more contemporary cell phone images.

PDFs render well in windows without any cludge fixes anymore.

rep709.php fix in FA v2.3 not ported to FA 2.4 as yet.

demouser is no longer in the en_US-demo.sql

The $src_version variable is now "2.4 beta" and is different from the $db_version which is "2.4.0" in version.php.

Anyone using it in production?

FA 2.4 Official Repo PKGs as available today within the FA application as screenshots are posted in the wiki in my unofficial GitHub.

The FA 2.4 Config.php page has been put up in the wiki. Please go through the contents and suggest / make changes as required.

The following variables are no longer there in the config.php file:

$no_zero_lines_amount = 1;
$save_report_selections = 0;
$use_date_picker = 1;
$show_po_item_codes = 0;
$def_print_destination = 0;
$def_print_orientation = 0;
$accounts_alpha = 0;
$loc_notification = 0;
$print_invoice_no = 0;
$alternative_tax_include_on_docs = 0;
$suppress_tax_rates = 0;
$allow_negative_prices = 1;
$print_item_images_on_quote = 0;
$js_path = $path_to_root.'/js/';'''
$js_static = array('JsHttpRequest.js', 'behaviour.js', 'utils.js', 'inserts.js');
$js_lib = $js_userlib = array();

Many of the above variables are still referred to in the code in files like header.inc and needs to be verified with it's counterpart now being in the sys_prefs table.

Additional fixes to the last set of commits in the FA 2.4 branch can be taken from my unofficial FA 2.4 repo:

Fixed es_MX installer translation files

Fixed typo in en_US-new.sql: Finsihed => Finished

*** As of 2015-12-11, the above fixes have been incorporated into the Official FA 2.4 core.

The ERD Anomalies in the previous post have been addressed in today's commits along with the typo fix in en_US.new.sql in the 44th post.

The FA version number will be updated during release of FA v2.4rc1 as also the *.mo files in the install/lang language folders along with all translations in the core.

Company level configurable sys_prefs (company.setup) options to be able to hide the Fixed Assets and Manufacturing applications are now available in today's commit - use_manufacturing and use_fixed_assets.

Two new config file options have been introduced - $use_popup_search and $max_rows_in_search - enabling popup search in Customers, branches, suppliers, inventory, fixed assets and GL Accounts.

Some 14px icons have been replaced by 16px icons but the css is retained to display them as 14px icons.

A small fix to the upgrade scriptis in my repo. Committed in the official core now.

stock_fa_class table field widths and form field widths for Fixed Assets Classes form is attached for review and correction.

Today's commits have brought on FA v2.4RC1 with most FA 2.3 bugfixes ported forward to FA 2.4.
The de_DE and pt_PT install language strings need to be fixed in the core. It is available from my unofficial FA 2.4 repo.

FA 2.4.x sports a new feature while restoring a backup - the default option of keeping existing security settings.