Search options (Page 244 of 244)

Both files: /modules/repgen/repgen_strings.php and repgen_graphics.php do not have any UPDATE / REPLACE SQL query for case="alter" and hence no updations occur. Hence we will have to manually enter the item values into the table for now.

The repgen_graphics.php uses the $k row variable for the "edit" form names and this alternates between 0 and 1 as it is used for alternate row colors. Another variable should be used to serially number the form name like edit1, edit2, etc. This is totally absent in repgen_strings.php.

For a start, I have done some code cleanup for /modules/repgen/repgen_strings.php by bringing all form elements into one cell for each record. They just have the same name for each record's form.

The last empty column after "Action" is removed in Line 602 by replacing:
$th = array(IT_TYP, IT_ART, IT_FONT, IT_FONT_SIZE, IT_ORD, IT_LEN, IT_X1, IT_Y1, "Total", IT_STRING, "Action", "");
with
$th = array(IT_TYP, IT_ART, IT_FONT, IT_FONT_SIZE, IT_ORD, IT_LEN, IT_X1, IT_Y1, "Total", IT_STRING, "Action");

Then replace the snippet from "existing items" till "end of while" with:

// <!-- existing items -->

    $hiddenattrs  = hidden("id1", $id_new, false);
    $hiddenattrs .= hidden("attrib", $val, false);
    $hiddenattrs .= hidden("id_new", $id_new, false);
    $hiddenattrs .= hidden("sql", $sql,false);
    $hiddenattrs .= hidden("long", $long, false);
   
    alt_table_row_color($k);
    label_cell($it_typ);
    label_cell($it_art);
    label_cell($it_font);
    label_cell($it_fontsize);
    label_cell($it_ord);
    label_cell($it_number);
    label_cell($it_x1);
    label_cell(($it_y1 != "" ? $it_y1 : "."));
    label_cell(($it_total != "" ? $it_total : "."));
    if (in_array($it_typ, array("Line","Rectangle")))
        label_cell(".");
    else
    {
        if (!(empty($it_from) || empty($it_to)))
            label_cell($it_str."(".$it_from."-".$it_to.")");
        else
            label_cell($it_str);
    }
    if (in_array($it_typ,array("String","DB","Term","Block","Textarea")))
        $editbutton = submit("alter", CHANGE, false);
    else
        $editbutton = " ";
    echo "<td>\n";
    start_form(false, false, "repgen_strings.php?report_type=".$report_type, "edit");
    echo $hiddenattrs . $editbutton . submit("delete", DELETE, false);
    end_form();
    echo "</td>\n";

    end_row();
   
}  // end of while

The form URL is still suspect - the $report_type variable in the submit url may cause problems with the other POST variables.

The above colon typo applies to Lines 259 and 300  in /modules/repgen/repgen_graphics.php as well.

Refer file /modules/repgen/repgen_strings.php :-

Line 654 is the "start_form" statement and it is inside a cell of a table and PHP decides to auto close the form within the cell itself. Hence the Line 681 which is the actual "end_form()" does not get used where intended.

The start_form() and end_form() statements must be outside of the row cells showing the current Page String Records to be effectve. If each record is in a table of it's own, it will be effective.