Whats happened with Recurrent invoices?

This was changed in FA 2.3.5 as stated in the wiki.

@apmuthu, I've tested against the latest wiki entries and it still is not fuctioning as stated in the wiki.

Please try a few entries and you should see the problem.

@apmuthu Hi...

So as I understand it:-

Choose # of days 7 and leave month at zero and an invoice will be created every week, invoices will start on begin date.

or

Leave days at zero, set months to 1 and an invoice will be created every month dated for the begin date.

And that is the only funtionality now? (the -1 in days no longer works for last day of the month?)

Please confirm this is the only intended functionality?

Also I have made some tests based on this as follows:-

Input to recurrent invoices                        Create and Print Recurrent Invoices   
Name    Days    Monthly    Begin        Invoice #    Invoice date    Recurrent Invoice covers period
Test 1    7    0    01-12-16        1    08-12-16    01/12/2016 - 07/12/2016.
Test 1    7    0    01-12-16        2    15-12-16    08/12/2016 - 14/12/2016.
   "            "    "          "                "           "                        "
Test 1    7    0    01-12-16        12    23-02-17    16/02/2017 - 22/02/2017.
Test 1    7    0    01-12-16        13    02-03-17    23/02/2017 - 01/03/2017.
                           
Test 2    0    1    01-12-16        1    01-01-17    01/12/2016 - 31/12/2016.
Test 2    0    1    01-12-16        2    01-02-17    01/01/2017 - 31/01/2017.
Test 2    0    1    01-12-16        3    01-03-17    01/02/2017 - 28/02/2017.
Test 2    0    1    01-12-16        4    01-04-17    01/03/2017 - 31/03/2017.
                           
Test 3    0    1    05-12-16        1    05-01-17    05/12/2016 - 04/01/2017.
Test 3    0    1    05-12-16        2    05-02-17    05/01/2017 - 04/02/2017.
Test 3    0    1    05-12-16        3    05-03-17    05/02/2017 - 04/03/2017.
                           
Test 4    0    1    29-12-16        1    29-01-17    29/12/2016 - 28/01/2017.
Test 4    0    1    29-12-16        2    28-02-17    29/01/2017 - 27/02/2017.
Test 4    0    1    29-12-16        3    28-03-17    28/02/2017 - 27/03/2017.
                           
Test 5    0    1    31-12-16        1    31-01-17    31/12/2016 - 30/01/2017.
Test 5    0    1    31-12-16        2    28-02-17    31/01/2017 - 27/02/2017.
Test 5    0    1    31-12-16        3    28-03-17    28/02/2017 - 27/03/2017.

Tests 1, 2 & 3 work fine.
In tests 4 & 5 it doesn't seem to handle February very well.

(Somehow I was reading a very old version of the wiki, now with wiki update i get the correct version)

I will test, gimme an hour or so..

But tests 4 & 5 should go back to 29-03-17 & 31-03-17 after February shouldn't they?

If we put in 1 month, then it will be a calendar month. If we put in 30 days, it will be just so using the add_month() function.

The -1 functionality works okay for the first invoice and is 1 day earlier for the rest.

Try to change the 3rd line above:

$next = add_days($next, 1);

to:

$next = add_days($next, 2);

and provide feedback for the "-1" cases.

For 30 days it appears okay so we do not need to change that portion.

For -1, the invoice needs to be raised on the last day of the month for the period from the last day of the previous month to the day before the last day of the current month.

The new function replacement should be:

function calculate_next($myrow)
{
    if ($myrow["last_sent"] == '0000-00-00')
        $next = sql2date($myrow["begin"]);
    else
        $next = sql2date($myrow["last_sent"]);
    if ($myrow['days'] == -1) {
        // ignore months when days = -1
            $next = add_days($next, 2); // <-- changed line
            $next = end_month($next);
            return $next;
    } else {
        $next = add_months($next, $myrow['monthly']);
        $next = add_days($next, $myrow['days']);
        return add_days($next,-1);
    }
}

With:-

function calculate_next($myrow)
{
    if ($myrow["last_sent"] == '0000-00-00')
        $next = sql2date($myrow["begin"]);
    else
        $next = sql2date($myrow["last_sent"]);
    if ($myrow['days'] == -1) {
        // ignore months when days = -1
            $next = add_days($next, 2); // <-- changed line
            $next = end_month($next);
            return $next;
    } else {
        $next = add_months($next, $myrow['monthly']);
        $next = add_days($next, $myrow['days']);
        return add_days($next,-1);
    }
}

I'm getting the following:-
Input to recurrent invoices                        Create and Print Recurrent Invoices   
Name    Days    Monthly    Begin        Invoice #    Invoice date    Recurrent Invoice covers period
Test 1c    7    0    01-12-16        1    08-12-16    01/12/2016 - 07/12/2016.
Test 1c    7    0    01-12-16        2    15-12-16    08/12/2016 - 14/12/2016.
       "    "    "           "        "           "                       "
Test 1c    7    0    01-12-16        12?    23-02-17    16/02/2017 - 22/02/2017.
Test 1c    7    0    01-12-16        13?    02-03-17    23/02/2017 - 01/03/2017.
                           
Test 2c    0    1    01-12-16        1    01-01-17    01/12/2016 - 31/12/2016.
Test 2c    0    1    01-12-16        2    01-02-17    01/01/2017 - 31/01/2017.
Test 2c    0    1    01-12-16        3    01-03-17    01/02/2017 - 28/02/2017.
Test 2c    0    1    01-12-16        4    01-04-17    01/03/2017 - 31/03/2017.
                           
Test 5c    0    1    31-12-16        1    31-01-17    31/12/2016 - 30/01/2017.
Test 5c    0    1    31-12-16        2    28-02-17    31/01/2017 - 27/02/2017.
Test 5c    0    1    31-12-16        3    28-03-17    28/02/2017 - 27/03/2017.
                           
Test 9    -1    0    31-12-16        1    30-12-16    31/12/2016 - 29/12/2016.
Test 9    -1    0    31-12-16        2    29-12-16    30/12/2016 - 28/12/2016.
Test 9    -1    0    31-12-16        3    28-12-16    29/12/2016 - 27/12/2016.

function calculate_next($myrow)
{
    if ($myrow["last_sent"] == '0000-00-00')
        $next = sql2date($myrow["begin"]);
    else
        $next = sql2date($myrow["last_sent"]);
    if ($myrow['days'] == -1 && $myrow['monthly'] > 0) {
        // ignore months when days = -1
            $next = add_days(begin_month($next), -1); // last day of previous month
            $myrow['days']=0;
    }
    $next = add_months($next, $myrow['monthly']);
    $next = add_days($next, $myrow['days']);
    return add_days($next,-1);
}

gives

Test 9d    -1    1    31-12-16        1    30-01-17    31/12/2016 - 29/01/2017.
Test 9d    -1    1    31-12-16        2    27-02-17    30/01/2017 - 26/02/2017.
Test 9d    -1    1    31-12-16        3    26-03-17    27/02/2017 - 25/03/2017.

//new function calculate_next
function calculate_next($myrow)
{
    if ($myrow["last_sent"] == '0000-00-00')
        $next = sql2date($myrow["begin"]);
    else
        $next = sql2date($myrow["last_sent"]);
    if ($myrow['days'] == -1 && $myrow['monthly'] > 0) {
        // ignore months when days = -1
            $next = begin_month($next); // to later become last day of previous month
            $myrow['days']=0;
    }
    $next = add_months($next, $myrow['monthly']);
    $next = add_days($next, $myrow['days']);
    return add_days($next,-1);
}

is giving the same result

Test 9e    -1    1    31-12-16        1    30-01-17    31/12/2016 - 29/01/2017.
Test 9e    -1    1    31-12-16        2    27-02-17    30/01/2017 - 26/02/2017.
Test 9e    -1    1    31-12-16        3    26-03-17    27/02/2017 - 25/03/2017.

We may be getting a little confused with the objective,

The original code (before the above mods) functioned  if 0 for days and 1 or more entered in months, the start date would then be the billing date going forward. So for dates from the 1st - 28th of the month this works fine, but what happens if you want the 29th, 30th or 31st? It all goes wrong in February (unless its a leap year for the 29th), and stays wrong in march onwards.

We can state in the wiki that only start dates to the 28th of the month are permitted, but...?

For me the expected results would be as follows:-

Test 3    0    1    05-12-16        1    05-01-17    05/12/2016 - 04/01/2017.
Test 3    0    1    05-12-16        2    05-02-17    05/01/2017 - 04/02/2017.
Test 3    0    1    05-12-16        3    05-03-17    05/02/2017 - 04/03/2017.
                           
Test 4    0    1    29-12-16        1    29-01-17    29/12/2016 - 28/01/2017.
Test 4    0    1    29-12-16        2    28-02-17    29/01/2017 - 27/02/2017.
Test 4    0    1    29-12-16        3    29-03-17    28/02/2017 - 28/03/2017.
Test 4    0    1    29-12-16        4    29-04-17    29/03/2017 - 28/04/2017.

Test 4    0    1    30-12-16        1    30-01-17    30/12/2016 - 29/01/2017.
Test 4    0    1    30-12-16        2    28-02-17    30/01/2017 - 27/02/2017.
Test 4    0    1    30-12-16        3    30-03-17    28/02/2017 - 29/03/2017.
Test 4    0    1    30-12-16        4    30-04-17    30/03/2017 - 29/04/2017.

Test 4    0    1    31-12-16        1    31-01-17    31/12/2016 - 30/01/2017.
Test 4    0    1    31-12-16        2    28-02-17    31/01/2017 - 27/02/2017.
Test 4    0    1    31-12-16        3    31-03-17    28/02/2017 - 30/03/2017.
Test 4    0    1    31-12-16        4    30-04-17    31/03/2017 - 29/04/2017.
Test 4    0    1    31-12-16        5    31-05-17    30/04/2017 - 30/05/2017.

I think I have that right please check

As I said earlier We can state in the wiki that only start dates to the 28th of the month are permitted

Yes, that sounds good.

Comment: Are 29, 30 & 31 'edge' cases?