Search options (Page 5 of 6)

I'm currently working on this.  The approach I'm taking is a pure php solution with no jQuery hacking of the classes.  I'm delegating the render code to a default renderer, and allowing themes to implement the render.  You can track progress if you like on my todo list

Updated code is here.  Unit tests are here.

@Janusz Items 2, 3, and 4 are complete.  I've attempted 1 but I'm not that satisfied.  For example consider the following scenario:

1. Add a transfer $100 from current -> cash account at date d
2. Add a transfer $60 from cash -> current account at date d + 2 weeks
3. Add a transfer $80 from cash -> current account at date d + 1 week.

This succeeds and results in a -ve balance in the cash account of -40 in the existing code.

I've attempted a fix by setting a future date in the validation.  Please have a look and review the fix here.

This fix would fix your review #1 but would also change the existing functionality.

Note that I'm not proposing hard coding the date 2099.  I'd like to know what future date from the perspective of the transfer the date should be.  End of FY?  Current date?  Something else?

The bank edit feature can be compared to current master here.

In my testing cash accounts cannot go below zero when submitting the edition (red error box is displayed), but the current account can.  I think this is consistent with the current behavior of FA which allows -ve balance on the current account.   Let me know if there's a particular scenario you've got in mind.

Can you help me to see that?  Where do I get that view?  I see zero amounts for all manner of voided items in the bank reconciliation screen, and I can see zero amount transfers in the reconciliation also.

What's the preferred way to not display them.  a) delete them? (I'm guessing not)  b) not display them via some 'if voided' type function the don't display. c) something else?

Yes, I can see those.  I'll go fix them.

Will do.
Janusz

I've implemented a bank transfer edit feature as per the OP request.  The patch is available here.

If you have some mechanism for accepting pull requests let me know.

E2E tests are also available in my frontaccounting-wrapper repo.  If you're interested in incorporating the e2e tests it would be nice to push the current code down one level and have the tests in a folder that is not in the main src (htdocs) tree.

Maybe the permissions in the .git folder are not allowing us to fetch all the refs.

Yes, I understand that there is the intention to have a git repo.  I'm pointing out that it is not currently operational.  I have cloned it before, and pulled from it before.  The last time I pulled from it was June 19, 2014.  You can view it via http, but that's not supporting the git protocol for fetch.  In the past I've fetched via the git protocol on port 9418.  Now I cannot do so.  As far as I can tell no other protocol is available.  You can see all the protocols that git supports here:

http://git-scm.com/book/en/Git-on-the-Server-The-Protocols

If one of those protocols is available and currently working do let me know. :-)

The GitHub Readme has a badge on it that shows the status of the build; passing or failing.

The full build log can be found on Travis.

Protractor uses the Jasmine test language framework.  Here's a snippet of the test code; it is very easy to read for code, and quite easy to write.

  it('transfers ok', function () {
    page.get('/gl/bank_transfer.php');
    expect(page.getTitle()).toEqual('Bank Account Transfer Entry');
    expect(page.getReference()).not.toEqual('');
    page.transfer('Current account', 'Petty Cash account', '1/2/2013', '11', 'Some memo', null);
    expect(page.getNoteMessage()).toEqual('Transfer has been entered');
  });

If folk would like to contribute tests I can give some guidance in getting setup.

I've been looking into what it would take to get bootstrap3 working in a theme.  It would be more than just a theme as defined currently.  We would need to abstract some of the ui rendering into the theme.  i.e. many of the files under includes/ui which currently include a lot of inline styling on the tables for example.

The current render class could be extended for this purpose.

So, no official git repo at the moment then?