Search options (Page 39 of 247)

@joe: can commit?

You have to make a purchase invoice for the supplier and allocate the payment to the supplier. You have directly written off the expense and hence the loose left over payment entry.

Debit: Stationary Expenses Account [Amount :500]
Credit: Supplier - Invoice for Stationery [Amount :500]

Debit: Supplier - Payment made [Amount :500]
Credit : Bank Account [Amount :500]

Check this post for similar fix as it has to do with your later PHP version.

@joe: can commit it for this file as well.

Upgrade to the latest FA 2.4.7+. Many bugfixes have been made since the release of FA 2.4.7. See this post.

Sales => Sales Type => Tax Included => No -- for the specific Tax.

Yes. This is intentional in FA 2.4 by design.

@Rmendez: Thanks for testing it.

The use of the string 'false' instead of the boolean false and the out of order include have contributed to the problem and has been rectified in the attachment which includes the diff file and the screenshot of successful addition of new supplier.

A few more files (need to properly check on what has worked till now anyway) that have this kind of construct (and 'true' as well) are:

reporting/includes/fpdi/pdf_parser.php
reporting/includes/tcpdf.php
includes/JsHttpRequest.php

@itronics / @joe: can commit it.

Further testing reveals that popup windows need to be enabled for the FA site for the Setup => Attachments View button functionality to work. The Sales => Add?Manage Customers => Attachments View Attachment button works okay even without such settings.

This is so because, the former uses a "button" tag whilst the latter uses the "a href" tag.

# Setup => Attachments (needs popup exception for FA domain)
# Sales => Add/Manage Customer => Attachments (no need for pop settings)

The HTML code inspection reveals the Concerned Lines:
# Lines 199 and 227 in admin/attachments.php

<td><button type="submit" class="editbutton" name="view3" value="1" title="View">
<img src="../themes/default/images/view.gif" 
     style="vertical-align:middle;width:12px;height:12px;border:0;">
</button>
</td>

# Line 95 in includes/ui/attachments.inc

<td style="text-align: center;">
<a target="_blank" class="viewlink" 
   href="../../admin/attachments.php?vw=3" 
   onclick="javascript:openWindow(this.href,this.target); return false;" 
   accesskey="V">
<img src="../../themes/default/images/view.gif" 
     style="vertical-align:middle;width:12px;height:12px;border:0;">
</a>
</td>

@itronics is working on it. We finally need to get rid of the includes/ui/attachment.inc file and get it working consistently across user interfaces.

Known issues:

1. Attaching MS Office documents like docx, xlsx, pptx, etc will result in error as the mime type exceeds 60 characters - need to increase the size of the field attachments.filetype to say 100 from the current 60 characters.

2. Edit of the attachment record in Sales => Add and Manage Customers => Attachments tab does not work as yet.

You can do a restore using PHPMyAdmin or other SQL client if very large.

Large DB Restore will need to be re-written in FA 2.5.

Updated file attachment. Thanks for the eagle eye.

Finally, for FA 2.4.7+, Customer / Supplier Attachments are now possible with the changed files attached and inclusion of one inc file.

No DB changes. No external dependencies.

No "#" number ID for Customers / Suppliers as no transactions are involved.

Thanks to @Rmendez for checking it out and persisting with it.

Please test and revert on any issues.

The fix is to replace line 61 in admin/attachments.php:

            header('Content-Disposition: attachment; filename='.$row['filename']);

with:

            header('Content-Disposition: attachment; filename="'.$row['filename'].'"');

This just wraps the $filename within double quotes.

@joe: can commit it.