Upgrading to FA 2.4.7+ is recommended by downloading the post release fixes in this post and uploading to your server installation overwriting the existing ones.

Upgrade to the latest FA 2.4.7+. Many bugfixes have been made since the release of FA 2.4.7. See this post.

Sales => Sales Type => Tax Included => No -- for the specific Tax.

903

(27 replies, posted in Wish List)

Updated attachment in Post #17

Yes. This is intentional in FA 2.4 by design.

905

(1 replies, posted in Wish List)

Not that I know of.

Anyone using Customer Templates can chip in with mods for Supplier Templates.

906

(27 replies, posted in Wish List)

@Rmendez: Thanks for testing it.

The use of the string 'false' instead of the boolean false and the out of order include have contributed to the problem and has been rectified in the attachment which includes the diff file and the screenshot of successful addition of new supplier.

A few more files (need to properly check on what has worked till now anyway) that have this kind of construct (and 'true' as well) are:

reporting/includes/fpdi/pdf_parser.php
reporting/includes/tcpdf.php
includes/JsHttpRequest.php

@itronics / @joe: can commit it.

907

(27 replies, posted in Wish List)

No problem adding customer.

See screenshots attached.

Provide more information regarding your issue with debug and sql_trails along with platform versions.

908

(27 replies, posted in Wish List)

Further testing reveals that popup windows need to be enabled for the FA site for the Setup => Attachments View button functionality to work. The Sales => Add?Manage Customers => Attachments View Attachment button works okay even without such settings.

This is so because, the former uses a "button" tag whilst the latter uses the "a href" tag.

# Setup => Attachments (needs popup exception for FA domain)
# Sales => Add/Manage Customer => Attachments (no need for pop settings)

The HTML code inspection reveals the Concerned Lines:
# Lines 199 and 227 in admin/attachments.php

<td><button type="submit" class="editbutton" name="view3" value="1" title="View">
<img src="../themes/default/images/view.gif" 
     style="vertical-align:middle;width:12px;height:12px;border:0;">
</button>
</td>

# Line 95 in includes/ui/attachments.inc

<td style="text-align: center;">
<a target="_blank" class="viewlink" 
   href="../../admin/attachments.php?vw=3" 
   onclick="javascript:openWindow(this.href,this.target); return false;" 
   accesskey="V">
<img src="../../themes/default/images/view.gif" 
     style="vertical-align:middle;width:12px;height:12px;border:0;">
</a>
</td>

909

(27 replies, posted in Wish List)

This feature has finally been incorporated into the FA Core by @itronics. Thanks a lot for the spit and polish and fully working state.

Commits:
https://github.com/FrontAccountingERP/FA/commit/3d95c6844745f183ebab970251cd254dd6cbdcec
https://github.com/FrontAccountingERP/FA/commit/15576cedd9e46caac2884c2815875e7ec9fd4802

Attached are the changed files for FA 2.4.7+ as on date.

Those who have used the old code will need to take note of:

To preserve some FA types numbering scheme consistency, the type_no used are 41 and 42 as customer/supplier attachment type (instead of 5 and 6  in original code).

Seems the original code was not ready for production, expect nobody will have problem with renumbering existing records in attachments table's field type_no with something like:

UPDATE 0_attachments SET type_no=41 WHERE type_no=5;
UPDATE 0_attachments SET type_no=42 WHERE type_no=6;

Use Table prefix as appropriate instead of the 0_ above.

910

(27 replies, posted in Wish List)

@itronics is working on it. We finally need to get rid of the includes/ui/attachment.inc file and get it working consistently across user interfaces.

Known issues:

1. Attaching MS Office documents like docx, xlsx, pptx, etc will result in error as the mime type exceeds 60 characters - need to increase the size of the field attachments.filetype to say 100 from the current 60 characters.

2. Edit of the attachment record in Sales => Add and Manage Customers => Attachments tab does not work as yet.

911

(27 replies, posted in Wish List)

File Attachment using Sales => Add / Manage Customers => Attachments now works for Adding file.

The changed files download has been updated in this post.

912

(3 replies, posted in Installation)

You can do a restore using PHPMyAdmin or other SQL client if very large.

Large DB Restore will need to be re-written in FA 2.5.

913

(27 replies, posted in Wish List)

There is an issue with date2sql conversion necessary before inserting into db for this method in attachment.inc file.

The Setup =>Attachments method uses the line 136 of attachments.php file to do the insertion correctly.

914

(27 replies, posted in Wish List)

Updated file attachment. Thanks for the eagle eye.

915

(27 replies, posted in Wish List)

Screenshots attached.

916

(27 replies, posted in Wish List)

Finally, for FA 2.4.7+, Customer / Supplier Attachments are now possible with the changed files attached and inclusion of one inc file.

No DB changes. No external dependencies.

No "#" number ID for Customers / Suppliers as no transactions are involved.

Thanks to @Rmendez for checking it out and persisting with it.

Please test and revert on any issues.

917

(26 replies, posted in Reporting)

All reporting/repXXX.php files call the reporting/includes/pdf_reports.inc based on destination chosen in the report request form.

All reporting/repXXX.php files are called only from reporting/reports_main.php which in turn "includes" the includes/ui.inc and that in turn "includes" the includes/ui/ui_globals.inc file (among others) that defines the function count_array().

Hence no need for separate inclusion of includes/ui/ui_globals.inc except when the reports are used independent of the above file.

Wonder why Line 374 was left out from such a change in reporting/includes/pdf_report.inc.

        $count = count($this->headers2);

The fix is to replace line 61 in admin/attachments.php:

            header('Content-Disposition: attachment; filename='.$row['filename']);

with:

            header('Content-Disposition: attachment; filename="'.$row['filename'].'"');

This just wraps the $filename within double quotes.

@joe: can commit it.

File Attachments with and without spaces in their filenames get uploaded okay. When a download is attempted, then files with spaces in their names get truncated at the first space in file save dialog box.

920

(0 replies, posted in Report Bugs here)

When trying to attach a Word Document (docx) in a Windows XAMPP environment, the actual filetype realised is:
application/vnd.openxmlformats-officedocument.wordprocessingml.document which turns out to be 72.

The field size for the above in the attachments table is 60.

Also proper html decoding of the '&quot;' character does not occur in the attachment insertion sql.

921

(0 replies, posted in Report Bugs here)

The function get_post($name, $dflt='') is defined in includes/ui/ui_controls.inc.
The function check_value($name) is defined in includes/ui/ui_input.inc.

In the former, a default non zero / non one value / null can be set whereas, in the latter the default value is hardcoded as 0 or 1.

In the former, isset() is used for blank check whilst in the latter an empty() check is used.

Each one uses themselves recursively for arrays.

Hence in FA, are these two equivalent across PHP versions:
get_post('tax_included', 0)
and
check_value('tax_included')
?

After line 158 in includes/db/connect_db_mysqli.inc (and it's equivalent in mysql), the following lines may be added:

        if( strpos($value, '&quot;') )
           $value = str_replace("&quot;", '"', $value);

Please check the playout in non latin* / utf-8 encodings.

@joe: will this affect anything?

923

(26 replies, posted in Reporting)

Search for "count(" in the reporting/includes/pdf_report.inc and we find 15 occurrences that need to be replaced with "count_array("

@joe: can commit this along with the inclusion of includes/ui/ui_globals.inc in it.

924

(2 replies, posted in Modules Add-on's)

This post is quite old and the domain no longer exists.
This domain registration expired on 12/05/2018.

Last known website homepage version.

Which chart of accounts did you start from that failed to have the auto_increment flag on to begin with?