Thanks @kvvaradha.
This has been fixed and committed to stable repo.
The fixed file can be downloaded here.
Joe
551 04/14/2019 09:38:01 pm
Re: user_list_cells Real name sometimes shows empty (3 replies, posted in FA Modifications)
552 04/13/2019 07:51:10 am
Re: unnecessary function inside sales_order_db.inc (4 replies, posted in Report Bugs here)
@Braath Waate.
You are right. It was my fault that this was a missing parameter. Thanks.
@kvvaradha.
It was you that suggested the correct fix, but I accidently missed this function call on a line. Sorry for that.
Fixed and committed to stable repo. The /sales/includes/ui/sales_order_ui.inc can be downloaded here.
/Joe
553 04/12/2019 04:47:05 pm
Re: unnecessary function inside sales_order_db.inc (4 replies, posted in Report Bugs here)
Thanks @kvvaradha.
I will check later.
Joe
554 04/07/2019 06:53:30 am
Re: Recurrent Invoices in 2.4 is not sending (15 replies, posted in Report Bugs here)
This has been fixed in core and committed to stable repo.
The fixed file can be downloaded here.
Thanks for finding this!
/Joe
555 04/04/2019 07:28:17 pm
Re: Cannot download repo index file. error 2.4.6 (10 replies, posted in Report Bugs here)
The repo should work again. Sorry for the Miss.
Joe
556 04/03/2019 01:50:48 pm
Topic: Website Transfer. (7 replies, posted in Announcements)
Hello Guys,
We had to transfer the Website to a new Webhost due to outrageous price increase.
This transfer is now done. Hopefully without too much problems.
I can understand that there might be some missing posts. In that case forgive us and try to enter them again.
In a couple of months we will try to release a 2.5 Alpha. Included will be a Human Resource Planning (HRM or Payroll) that has been developed by @notrinos. It will have a few changes to adapt to the core of FA.
There will also be some improvements on the themes. We will implement a poll, with the various new themes presented by some developers.
/Joe
557 04/03/2019 01:40:12 pm
Re: Cannot download repo index file. error 2.4.6 (10 replies, posted in Report Bugs here)
Yes, I can reproduce this. Will talk to Janusz about this.
/Joe
558 03/26/2019 12:48:01 am
Re: Sales Direct Invoice has due_date and delivery_date bug (15 replies, posted in Report Bugs here)
@JimmyC
The file /sales/includes/db/sales_invoice_db.inc has now been fixed and committed to stable.
A Fixed file can be downloaded here
Joe
559 03/26/2019 12:01:39 am
Re: Sales Direct Invoice has due_date and delivery_date bug (15 replies, posted in Report Bugs here)
@JimmyC
Thanks JimmyC. I have found the bug now. There is a zero amount tax record with an amount of 50 that are inserted in the trans_tax-details table.
The tax amount of this is 0 and is inserted as a 0 amount of tax with an unknown account. This record should never create a gl_trans.
I will fix that in a while.
/Joe
560 03/25/2019 08:41:49 am
Re: Sales Direct Invoice has due_date and delivery_date bug (15 replies, posted in Report Bugs here)
@jimmyC
I have been doing some investigation about this empty account line.
This line is created if floatcmp reports a balance. Look in gl_db_trans.inc, line 95.
There should also be an error line in your tmp/errors.log file for the date. Please have a look and report.
But the reason that the account code is empty is that there is no System and GL account for 'exchange_diff_act'.
If you go into Setup/System and GL setup and look up this account, there might be a value here, but if it doesn't show the right account change the account to show the right act, then save the setup.
Then please try another Direct Invoice. Now it should work.
/Joe
561 03/25/2019 12:35:03 am
Re: Sales Direct Invoice has due_date and delivery_date bug (15 replies, posted in Report Bugs here)
the later GL transactions seems to include an empty account line (are there any missing accounts in your chart of accounts.
FA should never post anything to an empty account.
The line could be some rounded values, but the value is 0 so this looks strange.
I have no idea. In my testing everything went ok in the GL lines and it should do so.
Please check that all your default accounts in the System and GL setup are ok. Do this check in the phpMyAdmin.
/Joe
562 03/24/2019 05:06:34 pm
Re: Sales Direct Invoice has due_date and delivery_date bug (15 replies, posted in Report Bugs here)
Hello again.
I found the place to fix the bug and this has been committed to stable repo.
/Joe
563 03/23/2019 10:26:47 pm
Re: Sales Direct Invoice has due_date and delivery_date bug (15 replies, posted in Report Bugs here)
Hello again @JimmyC.
I see the problem now. When the Document date is earlier than todays date, then the duedate becomes todays date. This is only for Cash Payments.
I have problem finding where to fix this error. Janusz wrote these routines. I will ask him to fix this. Thanks for reporting this.
/Joe
564 03/23/2019 09:49:04 am
Re: Sales Direct Invoice has due_date and delivery_date bug (15 replies, posted in Report Bugs here)
@JimmyC.
I cannot reproduce your examples in version 2.4.6. However there was a presentation bug in Sales Order View.
In the Direct Invoice, the Sales Order is automatically created with the reference 'auto'. The value in the due_date field was the later invoice due_date. So in the dispatch view, you will see the label 'Due Date' instead of 'Requested Delivery'.
Therefore I have changed the 'Sales Order View' to present the 'Due Date' value if the reference is 'auto'.
This should eliminate the misunderstanding.
I am open for other users testing this to see if I have missed another bug.
The view_sales_order.php has been committed to stable repo.
/Joe
565 03/21/2019 09:35:25 pm
Re: No exchange rate working in FA now (20 replies, posted in Report Bugs here)
This has been committed to stable repo. Thank you @notrinos for providing this.
Remember to change the settings in config.php also.
/Joe
566 03/19/2019 02:44:10 pm
Re: No edit in supplier invoice quick entry (11 replies, posted in Banking and General Ledger)
567 03/19/2019 06:34:27 am
Re: No edit in supplier invoice quick entry (11 replies, posted in Banking and General Ledger)
@Braath Waate.
Is this safe to implement in the core now?
Joe
568 03/13/2019 05:57:33 am
Re: SMTP or phpmailer (4 replies, posted in Wish List)
Hello Guys,
I am aware of the problems. However using the built-in mail function has normally been working ok during the years.
Using phpmailer requires an existing account for using it.
Suggestions are welcome.
Joe
569 03/06/2019 10:00:38 pm
Re: A non-numeric value encountered in \includes\date_functions.inc (4 replies, posted in Report Bugs here)
@PaulShipley
This was a PHP 7.X error. Thanks for finding this and showing the resolution.
Committed to repo. The fixed file can be downloaded here.
Joe
570 03/06/2019 06:10:20 pm
Re: A non-numeric value encountered in \includes\date_functions.inc (4 replies, posted in Report Bugs here)
Which PHP-version is used?
Joe
571 03/04/2019 07:48:20 am
Re: Line 1369 in en_US-demo.sql can be removed (4 replies, posted in Misc. Charts of Accounts)
This has been fixed and committed to stable repo. The AUTO_INCREMENT removal will wait until later due to backwards compatibility.
Joe
572 03/03/2019 04:40:49 pm
Re: Line 1369 in en_US-demo.sql can be removed (4 replies, posted in Misc. Charts of Accounts)
No, hardly not. Will remove it and commit later.
Joe
573 02/26/2019 04:26:23 pm
Re: Tax Inquiry - Does not show output tax info (114 replies, posted in Reporting)
Hello Guys,
I would say that this is rather region specific so I suggest following a global setting like the one selected by Janusz.
We simply put the setting in config.php. That is my opinion.
Joe
574 02/19/2019 07:39:48 am
Re: Last Visit Date with Time (2 replies, posted in Wish List)
This has been fixed and committed to stable repo. Thanks @kvvaradha and @apmuthu.
A fixed file can be downloaded here and replaced.
Joe
575 02/13/2019 02:53:52 pm
Re: Customer balance Report rep101.php has one extra parameter (1 replies, posted in Reporting)
Oops! Thanks @kvvaradha for detecting this. Well it did no harm and the conversion is done immediately after the open balance call.
But it should not be here 
Committed to stable repo.
/Joe