Hello again.
I found the place to fix the bug and this has been committed to stable repo.
/Joe
551 03/24/2019 05:06:34 pm
Re: Sales Direct Invoice has due_date and delivery_date bug (15 replies, posted in Report Bugs here)
552 03/23/2019 10:26:47 pm
Re: Sales Direct Invoice has due_date and delivery_date bug (15 replies, posted in Report Bugs here)
Hello again @JimmyC.
I see the problem now. When the Document date is earlier than todays date, then the duedate becomes todays date. This is only for Cash Payments.
I have problem finding where to fix this error. Janusz wrote these routines. I will ask him to fix this. Thanks for reporting this.
/Joe
553 03/23/2019 09:49:04 am
Re: Sales Direct Invoice has due_date and delivery_date bug (15 replies, posted in Report Bugs here)
@JimmyC.
I cannot reproduce your examples in version 2.4.6. However there was a presentation bug in Sales Order View.
In the Direct Invoice, the Sales Order is automatically created with the reference 'auto'. The value in the due_date field was the later invoice due_date. So in the dispatch view, you will see the label 'Due Date' instead of 'Requested Delivery'.
Therefore I have changed the 'Sales Order View' to present the 'Due Date' value if the reference is 'auto'.
This should eliminate the misunderstanding.
I am open for other users testing this to see if I have missed another bug.
The view_sales_order.php has been committed to stable repo.
/Joe
554 03/21/2019 09:35:25 pm
Re: No exchange rate working in FA now (20 replies, posted in Report Bugs here)
This has been committed to stable repo. Thank you @notrinos for providing this.
Remember to change the settings in config.php also.
/Joe
555 03/19/2019 02:44:10 pm
Re: No edit in supplier invoice quick entry (11 replies, posted in Banking and General Ledger)
556 03/19/2019 06:34:27 am
Re: No edit in supplier invoice quick entry (11 replies, posted in Banking and General Ledger)
@Braath Waate.
Is this safe to implement in the core now?
Joe
557 03/13/2019 05:57:33 am
Re: SMTP or phpmailer (4 replies, posted in Wish List)
Hello Guys,
I am aware of the problems. However using the built-in mail function has normally been working ok during the years.
Using phpmailer requires an existing account for using it.
Suggestions are welcome.
Joe
558 03/06/2019 10:00:38 pm
Re: A non-numeric value encountered in \includes\date_functions.inc (4 replies, posted in Report Bugs here)
@PaulShipley
This was a PHP 7.X error. Thanks for finding this and showing the resolution.
Committed to repo. The fixed file can be downloaded here.
Joe
559 03/06/2019 06:10:20 pm
Re: A non-numeric value encountered in \includes\date_functions.inc (4 replies, posted in Report Bugs here)
Which PHP-version is used?
Joe
560 03/04/2019 07:48:20 am
Re: Line 1369 in en_US-demo.sql can be removed (4 replies, posted in Misc. Charts of Accounts)
This has been fixed and committed to stable repo. The AUTO_INCREMENT removal will wait until later due to backwards compatibility.
Joe
561 03/03/2019 04:40:49 pm
Re: Line 1369 in en_US-demo.sql can be removed (4 replies, posted in Misc. Charts of Accounts)
No, hardly not. Will remove it and commit later.
Joe
562 02/26/2019 04:26:23 pm
Re: Tax Inquiry - Does not show output tax info (114 replies, posted in Reporting)
Hello Guys,
I would say that this is rather region specific so I suggest following a global setting like the one selected by Janusz.
We simply put the setting in config.php. That is my opinion.
Joe
563 02/19/2019 07:39:48 am
Re: Last Visit Date with Time (2 replies, posted in Wish List)
This has been fixed and committed to stable repo. Thanks @kvvaradha and @apmuthu.
A fixed file can be downloaded here and replaced.
Joe
564 02/13/2019 02:53:52 pm
Re: Customer balance Report rep101.php has one extra parameter (1 replies, posted in Reporting)
Oops! Thanks @kvvaradha for detecting this. Well it did no harm and the conversion is done immediately after the open balance call.
But it should not be here 
Committed to stable repo.
/Joe
565 02/13/2019 02:32:02 pm
Re: Tax Inquiry - Does not show output tax info (114 replies, posted in Reporting)
@Braath Waate,
Are you suggesting a correction in the core? I have some problems following this thread.
Please be a little more specific if I should change something in the core. Thanks in advance.
/Joe
566 02/11/2019 08:17:51 am
Re: How to process depreciation of assets created 2-3 financial years back (2 replies, posted in Fixed Assets)
Hello,
Janusz wrote these routines. He is informed about this. He is busy at present, but will fix this asap.
Joe
567 01/30/2019 10:28:22 pm
Re: Modularizing the Dashboard (82 replies, posted in FA Modifications)
Hello all, and especial @notrinos.
I have been looking at your work, @notrinos, and it looks very good. I think it should be implemented in the core for release 2.5.
I only have one suggestion. Instead of using the reporting folder I would rather like to make this folder inside the new dashboards folder. and also the includes folder. f.i.
a folder called: widgets and inside this folder all the widgets and the includes folder.
The reason for this is that the reporting folder is more addressed to the reporting system.
We could use all the widgets or some of them in the core. I haven looked at this in detail yet. This is a matter of taste.
I guess you have taken all the current widgets, right?
I will have a talk with Janusz, about merging the stable 2.4.6 into the unstable version and call it 2.5 Alpha, and then we can implement your dashboard variant, is that ok @notrinos.
Janusz has been working on your HRM, but I don't know how far he is, but I think this HRM should also be in the 2.5. I guess it need to be 'merged' with your new ideas as well.
Thank you all for your coorporations in this matter.
/Joe
568 01/27/2019 03:00:55 pm
Re: small bug item units db (2 replies, posted in Report Bugs here)
This has been fixed and committed. Thanks @anoopmb.
We will see later if the function is needed or not.
/Joe
569 01/26/2019 04:10:37 pm
Re: Modularizing the Dashboard (82 replies, posted in FA Modifications)
No, but we have been busy fixing an SQL Injection problem.
Give me some time to evaluate this. It seems good.
/Joe
570 01/25/2019 09:27:25 am
Re: sales_order_ui.inc has a bug (13 replies, posted in Report Bugs here)
571 01/25/2019 12:02:29 am
Re: Entering invoice for tax exempt supplier results in db error? (7 replies, posted in Report Bugs here)
Ok, but the 'STRICT_ALL_TABLES,NO_ZERO_IN_DATE' was implemented by Janusz to prevent SQL Injections. As I told we fixed a lot of sideeffect errors, but your error was another one.
I will ask Janusz to do something about this.
/Joe
572 01/24/2019 10:40:01 pm
Re: Entering invoice for tax exempt supplier results in db error? (7 replies, posted in Report Bugs here)
@Braaht Waate.
Which version of PHP do you use? And did it fix the problem?
Janusz did a security update due to some report of SQL Injections. We have taken most sideeffect errors but you might have run into another one.
Joe
573 01/24/2019 10:35:34 pm
Re: sales_order_ui.inc has a bug (13 replies, posted in Report Bugs here)
575 01/23/2019 10:30:14 am
Re: items_cart class has a logical bug, should be fixed. (1 replies, posted in Report Bugs here)
This has been fixed and committed to repo. Thanks @kvvaradha for detecting this.
A new file for replacement can be downloaded here.
Joe