Search options (Page 22 of 200)

@kvvaradha.

Did you mean that it was ok to change the

line 505 in /sales/includes/ui/sales_order_ui.inc 
from:
            sales_items_list_cells(null,'stock_id', last_sales_order_detail($order, 'stk_code'), false, true, true);
to:
            sales_items_list_cells(null,'stock_id', null, false, true, true);

?

/Joe

For your information accountants will not be confused about how the accounts are balanced when closing a FY. To bring forward (Close) a balanced accounts to the next FY where balance accounts are equal then the result accounts must also be equal where the former Calculated Return now has landed on the Year Results Account, Debit for Gain or Credit for Loss.
This is normal handling for all accountant.
If you are in doubt, please contact your local accountant.

Joe

I don't know what you are doing.
These routines with closing years has been working for at least 12 years without problems.

/Joe

Sure, it was my plan too. A little more interactive perhaps.

/Joe

@Braath Waate.

You are right. It was my fault that this was a missing parameter. Thanks.

@kvvaradha.

It was you that suggested the correct fix, but I accidently missed this function call on a line. Sorry for that.

Fixed and committed to stable repo. The /sales/includes/ui/sales_order_ui.inc can be downloaded here.

/Joe

This has been fixed in core and committed to stable repo.

The fixed file can be downloaded here.

Thanks for finding this!

/Joe

@JimmyC

The file /sales/includes/db/sales_invoice_db.inc has now been fixed and committed to stable.

A Fixed file can be downloaded here

Joe

@jimmyC

I have been doing some investigation about this empty account line.

This line is created if floatcmp reports a balance. Look in gl_db_trans.inc, line 95.
There should also be an error line in your tmp/errors.log file for the date. Please have a look and report.

But the reason that the account code is empty is that there is no System and GL account for 'exchange_diff_act'.
If you go into Setup/System and GL setup and look up this account, there might be a value here, but if it doesn't show the right account change the account to show the right act, then save the setup.

Then please try another Direct Invoice. Now it should work.

/Joe

Hello again.

I found the place to fix the bug and this has been committed to stable repo.

/Joe

@JimmyC.

I cannot reproduce your examples in version 2.4.6. However there was a presentation bug in Sales Order View.

In the Direct Invoice, the Sales Order is automatically created with the reference 'auto'. The value in the due_date field was the later invoice due_date. So in the dispatch view, you will see the label 'Due Date' instead of 'Requested Delivery'.

Therefore I have changed the 'Sales Order View' to present the 'Due Date' value if the reference is 'auto'.

This should eliminate the misunderstanding.

I am open for other users testing this to see if I have missed another bug.

The view_sales_order.php has been committed to stable repo.

/Joe