• From: India, TN, Karur
  • Registered: 05/16/2014
  • Posts: 1,195

Topic: unnecessary function inside sales_order_db.inc

We have an unused function inside sales_order_db.inc

function name last_sales_order_detail

Subscription service based on FA
HRM CRM POS batch Themes

kvvaradha's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,107

Re: unnecessary function inside sales_order_db.inc

Thanks @kvvaradha.

I will check later.

Joe

  • From: USA
  • Registered: 07/16/2017
  • Posts: 276

Re: unnecessary function inside sales_order_db.inc

It looks like it was inadvertantly removed with this commit which made due to this forum post.

The function is used to bring up the last item ordered by the customer during sales order entry, because often a customer buys the same thing or another item in the same category, making order entry a wee bit faster.

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,107

Re: unnecessary function inside sales_order_db.inc

@Braath Waate.

You are right. It was my fault that this was a missing parameter. Thanks.

@kvvaradha.

It was you that suggested the correct fix, but I accidently missed this function call on a line. Sorry for that.

Fixed and committed to stable repo. The /sales/includes/ui/sales_order_ui.inc can be downloaded here.

/Joe

  • From: India, TN, Karur
  • Registered: 05/16/2014
  • Posts: 1,195

Re: unnecessary function inside sales_order_db.inc

@Braath waate,

You found it where ist was called. I didn't spend time to know it.


@joe mistakes may happen, nothing to worry. Its not that much needy function.

Subscription service based on FA
HRM CRM POS batch Themes

kvvaradha's Website