Search options (Page 2 of 3)

I am using two currencies - selling in USD and buying in TWD, and my base currency is set to TWD.

I'm seeing errors in the general ledger which in think may be related to the currency conversion of sales invoices. This causes my trial balances to be out.

These are very small amounts, but I would like to know if anyone has a suggestion for me.

Here's an example:

General Ledger Transaction Details     Reference     Date     Person/Item
Sales Invoice #3892                             SI891            02/17/2013    
Payment Status: Completed Amount: 104.56 USD

Account Code     Account Name                    Debit             Credit    
4010             Sales                                                 836.038821    
4010             Sales                                                 488.649855    
4510             Discounts Given        97.729971        
4010             Sales                                                 893.697341    
4010             Sales                                                 288.289000    
4510             Discounts Given        288.289000        
4010             Sales                                                 893.697341    
1200             Accounts Receivables 3,014.353388        
Total                                                3,400.372359     3,400.372358

Since updating to 2.3.15 from the previous version, the database backup function is not working as before.

The .gzip and .zip options time out, but the uncompressed backups sometimes work.

Database size is the same as before, and I used to use the .gzip compression without any problems.

I get this message after clicking on the "Email this order" link:

SALES ORDER SO3658 has been sent by email to destination. Email: j

j happens to be the first letter of the intended email address - e.g. james@mycustomer.com

I have set up the email address in the customer contact section.

The email is not sent, though I receive a copy to the address specified to receive BCC emails in the company setup.

The customers email is directed to this address:  j@mymailserver.com

This is with FA 2.3.15

Any ideas how I can correct this?

I've been trying to modify import_multijournalentries.php so that I can import payments. The main change from the existing file is that the function add_bank_trans() has to be used instead of the outdated add_bank_transaction().

I have had a bit of success, but don't know where to go now. I give this to the world. Good luck world...

_____________________________________

<?php
/**********************************************
Author: Tom Hallman
Name: Import Multiple Journal Entries/Deposits/Payments v2.3
Free software under GNU GPL
***********************************************/
$page_security = 'SA_CSVMULTIJOURNALIMPORT';
$path_to_root="../..";

include_once($path_to_root . "/includes/ui/items_cart.inc");
include_once($path_to_root . "/gl/includes/db/gl_db_trans.inc");
include_once($path_to_root . "/includes/session.inc");
//include_once("../dBug.php"); //available from http://dbug.ospinto.com/
add_access_extensions();

// Turn these next two lines on for debugging
error_reporting(E_ALL);
ini_set('display_errors', 1);

//--------------------------------------------------------------------------------------------------
function init_entry(&$entry, $type, $date, $reference, $reference, $date, $person_id)
{
    $entry = new items_cart($type);
    $entry->order_id = 0;
    $entry->tran_date = $date;
    $entry->reference = $reference;
    $entry->memo_ = 'Imported via \'Import Multiple Journal Entries\' plugin';   
}

//--------------------------------------------------------------------------------------------------

function import_type_list_row($label, $name, $selected=null, $submit_on_change=false)
{
    $arr = array(
        ST_JOURNAL=> "Journal Entry",
        ST_BANKDEPOSIT=> "Deposit",
        ST_BANKPAYMENT=> "Payment"
    );

    echo "<tr><td class='label'>$label</td><td>";
    echo array_selector($name, $selected, $arr,
        array(
            'select_submit'=> $submit_on_change,
            'async' => false,
        ));
    echo "</td></tr>\n";
}

//--------------------------------------------------------------------------------------------------

function check_journal_entry(&$entry, $entryid)
{
    // Check that this journal entry adds up!
    if (abs($entry->gl_items_total()) > 0.0001)
    {
        display_error("Error: journal entry with entryid '$entryid' does not balance (import file: '{$_FILES['imp']['name']}')");
        return true;
    }
}

function write_trans($type, $curEntryId, $bank_act, $reference, $date, $amt, $person_id)
{
    if ($type == ST_JOURNAL)
    {
        if (!check_journal_entry($entry, $curEntryId));
            write_journal_entries($entry, false, false); // FA built-in function
    }
    elseif ($type == ST_BANKDEPOSIT || $type == ST_BANKPAYMENT) {
        add_bank_trans($type, $curEntryId, $bank_act, $reference, $date, $amt, 0, $person_id, $currency="", $err_msg="", $rate=0);
    }

}
//--------------------------------------------------------------------------------------------------

function get_dimension_id_from_reference($ref)
{
    if ($ref == null || trim($ref) == '')
        return 0;

    $sql = "SELECT id FROM ".TB_PREF."dimensions WHERE reference LIKE ".db_escape($ref);

    $result = db_query($sql, "could not get dimension from reference");

    $row = db_fetch_row($result);

    return $row[0];
}

//--------------------------------------------------------------------------------------------------
// Begin the UI
include_once($path_to_root . "/includes/ui.inc");

page("Import Multiple Journal Entries / Deposits / Payments");

// If the import button was selected, we'll process the form here.  (If not, skip to actual content below.)
if (isset($_POST['import']))
{
    if (isset($_FILES['imp']) && $_FILES['imp']['name'] != '')
    {
        $filename = $_FILES['imp']['tmp_name'];
        $sep = $_POST['sep'];
        $type = $_POST['type'];
        $bank_act = isset($_POST['bank_account']) ? $_POST['bank_account'] : "";

        // Open the file
        $fp = @fopen($filename, "r");
        if (!$fp)
        {
            display_error("Error opening file $filename");
        } else {

            // Initialize first entryid & date to be null so that a new one is established
            $curEntryId = null;

            // Prepare the DB to receive the imported journal entries
            begin_transaction();

            // Process the import file
            $line = 0;
            $entryCount = 0;
            $error = false;
            $errCnt = 0;
            while ($data = fgetcsv($fp, 4096, $sep))
            {
                // Skip the first line, as it's a header
                if ($line++ == 0) continue;

                // Skip blank lines (which shouldn't happen in a well-formed CSV, but we'll be safe)
                if (count($data) == 1) continue;

                // Parse the row of data; Format: entryid,date,reference,accountcode,dimension1,dimension2,amount,memo
                list($entryid, $date, $reference, $code, $dim1_ref, $dim2_ref, $amt, $memo, $person_id) = $data;

                // If the entryid has changed, create the current journal entry (if there was one) and start a new one

                if ($entryid != $curEntryId) {

                    // Check that date is properly-formatted
                    if (!is_date($date)) {
                        display_error("Error: date '$date' not properly formatted (line $line in import file '{$_FILES['imp']['name']}')");
                        $error = true;
                    }

                    // Check that the date is in range
                    if (!is_date_in_fiscalyear($date)) {
                        display_error("Error: date not in fiscal year (line $line in import file '{$_FILES['imp']['name']}')");
                        $error = true;
                    }

                    // Assign a default reference if it is not specified
                    if ($reference == '') {
                        // If the entryid has shifted but date is the same, it needs another reference
                        if ($date == $curDate)
                            $refCount++;
                        else // else the entryid and date have shifted, so we can start with a new reference
                            $refCount = 1;
                        list($day, $month, $year) = explode_date_to_dmy($date);
                        $reference = "$month/$day-$refCount";
                    }

                    // Check that the reference is not in use
                    global $Refs;
                    if ($Refs->exists($type, $reference)) {
                        display_error("Error: reference '$reference' is already in use (line $line in import file '{$_FILES['imp']['name']}')");
                        $error = true;
                    }
//new dBug($curEntryId); //1st time = NULL; 2nd time = 5
print "<br />1<br />";
//new dBug($error);                      //$error is now equal FALSE
print "<br />2<br />";

                    // All good! Initialize a new entry  - if $curEntryId = null -- first time through

                    if ($curEntryId !=null) {
//new dBug($error);
print "<br />3<br />";
                        if ($error = false)
                        {
                            write_trans($type, $curEntryId, $bank_act, $reference, $date, $amt, $person_id);
                            $entryCount++;
                        }
                    }
                    if ($error = true) //How does this become TRUE?
                        $errCnt++;
//new dBug($error);
print "<br />4<br />";
                    $error = false;
                    init_entry($entry, $type, $date, $reference, $reference, $date, $person_id);
                    $curEntryId = $entryid;
                    $curDate = $date;

                }

                if ($entryid == '') {
                    display_error("Error: entryid not specified (line $line in import file '{$_FILES['imp']['name']}')");
                    $error = true;
                }
                // Check that the account code exists
                if (get_gl_account($code) == null) {
                    display_error("Error: Could not find account code '$code' (line $line in import file '{$_FILES['imp']['name']}')");
                    $error = true;
                }
                // Check that dimension 1 exists
                $dim1 = get_dimension_id_from_reference($dim1_ref);
                if ($dim1_ref != '' && $dim1 == null) {
                    display_error("Error: Could not find dimension with reference '$dim1_ref' (line $line in import file '{$_FILES['imp']['name']}')");
                    $error = true;
                }
                // Check that dimension 2 exists
                $dim2 = get_dimension_id_from_reference($dim2_ref);
                if ($dim2_ref != '' && $dim2 == null) {
                    display_error("Error: Could not find dimension with reference '$dim2_ref' (line $line in import file '{$_FILES['imp']['name']}')");
                    $error = true;
                }

                if ($type == ST_BANKPAYMENT)
                    $amt = -$amt;

                // Add to the journal entry / deposit / payment
                if (!$error)

                    $entry->add_gl_item($code, $dim1, $dim2, $amt, $memo);

            }

            // Process final entries in the file
            if (!$error)
            {
                if ($curEntryId != null) {
                    write_trans($type, $curEntryId, $bank_act, $reference, $date, $amt, $person_id);
                    $entryCount++;
                }
            } else
                $errCnt++;

            @fclose($fp);

            // Commit import to database
            if (!$errCnt)
                commit_transaction();

            if ($type == ST_JOURNAL)
                $typeString = "journal entries";
            elseif ($type == ST_BANKDEPOSIT)
                $typeString = "deposits";
            elseif ($type == ST_BANKPAYMENT)
                $typeString = "payments";

            if (!$errCnt) {
                if ($entryCount > 0)
                    display_notification_centered("$entryCount $typeString have been imported.");
                else
                    display_error("Import file contained no $typeString.");
            }
        }
    }
    else
        display_error("No import file selected");
}

start_form(true);

start_table(TABLESTYLE2);

if (!isset($_POST['type']))
    $_POST['type'] = ST_JOURNAL;

if (!isset($_POST['sep']))
    $_POST['sep'] = ",";

table_section_title("Import Settings");
import_type_list_row("Import Type:", 'type', $_POST['type'], true);
if ($_POST['type'] != ST_JOURNAL)
    bank_accounts_list_row( $_POST['type'] == ST_BANKPAYMENT ? _("From:") : _("To:"), 'bank_account', null, false);
text_row("Field Separator:", 'sep', $_POST['sep'], 2, 1);
label_row("Import File:", "<input type='file' id='imp' name='imp'>");

end_table(1);

submit_center('import', "Perform Import");//,true,false,'process',ICON_SUBMIT);

end_form();

end_page();

?>

A customer returned an order that was paid by credit card. I did the following:

1. Payment to customer to indicate credit card refund
2. Customer Transactions Inquiry -> Sales Invoice -> Credit This icon
3. Credit quantity = full amount of each item originally purchased -> Items returned to inventory

Now when I check the credit note (Customer Transactions -> Customer Credit Note) there is an extra item in the list. The customer originally bought 4 different items, and the credit note shows 5 items. The extra item has Item Code 1, and is the default item whenever I create a new sales order.

The credit note "TOTAL CREDIT" is the right amount, but the extra item should not be there.

FA v 2.3.12