If you add parameters make sure they are referenced correctly in the code where they are used.
2,502 10/27/2017 01:17:20 pm
Re: Bug in Journal Inquiry View (18 replies, posted in Report Bugs here)
@dz: you have now added to the confusion.
Please be consistent with the order of the fields in the primary key as it should match the standard Charts and those that get upgraded using the sql/alter2.4.sql file.
2,503 10/27/2017 09:42:57 am
Re: Add Items on the Fly. Behavior Changed in FA24 (8 replies, posted in Items and Inventory)
This problem does not arise in FA 2.3.x.
The equivalent in FA 2.3 is placed just before the end_form(); statement like:
hidden('popup', @$_REQUEST['popup']);
In FA 2.4 we have Fixed Assets too as Items and the possibility of @... returning a NULL / false instead of a 0 in current strict syntax of later PHP versions prompted the solution for this commit.
2,504 10/27/2017 09:10:49 am
Re: db connection scripts fixes (5 replies, posted in Report Bugs here)
Isn't it better to be a little permissive when a change from strstr to stristr isn't any great penalty?
And also a check to see if it is the first word in the sql?
Also if it is not going to be fixed in the core it will reside in my FA24Mods.
Thanks for the policy info.
2,505 10/27/2017 08:25:59 am
Re: Bug in Journal Inquiry View (18 replies, posted in Report Bugs here)
Existing installs of FA 2.4 can also correct the supp_trans table also and retain the key field order too (as in the commit and in the sql/aletr2.4.sql with:
ALTER TABLE `0_debtor_trans`
DROP PRIMARY KEY,
ADD PRIMARY KEY(`type`,`trans_no`,`debtor_no`);
ALTER TABLE `0_supp_trans`
DROP PRIMARY KEY,
ADD PRIMARY KEY(`type`,`trans_no`,`supplier_id`);
Actually, @itronics order of the key fields is better as it also is in the same order of fields in the table but the sql/alter2.4.sql and the commit are otherwise. The extension Charts too will have to be updated atleast for the supp_trans table.
The above stands fixed in my repo.
2,506 10/27/2017 08:14:12 am
Re: Bug in Journal Inquiry View (18 replies, posted in Report Bugs here)
This does not affect FA 2.3.x as the counterparty "feature" supporting code is present in FA 2.4.x only.
The sql/alter2.4.sql file is already updated in FA 2.4 for both debtor_trans and supp_trans tables.
All the extension Charts need to be updated.
The supp_trans table too needs to be updated accordingly with supplier_id in the place of debtor_no.
2,507 10/27/2017 07:44:19 am
Re: Check Printing (Canada) not showing up on Purchaser Reports in 2.4.2 (9 replies, posted in Modules Add-on's)
That is something a knowledgeable end user should tinker with for FA 2.4.x and submit their findings / fixes. The other check print module for the US should work if you overwrite the files with the ones in my repo where a recent commit was made.
2,508 10/27/2017 07:40:22 am
Re: db connection scripts fixes (5 replies, posted in Report Bugs here)
The stristr is okay to fix instead of the regex except that it will not address checking if it is the first word in the sql.
The idea is that it should be the beginning of the string and not inbetween like CREATE TABLE xxx SELECT * from ....
2,509 10/26/2017 09:00:52 pm
Re: Remove double return in hooks.inc (3 replies, posted in Report Bugs here)
@joe: fix redundant returns.
2,510 10/26/2017 08:52:49 pm
Re: Check Printing (Canada) not showing up on Purchaser Reports in 2.4.2 (9 replies, posted in Modules Add-on's)
The Canada Cheque Print is available in my repo and the files match the ones in the official pkg repo when installed online.
After installing the rep_cheque_print module, activate it for the target company, whilst logged in to the default company. Now when you login to the target company, you will see the reports as expected and attached here.
2,511 10/26/2017 01:49:07 pm
Re: Add Items on the Fly. Behavior Changed in FA24 (8 replies, posted in Items and Inventory)
My fix works.
@joe: can commit it. Diff attached.
2,512 10/26/2017 01:31:26 pm
Re: Integrating an additional Features to enhance Theming (9 replies, posted in Wish List)
You will need to study the default themes and make yours by starting out with a clone of one of them that suits the technology you want / are familiar with. You can post your findings here and document it in the Wiki. That is how the Wiki is what it is today - everyone who's scratched their itch have embellished it with their lessons learned so that others may take it from there..
2,513 10/26/2017 01:28:36 pm
Re: Opening Chrome console always log out FA (3 replies, posted in Report Bugs here)
Post your offer on the job board in this forum and see if someone has the time to assist you with TeamViewer/RDP/VNC.
2,514 10/26/2017 11:41:12 am
Re: What does Tax Algorithm do? (2 replies, posted in Setup)
tax_algorithm is stored as a 1 (Taxes from Totals) / 2 (Sum per line taxes) value in sys_prefs table (ie., on a per company basis) with the former as the default.
The file includes/sysnames.inc lists the possible values as:
$tax_algorithms = array(
TCA_LINES => _("Sum per line taxes"),
TCA_TOTALS => _("Taxes from totals")
);
The function tax_algorithm_list() in the file includes/ui/ui_lists.inc gets the select box suitable populated with the above.
The file admin/gl_setup.php is currently the only file that calls the above function and provides the form and its processing code for the said field.
The Wiki page still shows the screeenshot and writeup for FA 2.3 where it was not available then. Stands updated.
Study the code in the function get_tax_for_items() in the file taxes/tax_calc.inc. The function round2() is used as the rounding function and is defined in includes/current_user.inc:
function round2($number, $decimals=0)
{
$delta = ($number < 0 ? -.0000000001 : .0000000001);
return round($number+$delta, $decimals);
}
In each case of it's use, the $decimals parameter was taken from the user choices using $dec = user_price_dec();.
2,515 10/26/2017 11:32:50 am
Re: Unable to Edit or Void a Credit Note (14 replies, posted in Accounts Payable)
Does it work okay from FireFox or from some other PC? This is clearly some php setting or apache conf setting that may be at fault. Do a complete check of all files for differences with the core.
2,516 10/26/2017 11:29:59 am
Re: Opening Chrome console always log out FA (3 replies, posted in Report Bugs here)
More likely the Chrome setting for cache / cookie availability in the popup.
2,517 10/26/2017 11:28:22 am
Re: Recurring Invoices ... A Problem (35 replies, posted in Accounts Receivable)
The Mail Send seems to be placed in the wrong inner loop.....
2,518 10/26/2017 11:24:50 am
Re: How to change $systypes_array headings (3 replies, posted in Reporting)
When using it in the class let it be:
var $extn_$systypes_array = $systypes_array;
$this->extn_systypes_array[ST_SALESINVOICE] = _('Donations');
2,519 10/26/2017 11:09:35 am
Re: Add Items on the Fly. Behavior Changed in FA24 (8 replies, posted in Items and Inventory)
@joe: fix?
Lines 532 to 547 in inventory/manage/items.php:
div_start('controls');
if (!isset($_POST['NewStockID']) || $new_item)
{
submit_center('addupdate', _("Insert New Item"), true, '', 'default');
}
else
{
if (@$_REQUEST['popup']) hidden('popup', 1);
submit_center_first('addupdate', _("Update Item"), '',
$page_nested ? true : 'default');
submit_return('select', get_post('stock_id'),
_("Select this items and return to document entry."));
submit('clone', _("Clone This Item"), true, '', true);
submit('delete', _("Delete This Item"), true, '', true);
submit_center_last('cancel', _("Cancel"), _("Cancel Edition"), 'cancel');
}
We need to let the resultant page after insertion know that it came from a popup. Hence move the line:
if (@$_REQUEST['popup']) hidden('popup', 1);
to be the second line in the snippet above.
2,520 10/26/2017 11:05:51 am
Re: Integrating an additional Features to enhance Theming (9 replies, posted in Wish List)
FA 2.4 has such theming ready renderers that allow for hooks into them which is way simpler than Joomla or Wordpress.
2,521 10/26/2017 11:04:30 am
Re: Marked items are overdue - Supplier Invoices (1 replies, posted in Accounts Payable)
Check the terms of payment choice for such invoices if you find a pattern.
2,522 10/26/2017 11:00:30 am
Re: Item Assembly Costs Account (1 replies, posted in Banking and General Ledger)
The relevant Wiki pages are:
https://frontaccounting.com/fawiki/index.php?n=Help.ItemsAndInventory
https://frontaccounting.com/fawiki/index.php?n=Help.Manufacturing
SalesKits are mere bunching of items for a bundle sale.
If you are using the UK CoA from the official pkg repo, please note that it has some field order differences from the standard en_US-new.sql Chart that FA relies on. You can fix it by overwriting your CoA in the sql folder with the one from my repo.
2,523 10/26/2017 10:52:55 am
Re: How to Hide Reports (4 replies, posted in Reporting)
No, just see if you can hide the Sales tab from one of your extensions and make it persist....
2,524 10/26/2017 10:47:57 am
Re: FA2.4.2 error getting exchange rate from Google (55 replies, posted in Report Bugs here)
# nslookup finance.google.com
Non-authoritative answer:
Name: www3.l.google.com
Address: 172.217.26.206
Aliases: finance.google.com
# nslookup 172.217.26.206
Name: maa03s23-in-f206.1e100.net
Address: 172.217.26.206
The IP address keeps changing since it is part of a set of ranges allotted to Google.
FA 2.3 users too can port it if they use GOOGLE as their exchange rate service provider with suitable changes in IP if necessary only if it keeps failing them with the errors listed in the first post here. It stands backported in my repo's FAMods for FA2.3.x.
2,525 10/26/2017 10:09:35 am
Re: Partial Delivery - insufficient quantity - Bug? (5 replies, posted in Report Bugs here)
@joe: while fixing this check on any alert thresholds to inform the user that the remaining is out of stock.
Hope you had enabled the config variable to allow negative stock.