Bug due to commit

Please try to give more details about this. I don't know how to fix it.

Joe

The following test code was executed in PHP 5.3.3:

    $a = 0; // Scalar
    $b = count($a);
    echo var_dump($b); // returns int(1)

    $a = array(); // Array
    $b = count($a);
    echo var_dump($b); // returns int(0)

Hence we should return a 1 if it is a scalar and not a 0!

@joe: Please commit this and verify that all files that partook of this change and the ones before this function came in are all okay.

Found this bug after new commit

And I doubt this one also have logical error after this new commit.

@notrinos

The function is_positive_int doesn't work as you provide in php 7.2.

However changing

if (!is_positive_int($trans_no))
to
if (!trans_no)
do work.

what do you think?

joe

before the function count_array() was deployed we used PHP build in function count() for validating both array and number
since the count() has been changed to validate array, object only so we need to create new function in FA for checking both number and array.
The current function count_array() should be modified to:

function fa_count($input)
{
    if(is_array($input))
        return count($input);
    elseif(ctype_digit($input) && (int)$input > 0)
        return (int)$input;
    else
        return 0;
}

Do this we could change every curently count() to fa_count() without worry about errors that may arise somewhere.

Hello again,

I have now tested your example, @notrinos, and it doesn't work as intended.
I have now changed the function count_array($array) in /includes/ui/ui_globals.inc to this:

function count_array($array)
{
    return (is_array($array)) ? count($array) : (($array === NULL) ? 0 : 1);
}

and it works for PHP versions 7.2.12, 7.1.9, 7.0.23, 5.6.31, 5.5.25 and 5.4.10.

It gives the same return as the old count() without errors or warnings.
We only have to convert more counts() if we detect more errors. We can wait until next major to do this.

This has now been committed and a new file can be downloaded here:

/Joe.