Search options (Page 97 of 97)

This looks like taxing structure bug.
This is how I understand tax procedures in FA:

We have 3 tax tables:
1. Taxes - all tax rates used in system;
2. Item Tax Types - category of goods (from fiscal authority point of view)
3. Tax Group - defines sources of taxation e.g. domestic sales, export, sales for special subject (tax exemptions).

The tax group selected for any customer makes a filter which (during invoice processing step) selects tax charges specified by item's tax type. Shipping costs are special case, so we can select which Tax Group is appropriate for them (Tax Shipping option).

Such special tax group should be unique, but in Tax Groups page we can set more then one - this is first issue. The second and worse is that in get_tax_for_items() function (tax_calc.inc) shipping tax is calculated for all tax rates of customer tax group, not for this special group with Shipping Tax option set.

This is source of incorrect shipping tax calculation, isn't it?

Looks pretty . Some fast remarks:
1) Mozilla 1.7.8:
After click on view/edit icons in last column new window is broken: record data is presented out of the window on the right. All other seems to work fine.
2) Konqueror 3.3.2 seems to be not usable on this page. There is a lot of faults which source can be at browser, not the page code. I do not trust Konqueror at all.

Is FA 2,0 source code based on any template engine ?

Regards
janusz

Hi joe
I think it is not big problem when such non-native messages are seen in case of fatal/rare errors such as database corruption.
Gettextization of all program messages and leaving rarely used ones untranslated doesn't hurt. On the other hand smaller .pot file meens more potential translators. People are lazy .
Any way this is not very important issue, and actual ~1600 messages to translate is far enough for me.

Hi joe
I double checked the problem and found that you are partially right.
If the backup tool is used on account with any standard prefix or to install fresh new company from reference files (sql statements with prefix 0_)  all is correct.

But the problem exists. If you are logged on account with no prefix db_export() makes backup file for the whole database (all table sets). And here problems described in my earlier posts arise.

Below is new patch which remove this issue. One issue still exists, but must be changed in report generator module. database xx_reports is backed up only for user which has empty prefix.

Regards
janusz

--- /var/www/frontaccounting/admin/db/maintenance_db.inc    2007-10-01 10:13:28.000000000 +0200
+++ /var/www/fa/admin/db/maintenance_db.inc    2007-12-30 13:20:45.000000000 +0100
@@ -126,7 +126,6 @@
        $line = trim($line);

        $line = str_replace("0_", $connection["tbpref"], $line);
-        $line = str_replace("Y_", "0_", $line);
        // the last line did not belong to a 'create' sql query
        if (!$table)
        {
@@ -321,7 +320,8 @@
     $all_tables = array();
     while($row = db_fetch($res))
     {
-        if ($conn["tbpref"] == "" || strpos($row['Name'], $conn["tbpref"]) !== false)
+        if (($conn["tbpref"] == '' && !preg_match('/[0-9]+_/', $row['Name']))
+         || ($conn["tbpref"] != '' && strpos($row['Name'], $conn["tbpref"]) !== false))
             $all_tables[] = $row;
     }

I can't remember what was exact source of troubles with another encodings used with R&OS, but some people wasted a lot of time to make it run. With no effects. I personally tried to use it with iso8859-2 (Eastern Europe) encoded fonts, and I give up. To use FPDF with foreign encodings you must recode fonts too. And it works with no troubles for such exotic languages as Japan, Chinesee, Korean or even Polish .
I've working FA test instalation for the latest option. If you want I can send you via email or ftp whole package with prepared fonts to test.

Regards
janusz

Hi, joe
AFAIK there is simple way to do it in JS. Below are changes to pdf_report.inc which are simply and effective.

Regards
janusz

BTW. On the invoice printing there was reference text placed instead od invoice #. Below this mistake is removed too.
jd

--- /var/www/frontaccounting/reporting/includes/pdf_report.inc    2007-09-06 22:15:37.000000000 +0200
+++ /var/www/fa/reporting/includes/pdf_report.inc    2007-12-29 11:07:23.000000000 +0100
@@ -341,7 +341,7 @@
        else if ($doctype == 9) // SO
            $this->Text($mcol, $myrow['order_no'] ." ".$myrow['customer_ref'], $mcol + 90);
        else // INV/CRE/STA   
-            $this->Text($mcol, $myrow['reference'], $mcol + 90);
+            $this->Text($mcol, $myrow['trans_no'], $mcol + 90);
        $this->Text($mcol + 90, $myrow['debtor_no'], $mcol + 180);
        if ($doctype == 8 || $doctype == 9)
            $this->Text($mcol + 180, sql2date($myrow['ord_date']));
@@ -696,16 +696,13 @@
            }
            else
            {
-                echo '<html>
-                        <head>
-                            <SCRIPT LANGUAGE="JavaScript"><!--
-                          function go_now () { window.location.href = "'.$fname.'"; }
-                          //--></SCRIPT>
-                      </head>
-                      <body onLoad="go_now()"; >
-                        <a href="'.$fname.'">click here</a> if you are not re-directed.
-                      </body>
-                    </html>';
+
+                header('Content-type: application/pdf');
+                header('Content-Disposition: inline; filename=PriceListing.pdf');
+                header('Expires: 0');
+                header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
+                header('Pragma: public');
+                $this->Stream();
            }        
            // also have a look through the directory, and remove the files that are older than a week
            // rather want to save 'em