2,251 Reply by apmuthu

(4 replies, posted in Setup)

Currently FA does not have such a filter.

@joe: Another new field in the user's table changeable by the admin or other empowered user roles?

Go to forum: Setup

2,252 Reply by apmuthu

(21 replies, posted in Reporting)

State which report (Navigation sequence / repXXX.php number) that you want customised.

Go to forum: Reporting

2,253 Reply by apmuthu

(13 replies, posted in Reporting)

Use the FA Master 2.4.3+ as it stands included in the core now. If you already have a v2.4.3 install, then update it with the changed files since release from the Announcements post for the release.

Go to forum: Reporting

2,254 Reply by apmuthu

(55 replies, posted in Report Bugs here)

Then Google must be playing random tricks for your IP range....
Their search results have become very diluted in the last 6 months or so.
Time for a brand new human vetted one sans corporate control.
I will revert when I ave a new test OpenVZ install ready.
You can PM me a temporary PPTP VPN for your ISP for me to test.

Go to forum: Report Bugs here

2,255 Reply by apmuthu

(24 replies, posted in Accounts Receivable)

When days = -1 and the day of the last sent date is 29, 30 and 31 which are part of valid dates after computation of $next if they become the last day of that month, this is what is desirable. If however, those $next dates are not valid, then they should be pushed to the last day of that month. The Karnaugh map of this logic on reduction just means irrespective of the day part of the last sent date, just push it to the last day of the computed $next date. he question is that how is the computation of the $next date to be undertaken for edge conditions. The "-1" according to the wiki is just a token to indicate the last date of the previous month as the $next date - so what is the logic needed to code it that way so that it will not have to rely on hindsight.

Go to forum: Accounts Receivable

2,256 Reply by apmuthu

(23 replies, posted in Report Bugs here)

The customer filter remains so even in my code but does that determine the currency as well? Anyone using the filters, be it customer and / or currency will know what to expect of the results of the output subset. The changes in the code here will not affect any other report as it is localised only.

Yes, it is not a big deal. We can leave it as is and the code here can be used at will by those who need it - maybe I will put it in my FA24Mods.....

Go to forum: Report Bugs here

2,257 Reply by apmuthu

(23 replies, posted in Report Bugs here)

There is no major change to this file. Just a currency filter in the where statement and an extra table join for it and that too only when the currency is chosen.

Go to forum: Report Bugs here

2,258 Reply by apmuthu

(55 replies, posted in Report Bugs here)

OpenSSL issue?

Go to forum: Report Bugs here

2,259 Reply by apmuthu

(3 replies, posted in Accounts Receivable)

Refer this post and the wiki page.

However, a payment terms of Cash does not show Customer Pre payment link.

Go to forum: Accounts Receivable

2,260 Reply by apmuthu

(23 replies, posted in Report Bugs here)

Even if just 1 invoice is chosen and no currency filter is in place - all currencies will be allowed - there is no change in the code / sql for this choice of no currency.

@joe: should the file be committed?

Go to forum: Report Bugs here

2,261 Reply by apmuthu

(19 replies, posted in Reporting)

The effect of the Report End is achieved if the last ruled line is bolded or is a double bold line.

The spaces should not be implemented as a translatable string even if you use it. The column widths and their paddings are better adjusted instead.

Go to forum: Reporting

2,262 Reply by apmuthu

(23 replies, posted in Report Bugs here)

Try to use the attached rep107 and provide feedback.
This method has the ability make the report quicker on currency filter doing it in the sql itself.

@joe: see if it is fit to be committed into the core.

Go to forum: Report Bugs here

2,263 Reply by apmuthu

(23 replies, posted in Report Bugs here)

Actually, if the currency is not available, the report can be programmed to skip it. PARAM_2 is the Currency and the records should be skipped if it is to be filtered out in line 104.

Go to forum: Report Bugs here

2,264 Reply by apmuthu

(19 replies, posted in Reporting)

@joe: Nice work removing _("  ") (how did I miss it and why did @stefan put it in?). Also consolidating the comments and removing $loc2 (why did @stefan put it in?) apart from NewLine() and font size adjustments.

Go to forum: Reporting

2,265 Reply by apmuthu

(1 replies, posted in Installation)

@joe: Thanks. Committed.

Go to forum: Installation

2,266 Topic by apmuthu

(1 replies, posted in Installation)

In 2011, local install of packages was introduced where the hooks.php would encompass all install tasks - but that is available in the target company only after activation and not in the default company for the available extensions and their install buttons where the version is "Unknown" and the name is the folder name itself.

This post shows how the third party extensions get listed in the installed_extensions.php file as version  => '-' , whereas, it is listed as blank elsewhere so that the "Install Extension" icon in the extensions listing gets enabled. This happens at the end of includes/packages.inc:

/*
    Check basic extension source compatibility.
*/
function check_src_ext_version($ext_v)
{
    global $src_version;

    $compat_levels = 2;    // current policy is keeping compatibility on major version level.
    $app = explode('.', substr($src_version, 0, strspn($src_version, "0123456789.")));
    $pkg = explode('.', substr($ext_v, 0, strspn($ext_v, "0123456789.")));

    for ($i=0; $i < min($compat_levels, count($app)); $i++)
        if ($pkg[$i] < $app[$i])
            return false;

    return true;
}

which should now be corrected to be effective only when it is not a third party extension like:

/*
    Check basic extension source compatibility.
*/
function check_src_ext_version($ext_v)
{
    global $src_version;
    if ($ext_v != '-') {
        $compat_levels = 2;    // current policy is keeping compatibility on major version level.
        $app = explode('.', substr($src_version, 0, strspn($src_version, "0123456789.")));
        $pkg = explode('.', substr($ext_v, 0, strspn($ext_v, "0123456789.")));

        for ($i=0; $i < min($compat_levels, count($app)); $i++)
            if ($pkg[$i] < $app[$i])
                return false;
    }
    return true;
}

The logic to display the "Install extension" button/icon should be altered to read from a _init/config file if present in the third party module folder itself thereby populating the version and name fields as well instead of being "-" and folder name respectively as obtains now.

Currently the presence of a Version in the _init/config file in the official packages is provided to the available parameter on install when extracted using the function get_extensions_list() defined in includes/packages.inc.

@joe: kindly incorporate the fix listed here for a start so that third party installs do not get broken and / or resorting to use kludgy workarounds.

Go to forum: Installation

2,267 Reply by apmuthu

(24 replies, posted in Accounts Receivable)

Also we can make sure that if the Invoice Date becomes 29 to 31 we need to push it to the end of the month if it is invalid (like 31st Feb). That way, can we do away with the "-1" days by always choosing 31st of some valid / invalid month?

Go to forum: Accounts Receivable

2,268 Reply by apmuthu

(24 replies, posted in Accounts Receivable)

The method of date calculation for add_months() has been hardcoded for
1 leap day each 4 years,
1 more leap day each 100 years and
1 less leap day every 400 years.
The number of days each month are looked up in an array in this manner.

This translates into the famous "What day would Christmas be in the year ####" as absolute day of Christmas for a known year + no. of years to required year from known year * 1.2496.

That is why I wanted the Gregorian year php function to be used. Even then I doubt this issue would get solved fully.

Let us first determine what we want for each of the 29 (non leap years), 30, 31 dates.

Go to forum: Accounts Receivable

2,269 Reply by apmuthu

(55 replies, posted in Report Bugs here)

Looks like you have a php.ini issue as well.

Set in php.ini: allow_url_fopen=1 and restart your webserver.
It works well in PHP 5.3.1, 5.3.3 and 5.5.

Go to forum: Report Bugs here

2,270 Reply by apmuthu

(3 replies, posted in Reporting)

Sales => Sales Types => Tax Incl. => Yes / No.

Go to forum: Reporting

2,271 Reply by apmuthu

(9 replies, posted in Dimensions)

There are only 2 Dimensions possible in FA as of now. However, each Dimension can have multiple sibling heads. If Dimension 1 is Department, then there can be several Departments in it.

Go to forum: Dimensions

2,272 Reply by apmuthu

(55 replies, posted in Report Bugs here)

What versions of PHP did you check earlier?

Go to forum: Report Bugs here

2,273 Reply by apmuthu

(24 replies, posted in Accounts Receivable)

Shall we code so that:

Test expected    -1    1    31-12-2016        1    31-01-2017    31-12-2016 - 30-01-2017.

The last sent will then become 31-01-2017 ?

Go to forum: Accounts Receivable

2,274 Reply by apmuthu

(5 replies, posted in Installation)

@stefan: would you like to submit the function changes?

Go to forum: Installation

2,275 Reply by apmuthu

(55 replies, posted in Report Bugs here)

Do a Winmerge diff check on your FA install root and the Github master codebase and see if there are any other file differences.

You can also use online diff tools like:

https://www.diffnow.com/
https://www.diffchecker.com/
http://www.comparemyfiles.com/

Go to forum: Report Bugs here