Logout, close all browser instances and then login. Check the db that the serial numbers of the vouchers do not already exist in your FA instance. Then try it again.

It appears that you are using the dry run method which is used for checking. Try the actual run choice.

The Official Extensions repo has become a nightmare for some as they have not been updated properly by the respective authors / maintainers in recent times. Compounded with this is the fact that PHP/MySQL versions too have been rapidly evolving. Hence the onus is on the end user to take suitable precautions like this non exhaustive list:

1. Take backup before any new module installation
2. Read the module code if PHP savvy
3. Compare the code in the modules folder with those in the FA24Extensions repo and other repos and use your own judgement before relying on any source.
4. Search the forums and the wiki and other's weblogs for pertinent gotchas.
5. Rollback any bad extension install
6. Ensure that the FA DB schema is not changed on such roll back - a restore from backup is better and advised.
7. File additions/deletions and modifications especially in the various installed_extensions.php files need to be rolled back as well.
8. Many Charts of Accounts when taken from the official repo will not have their field name orders in synch with the default ones.

If you are dealing with a commercial / production installation, do not use FA (or for that matter any ERP) without professional assistance - smart people's time will need to be paid for well and are certainly worth much more than many dumb superior's salaries! Those who pretend to be "self-sufficient" IT heads responsible for FA in their organisations are actually doing a great disservice to their employers - all will be well till something goes wrong and then heads roll or a coverup occurs - either way FA gets a bad name!

1,304

(14 replies, posted in Report Bugs here)

For those who want the Fiscal Year Ending {EE}/{EEEE} format as well, it is available in my commit.

If all that is different is just some colour(s) in a theme, then a selectable css can be implemented instead of more themes.

1,306

(14 replies, posted in Modules Add-on's)

Hope this addresses the new argument in the calls in:

gl/view/accrual_trans.php
reporting/rep702.php
reporting/rep704.php

https://www.w3schools.com/php/default.asp

1,308

(14 replies, posted in Report Bugs here)

Then we can also have the fiscal year end date as {EE} and {EEEE} as well so that we can have ###/2018-19 if we use {NNN}/{FFFF}-{EE}.

1,309

(14 replies, posted in Modules Add-on's)

The 4th post in this thread lists the files that use the said function.

1,310

(14 replies, posted in Report Bugs here)

@joe: This can be included. Commit Diff.

1,311

(14 replies, posted in Report Bugs here)

@anoopmb: kindly submit your tested code changes for peer review and inclusion in the core for both {Y} and {YYY}.

Check from your browser if the following can be downloaded:

http://anonymous:password@repo.frontaccounting.eu/2.4/Release.sig
http://anonymous:password@repo.frontaccounting.eu/2.4/Release.gz

Although the folders in the path above are available for v2.4.1, 2.4.2, ... 2.4.6, they may contain outdated files and in the latest 2.4.6 folder path, the Languages are packed wrongly though some updated versions exist.

It is possible your local IP may be blocked by virtue of the server subscribing to some blacklist in your IP resides.

Which extension do you wish to install manually? Just extract the contents and place them in a folder (folder name listed in _init/config file) inside the modules/ folder. It should then appear in your list of extensions available for installation without the need to download from the official extensions repo. This is only for the "extensions" and not for the charts, themes or languages.

@joe: Which path is the latest that needs to be set in version.php ?

1,313

(14 replies, posted in Report Bugs here)

This Wiki page points to this thread.

@joe: Along with {Y}, try to include {YYY} to indicate both years if they lie in different calendar years like /2018-19.

1,314

(14 replies, posted in Modules Add-on's)

@joe: It might be worthwhile to synch the function get_gl_transactions() with that of @braathwaate. The said function is defined in gl/includes/db/gl_db_trans.inc and is used in the core in:

gl/inquiry/gl_account_inquiry.php
gl/view/accrual_trans.php
reporting/rep702.php
reporting/rep704.php

Furthermore, it is not used in any other extension as well. Besides, the effective_rate is not used anywhere at all (but used in the list of sql fields in function get_trans_tax_details in it!

In fact, the function get_trans_tax_details() from lines 478 to 493:

function get_trans_tax_details($trans_type, $trans_no)
{
    $sql = "SELECT tax_details.*,
                tax_type.name AS tax_type_name,
                tax_details.rate AS effective_rate,
                tax_type.rate AS rate
        FROM ".TB_PREF."trans_tax_details tax_details,
            ".TB_PREF."tax_types tax_type
        WHERE 
            trans_type = ".db_escape($trans_type)."
        AND trans_no = ".db_escape($trans_no)."
        AND (net_amount != 0 OR amount != 0)
        AND tax_type.id = tax_details.tax_type_id";

    return db_query($sql, "The transaction tax details could not be retrieved");
}

can now be simplified to be:

function get_trans_tax_details($trans_type, $trans_no)
{
    $sql = "SELECT tax_details.*, tax_type.name AS tax_type_name, tax_type.rate AS rate
        FROM ".TB_PREF."trans_tax_details tax_details INNER JOIN 
        ".TB_PREF."tax_types tax_type ON tax_type.id = tax_details.tax_type_id
        WHERE 
                trans_type = ".db_escape($trans_type)."
            AND trans_no = ".db_escape($trans_no)."
            AND (net_amount != 0 OR amount != 0)";

    return db_query($sql, "The transaction tax details could not be retrieved");
}

1,315

(2 replies, posted in Announcements)

Unresolved Issues
* Post- commits being checked out
* Post- Need to revert -this commit - Fixed for now in this Post

Post Release Fixes attached.

1,316

(14 replies, posted in Modules Add-on's)

@braathwate: Your report uses your custom functions in ui_controls.inc and ui_view.inc files that have been appended to your quickreport_inquiry.php file for testing:

function scroll_down($div)
{
    global $Ajax;

    $js = "
        var objDiv = document.getElementById('" . $div . "');
        objDiv.scrollTop = objDiv.scrollHeight;
    ";
    if (in_ajax()) {
        $Ajax->addScript(true, $js);
    } else
        add_js_source($js);
}

function get_js_history($vars)
{
    $js = ' 
    function changeVar() {
        var stateObj = { foo: "bar" };
        var state = "";
';

    $first = true;
    foreach ( $vars as $var ) {
        $js .= '
        var element = document.getElementsByName("' . $var. '");
        if (element[0])';
        if ($first) {
            $first = false;
            $js .= '
            state += "?';
        } else
            $js .= '
            state += "&';
        $js .= $var .'="' . ' + element[0].value;';
    }

    $js .= '
        history.replaceState(stateObj, "page 2", location.protocol + "//" + location.host + location.pathname + state);
    }';
    return $js;
}

function set_posts($vars)
{
    foreach ( $vars as $var )
        if (isset($_GET[$var]))
            $_POST[$var] = $_GET[$var];
}

@joe: see if you want to include them into the core.

The js history and remembering past form field values will result in a cache use and erroneous Ajax output like when a specific customer is chosen first and then a Supplier is chosen without resetting them selectively.

Also, your use of the function get_gl_transactions() in the said report has 12 arguments whereas the standard one in gl/includes/db/gl_db_trans.inc has only 11. The extra argument used is

get_post('person_type')

.

Get all cookie data and permissions necessary before handing over to the theme.

See attachment - overlap remains - FireFox 52ESR on WinXP SP3.

Hope you have extension openssl .dll/.so enabled in your php.ini.

FA 2.3.22 should have been updated to 2.3.26 and a backup taken of the FA folder (company and installed extensions / languages and the sql dump of the db.

1,319

(14 replies, posted in Report Bugs here)

@joe: This will be desirable to include in the core - {Y}.

1,320

(114 replies, posted in Reporting)

Place the sql file in the sql folder in FA and create a new company using it. Check if all is well first.
Compare the sql dumps of the schema between your existing install and the new sql file and synch them and their data into the new install.

1,321

(14 replies, posted in Modules Add-on's)

Missing file include at line 15 of quickreport.php:

include_once($path_to_root . "/includes/foo.inc");

-- Fixed

1,322

(14 replies, posted in Report Bugs here)

Your includes/references.inc line number 99 is for FA 2.3.x.
Lines 121, 122 are for FA 2.4.x.

Just take the Year of the fiscal year beginning only!

Besides, this will all go wrong if the template is created with all the date elements for when there are too many transactions each day and a template like {DD}{MM}{YYYY} is used! A separate template like {Y} may be used for this kind of resetting of the year each fiscal beginning.

There is a function get_fiscalyear_begin_for_date($date) that obtains the financial year beginning in the file admin/db/fiscalyears_db.inc. Also available in it is get_current_fiscalyear(). These functions return the MySQL date format whilst taking the user date format as input where needed.

There is another function begin_fiscalyear() that gets the current fiscal year's begin date in user date format in includes/date_functions.inc.

There is a "Back" link on the calendar display that does it but your method may be useful too - hope it will not clash when multiple date fields are on the same form.

@joe: Attached is the code change in includes/ui/ui_view.inc needed to have the date_picker.js recreated on js cache purge.

1,324

(114 replies, posted in Reporting)

Attached herewith is a make CoA link along with the latest Dutch English CoA for FA 2.4.

The default2 theme needs to fix the overlap of the body heading - see attachment.

@kvvaradha's default theme has a fixed position login screen which needs scrolling to view fully and on login, the menus are vertically spaced too much. Also the black icons are too bold and distractive.