Since FA 2.4 is getting trivial fixes, this can go into it and then get pulled in to FA 2.5.
977 08/25/2019 03:02:23 pm
Re: Why are database values converted to HTML? (4 replies, posted in Report Bugs here)
Please note that this was done when escaping was really long winded in the old days 10 years or more ago with having to carryover large number of users from PHP 4 and MySQL 3.x.
Also a multitude of languages cause quite some heartache across linux/windows platforms that all this was cobbled together with least pain. The forum is replete with such legacy issues.
Possibly in FA v2.5, better HTML escaping and accommodation of HTML encoding / decoding will be implemented.
Nice to have such experienced users like yourself pitch in. Please study the code as it evolves and make suggestions that hopefully will not break existing users installs.
978 08/25/2019 02:56:55 pm
Re: Release 2.4.7 (3 replies, posted in Announcements)
As of 2019-08-19, the FA 2.5 repo has been started as the current unstable branch.
The FA 2.5 is now complemented with it's own unofficial repo.
979 08/25/2019 01:26:13 pm
Re: Why are database values converted to HTML? (4 replies, posted in Report Bugs here)
We do not want code to be executable like "Bennet Cole &$var Co" where $var can be a malicious bit of code change.
980 08/25/2019 01:23:48 pm
Re: Database Prefix vs No Database Prefix? (4 replies, posted in Setup)
User variables can be used to some extent in MySQL but it does not work for table names.
981 08/25/2019 01:22:15 pm
Re: Bug in rep102.php (5 replies, posted in Reporting)
@joe: If such allocations are not accounted for, we need to update the wiki accordingly - or is a fix slated for it in 2.5?
Check the code flow on value of $all in the get_invoices() function in the report.
982 08/25/2019 01:21:15 pm
Re: Working on an extension for invoicing and I have questions... (4 replies, posted in FA Modifications)
@joe: any fix needed here or for 2.5?
983 08/23/2019 09:53:11 am
Re: Problem with supplier invoice transaction date (6 replies, posted in Accounts Payable)
As SA_MULTIFISCALYEARS has been enabled (logged out and logged in again after clearing browser cache), verify the setting is saved in Setup => Access Setup => Role: System Administrator (Role of logged in user).
The function that allows Suppliers, Customers and Items to be entered in older fiscal years is defined in admin/db/fiscalyears_db.inc is is_date_in_fiscalyears() and is used in the function is_date_in_fiscalyear() defined in includes/date_functions.inc where the first said file is "include"d.
Inspect the variables at that point in Line 204 of the last file stated above. The function user_check_access() is defined in includes/current_user.inc file.
Scope, availability and visibility of the variables and their values will be of use in investigating it. If all is well, then scour the scripts that use these values before "post"ing the updated values to the db.
984 08/23/2019 08:33:16 am
Re: Transaction References with Customer Placeholder (5 replies, posted in Accounts Receivable)
@itronics: must this now be added into the core?
985 08/23/2019 08:32:59 am
Re: Transaction References with Customer Placeholder (5 replies, posted in Accounts Receivable)
@itronics: must this now be added into the core?
986 08/23/2019 08:23:50 am
Re: Database Prefix vs No Database Prefix? (4 replies, posted in Setup)
Restoring from a wrong company's backup will limit / avoid data loss if separate prefixes are used.
Also, you can use multiple databases - one for each company - if there is no limitation on your hosting plan.
If the same mysql server hosts both databases, then getting consolidated reports from both database tables is possible and the table prefixes can help avoid using database name prefixes in the field names.
987 08/23/2019 08:17:22 am
Re: Problem with supplier invoice transaction date (6 replies, posted in Accounts Payable)
Switch active fiscal to previous fiscal in Setup => Company Setup temporarily for the change to be done.
988 08/23/2019 08:13:44 am
Re: Bank reconciliation and Bank Account Inquiry and Bank reports (6 replies, posted in Banking and General Ledger)
The affected report reporting/rep602.php was last changed in 2016-09-06 and that too for only a column width change. However, it's include files may have changed since then.
Upgrading to FA v2.4.7+ is trivial as there are no real DB changes.
989 08/23/2019 08:04:04 am
Re: Supplier's Description of an Item resets to default defined in system. (16 replies, posted in Items and Inventory)
@poncho1234: This may not be tenable this way as the checkbox for Editable Description can be changed independant of the specific transaction at any time. However, if it is implemented by checking f a change in standard description from the one used in the PO, then any inadvertent change there may get reflected in the Supplier Invoice without notice - hence a prudent way was sought in the current implementation where a human re-check is envisaged before finalisation.
990 08/19/2019 05:01:00 pm
Re: Some changes in add_supp_invoice to reduce unnecessary query run time (9 replies, posted in FA Modifications)
Forecasting from how many years it took to come in from FA 2.3 to FA 2.4 and the fact that the devs are much older now, take it to be atleast 5 years from when the initial 2.5 branch began. If it is any sooner, thank the advances in coding technologies and that we are now older and wiser 
@kvvaradha: Whatever changes you have in mind to make a start, do let us know here so that it can atleast get into the codebase for those who wish to benefit from it in the meanwhile and form part of FA 2.5 if and when it appears.
Aug 17th 2019 - probably last commit to the 2.4(.7) branch.
Aug 19th 2019 - first commit to merge stable into unstable for 2.5 branch
991 08/18/2019 06:11:37 pm
Re: Supplier's Description of an Item resets to default defined in system. (16 replies, posted in Items and Inventory)
@joe: If this was the original intended functionality, then it must be changed.
When a PO is raised and the Description is edited, then it must persist through to the Supplier Invoice.
992 08/18/2019 02:25:51 pm
Re: Supplier's Description of an Item resets to default defined in system. (16 replies, posted in Items and Inventory)
To rule out PHP/MySQL versions being the cause, check it out on say PHP 5.3.x with MySQL 5.1 and see what gives.
993 08/18/2019 01:44:23 pm
Re: Supplier's Description of an Item resets to default defined in system. (16 replies, posted in Items and Inventory)
You will have to logout and clear browser cache and then login again.
State which version (and date) of FA you are using and what is the server platform and PHP/MySQL versions and browser type and version used.
994 08/18/2019 01:36:34 pm
Re: Manually Enter Invoice Number (6 replies, posted in Accounts Receivable)
The sys_prefs table by default has ref_no_auto_increase disabled but it still works in AutoInc mode.
The error is in the absence of an "else" for line 294 in sales/includes/cart_class.inc and it's positioning after a blank check. The lines 287 to 301 are reproduced here:
function write($policy=0) {
global $SysPrefs, $Refs;
begin_transaction(); // prevents partial database changes in case of direct delivery/invoice
if ($this->reference != 'auto' && $this->trans_no == 0 && !is_new_reference($this->reference, $this->trans_type))
{
if (!empty($SysPrefs->prefs['ref_no_auto_increase']))
$this->reference = $Refs->get_next($this->trans_type, null, array('date' => Today()));
if (!is_new_reference($this->reference, $this->trans_type))
{
commit_transaction();
return -1;
}
}
...
...995 08/18/2019 06:24:32 am
Re: Manually Enter Invoice Number (6 replies, posted in Accounts Receivable)
Keep changing the next invoice number manually in Setup => Transaction References and then let it auto-populate this manually provided value in the invoice you enter. The responsibility of maintaining non duplicate Invoice Number will then vest with you as the system will simply reject duplicates only after entering the invoice.
996 08/18/2019 06:20:56 am
Re: Editing Customer Name on Invoice (3 replies, posted in Accounts Receivable)
Direct Database intervention in the following tables among others:
debtors_master
cust_branch
crm_personsPossibly the audit_trail, sys_prefs, journal and voided tables may have some telltale leftovers.
997 08/18/2019 06:13:44 am
Re: Some changes in add_supp_invoice to reduce unnecessary query run time (9 replies, posted in FA Modifications)
Since this does not affect the DB schema, can we not make a start here?
998 08/18/2019 06:04:19 am
Re: Clone Manufactured Item -> Clone BOM? (7 replies, posted in Items and Inventory)
1. Search the forums and the wiki.
2. Study the DB changes for each transaction / form entry and see if it makes sense.
3. Keep track of the FA version and the DB version in version.php
4. Study the commits in the Repos - Core and Extensions (official and others you follow).
5. Make sure the config.php and sys_prefs table entries match the changes committed in each version.
6. Plug and Pray that nothing breaks.
7. Wish @joe & @itronics a long life to fix anything that goes wrong and gets found
999 08/18/2019 05:56:53 am
Re: Salesman Listing Report 106 - Fix (2 replies, posted in Reporting)
@joe committed it.