Search options (Page 2 of 3)

I found a problem with error message after I voided a customer payment.  This problem has been encountered by other users:

Ref: https://frontaccounting.com/punbb/viewtopic.php?id=4892

When attempt to open a voided customer payment by clicking on the Customer Payment #, the following error message appeared:

DATABASE ERROR : no debtor trans found for given params
sql that failed was : SELECT trans.*,ov_amount+ov_gst+ov_freight+ov_freight_tax+ov_discount AS Total,cust.name AS DebtorName, cust.address, cust.curr_code, cust.tax_id, com.memo_,bank_act,0_bank_accounts.bank_name, 0_bank_accounts.bank_account_name, 0_bank_accounts.account_type AS BankTransType, 0_bank_accounts.bank_curr_code, 0_bank_trans.amount as bank_amount FROM 0_debtor_trans trans LEFT JOIN 0_comments com ON trans.type=com.type AND trans.trans_no=com.id LEFT JOIN 0_shippers ON 0_shippers.shipper_id=trans.ship_via, 0_debtors_master cust, 0_bank_trans, 0_bank_accounts WHERE trans.trans_no='22' AND trans.type='12' AND trans.debtor_no=cust.debtor_no AND 0_bank_trans.trans_no ='22' AND 0_bank_trans.type=12 AND 0_bank_trans.amount != 0 AND 0_bank_accounts.id=0_bank_trans.bank_act

I managed to find a line in  sales/includes/db/cust_trans_db.inc that somehow caused the database error.

    if ($trans_type == ST_CUSTPAYMENT || $trans_type == ST_BANKDEPOSIT) {
        // it's a payment so also get the bank account
        $sql .= " AND ".TB_PREF."bank_trans.trans_no =".db_escape($trans_id)."
            AND ".TB_PREF."bank_trans.type=$trans_type
            AND ".TB_PREF."bank_trans.amount != 0  <<== the "!=" is causing the issue
            AND ".TB_PREF."bank_accounts.id=".TB_PREF."bank_trans.bank_act ";

As stated above, this != 0 is causing the problem.  If I remove "!", then the voided payment will appear normal.  But the normal customer payment will have the same error.

Due to my limited php knowledge, I am not able to fix it. 

I hope this can be fixed as soon as possible or it looks ugly when the user click on the transaction.

Thanks!

/Mark

Under the "Items and Inventory", when an item is selected, there are number of tabs "Sales Pricing", "Purchasing Pricing", "Standard Cost"...etc which will appear black and users can enter the pricing details by clicking on the tab.

I found a access control issue.  If I set the User Access control to disallow the user on "Sales Prices Edition" under Sales Configuration, the user will not see the Sales Pricing (or grey out depending on the config.php setting) under "Items and Inventory" section.  However, if user goes to "Items" and select an item, he still can access the pricing and change the pricing details here by clicking on the "Sales Pricing" tab.  The access to this tab should be denied if the "Sales Prices Edition" is disallowed.

How can this problem be rectified?

Thank you

/Mark

Hi Joe,

Below the dotted line is the topic I extracted from https://frontaccounting.com/punbb/viewtopic.php?id=2076.  The original post was posted back in 2011. 

I would like to ask if the proposed changes (highlighted in blue below) have been implemented to the FA versions say, 2.3.19 or onwards?  That is, FA revaluate the non-home currency AP, AR and the non-home currency bank accounts.

Thank you.

/Mark

.......................................................................
Re: Currency Revaluations - Supplier/Customer balancesI have redirected a similar discussion we have had here.

https://frontaccounting.com/punbb/viewtopic.php?id=2057

I will try to explain how we eventually can solve it in FA. Please correct me if something seems wrong in my explanation.

We save the rate on the debtor_trans and supp_trans and we save the currency on the customer/supplier.

A revaluation could run with the following formula:

SUM all currency customers not fully allocated records with the rate of the record date and SUM all currency customers not fully allocated records with todays rate. The differences are booked on AR account and Exchange Variation Account.

SUM all currency suppliers not fully allocated records with the rate of the record date and SUM all currency suppliers not fully allocated records with todays rate. The differences are booked on AP account and Exchange Variation Account.

Well while we are doing that shouldn't we now replace all the rates on the records with todays rate? Otherwise we can't do this revaluation more times, right?

Can anybody see any side-effects with this?

/Joe

Hi there,

I am trying to figure out more about the functions of FA.

I have 2 questions:

1.   I saw a lot of predefined functions in FA include directories.  Is there a summary or documentation that describe these functions and that I could refer to learn more about these functions.

2.   Also, I saw functions that carry variables (see below) such as 'charge', 'discount', 'amount', 'ref', 'memo_' ...etc.  Would someone please advise where can I find these variables and their definitions?  They seem to me are the names of the database table Name but I'm not sure...

Thanks..

==============================
    amount_row(_("Bank Charge:"), 'charge');

    start_table(TABLESTYLE, "width=60%");

    label_row(_("Customer prompt payment discount :"), $display_discount_percent);
    amount_row(_("Amount of Discount:"), 'discount');

    amount_row(_("Amount:"), 'amount', null, '', $cust_currency);
    textarea_row(_("Memo:"), 'memo_', null, 22, 4);

I have posted this under another post but there is no reply so I transferred the topic to here....

There is a need to implement a control of the invoice number and we have to make the invoice number non-editable by the user when they enter a Direct Invoice or Invoice against a delivery.  We used the Form Setup to assign the first number and let the Invoice number incremental run automatically.

Currently, the Invoice screen will show the Invoice Number assigned by the Form Setup and the field allows user to edit.   This is because of the lines below in sales\customer_invoice.php:

if ($_SESSION['Items']->trans_no == 0) {
    ref_cells(_("Reference"), 'ref', '', null, "class='tableheader2'"); //Invoice Number assigned but editable
} else {
    label_cells(_("Reference"), $_SESSION['Items']->reference, "class='tableheader2'");
}

To make it non-editable, I have replaced the line ref_cells to label_cells as follows:

if ($_SESSION['Items']->trans_no == 0) {
    label_cells(_("Reference"), $_SESSION['Items']->reference, "class='tableheader2'");  //Invoice Number assigned and now not editable
} else {
    label_cells(_("Reference"), $_SESSION['Items']->reference, "class='tableheader2'");
}

With this change, now the Invoice number is assigned (by Form Setups) and not editable.  However, when I process the Invoice, the error "You must enter a reference." shows.  I know I missed out something but I don't know what else to change.  The Invoice Number showed is not assigned to the variable which in turn update the reference in the database tables.  This variable is empty.

Would you please advise what other codes I have to change so that the assigned Invoice number is picked up and update the reference in the Tables?

Thank you.

Mark