Thank you for your feedback. I have checked it from my side again. It automatically  updated. No need to unset the code stock id edit for now.  May be @joe looks this a bit deeper.

@Joe both are same conditions, right?

Though i checked it again, still it passes to the next, db_fetch_row and gives error.

and also while checking this i found another issue in the sales_kit.php
line no 49

qty_cell($myrow["quantity"], false,     $myrow["units"] == '' ? 0 : get_qty_dec($myrow["comp_name"]));

and it has to pass the stock id instead of comp_name

qty_cell($myrow["quantity"], false,     $myrow["units"] == '' ? 0 : get_qty_dec($myrow["stock_id"]));

I tried this @joe, but the if condition didn't work.
though it goes to the next line and gives error.

Trying to access array offset on value of type bool in 

Hope this will fixed your issue @bajrang8955, Test it once and update us here.

I feel something here two changes,

1. During the time of company  creation, we can allow the users to input their fiscal year start date. From that date we can take it to create fiscal years like one user from EU, he needs to start his fiscal year 01-01-20XX and some user like from india 01-04-XXXX, in some countries it starts with 01-06-20XX. And for their system, its difficult to understand where to change and how to change.  But if we give an option in the installation and also in the new company creation, they can input the dates and from that date to till current year, we can loop it and save it in the fiscal_years and also we can set current Year Fiscal id in sys_prefs f_year value.  Hope that takes the system to a bit more fiscal year friendly.

2. From Fiscal years page, we have fiscal year close. Can we also have an option to change the current fiscal year  with a checkbox. so they can change it in the edit of each fiscal, they can able to change it.  Hope this two changes would take effect well,

All these

        return $row[0];

should be changed to

if(db_num_rows($result) > 0){
        $row = db_fetch_row($result);
        return $row[0];
    } else 
        return false;
kvvaradha wrote:

Sure @joe, I will list them and get you the list of  changes.

Here is the total list of changes @joe. it comes with more files, i put a search list here.

/var/www/FA/2410/admin/db/security_db.inc:
   65:     return $row[0];

/var/www/FA/2410/admin/db/tags_db.inc:
   68:     return $row[0];
  108:     return $row[0];

/var/www/FA/2410/dimensions/includes/dimensions_db.inc:
  185:     return $row[0];

/var/www/FA/2410/fixed_assets/includes/fa_classes_db.inc:
   30:     return $row[0];

/var/www/FA/2410/gl/includes/db/gl_db_account_types.inc:
  101:     return $row[0];
  158:     return $row[0];

/var/www/FA/2410/gl/includes/db/gl_db_accounts.inc:
   88:         return $row[0];

/var/www/FA/2410/gl/includes/db/gl_db_bank_trans.inc:
  137:     return $row[0];

/var/www/FA/2410/gl/includes/db/gl_db_banking.inc:
  138:     return $row[0];

/var/www/FA/2410/gl/includes/db/gl_db_rates.inc:
   35:         return $row[0];

/var/www/FA/2410/gl/includes/db/gl_db_trans.inc:
  368:     return $row[0];
  426:     return $row[0];

/var/www/FA/2410/includes/dashboard.inc:
  851:     return $row[0];
  909:     return $row[0];
 1197:     return $row[0];
 1205:     return $row[0];
 1213:     return $row[0];
 1227:     return $row[0];
 1235:     return $row[0];
 1244:     return $row[0];
 1252:     return $row[0];
 1262:     return $row[0];
 1270:     return $row[0];
 1278:     return $row[0];
 1287:     return $row[0];
 1315:     return $row[0];
 1326:     return $row[0];
 1334:     return $row[0];
 1342:     return $row[0];
 1350:     return $row[0];
 1359:     return $row[0];
 1368:     return $row[0];
 1376:     return $row[0];
 1384:     return $row[0];
 1392:     return $row[0];
 1400:     return $row[0];
 1436:         return $row[0];
 1451:         return $row[0];
 1460:     return $row[0];

/var/www/FA/2410/includes/db/connect_db.inc:
   24:     return $row[0];

/var/www/FA/2410/includes/db/crm_contacts_db.inc:
  245:     return $row[0];

/var/www/FA/2410/includes/db/inventory_db.inc:
  170:     return $row[0];
  348:     return $row[0];
  497:         return $row[0];

/var/www/FA/2410/includes/db_pager.inc:
  352:             $this->rec_count = $row[0];

/var/www/FA/2410/inventory/includes/db/items_category_db.inc:
  101:     return $row[0];

/var/www/FA/2410/inventory/includes/db/items_units_db.inc:
   51:     return $row[0];
   75:     return $row[0];

/var/www/FA/2410/purchasing/includes/db/grn_db.inc:
  208:     return $row[0];

/var/www/FA/2410/purchasing/includes/db/suppliers_db.inc:
  147:     return $row[0];

/var/www/FA/2410/reporting/rep103.php:
  100:     return $row[0];

/var/www/FA/2410/reporting/rep205.php:
   56:     return $row[0];

/var/www/FA/2410/reporting/rep306.php:
   89:         return $row[0];

/var/www/FA/2410/reporting/rep310.php:
   90:         return $row[0];

/var/www/FA/2410/reporting/rep451.php:
   36:     return $row[0];

/var/www/FA/2410/reporting/rep601.php:
   39:     return $row[0];

/var/www/FA/2410/reporting/rep602.php:
   40:     return $row[0];

/var/www/FA/2410/sales/includes/db/cust_trans_db.inc:
  247:     return $row[0];

/var/www/FA/2410/sales/includes/db/customers_db.inc:
  135:     return $row[0];

/var/www/FA/2410/sales/includes/db/recurrent_invoices_db.inc:
   88:     return !$row[0];

/var/www/FA/2410/sales/includes/db/sales_delivery_db.inc:
  214:       else $freight = $row[0];

/var/www/FA/2410/sales/includes/db/sales_groups_db.inc:
   52:     return $row[0];
   95:     return $row[0];
  154:     return $row[0];

/var/www/FA/2410/sales/includes/db/sales_invoice_db.inc:
  294:     return $row[0];

/var/www/FA/2410/sales/includes/db/sales_order_db.inc:
  647:         return $row == false ? false : $row[0];

/var/www/FA/2410/sales/includes/db/sales_points_db.inc:
   64:     return $row[0];

/var/www/FA/2410/sales/includes/db/sales_types_db.inc:
   53:     return $row[0];

/var/www/FA/2410/sql/alter2.2.php:
   90:         $max_order = $row[0];

/var/www/FA/2410/taxes/db/tax_types_db.inc:
   76:     return $row[0];

@joe, there is an issue in the ui_view.inc, fix and update it inside the get_js_select_combo_item

here we have if condition for select option and else for the textbox. There inside textbox update, we have the issue.

stock_element.value = value;    

and change this to

stock_element[0].value = value;    

commit this on stable repo.

and @bajrang8955. its updated to work. check it. with this change.

Hello dude. I saw the issue I will get you a solution after checking the code.

335

(10 replies, posted in Dimensions)

I think it already comes. Probably check it dude.

For straight line method, you need to use the purchase cost. so the purchase cost may be 15000 USD, this is a chance.

and probably you need to trace it with calculation from the compute_gl_rows_for_depreciation with some display errors placed in between locations i cant understand full concept of straight line method here programmed. it looks they are getting remaining months and process with new one. so in the each line place some display errors to make it readable for you.

337

(10 replies, posted in Dimensions)

You have deliver from location, which is location of goods.  and you can get the details from it. there is a column in sales_orders table. from_stk_loc, you can connect the locations and get the informations of address, and name,

from sales invoice you can get order no from order_. use that and get the sales_order table connected and get the location and connect it with locations table to get it.

But i guess, there it was already collectetd in the sales invoice and sales order pdf templates. kindly check that clearly before making it depth coding.

Hello dude, May be it will be in the calculation issue, you need to describe, what comes and what you exactly need it with this code. describe that. We needs to understand it.

Sure @joe, I will list them and get you the list of  changes.

We have some more similar functions in all over the FA, which will be going to give trouble for the users, those who buys new cpanel based host or server.  example.

 
function get_unit_dec($stock_id)
{
    $sql = "SELECT decimals FROM ".TB_PREF."item_units,    ".TB_PREF."stock_master
        WHERE abbr=units AND stock_id=".db_escape($stock_id)." LIMIT 1";
    $result = db_query($sql, "could not get unit decimals");
    $row = db_fetch_row($result);
    return $row[0];    
}

and it has to be replaced with

function get_unit_dec($stock_id)
{
    $sql = "SELECT decimals FROM ".TB_PREF."item_units,    ".TB_PREF."stock_master
        WHERE abbr=units AND stock_id=".db_escape($stock_id)." LIMIT 1";
    $result = db_query($sql, "could not get unit decimals");
    if(db_num_rows($result) > 0){
        $row = db_fetch_row($result);
        return $row[0];
    } else 
        return false;
}

This issue happens with many other files as well. @joe check them in all other files and update these functions.

@Joe looks like these two reports doesn't passed properly with the newly added parameters

$labels, $serie1, $serie2

342

(7 replies, posted in Reporting)

Can you provide an elaborated sample or example. So we can understand the issue to find the reason causing it.

It depends on the currencies in your currencies page. Bank and General ledger -> currencies

And then you know your company currency. If you forget check it from setup-> company setup. You can get it there. And apply the currency code 3 digit code USD,  GBP,  EUR, INR like that.

Refer the format and check set the currency code. It will work.

Looks like the gl_close_date is the issue.

Open the sys_prefs table and find this option. And check the date which should be end of fiscal years close date. If you update it. It will work.

Looks like you have voided the transactions.  Once you void a transaction you can't get it back. It usually make the entry 0 in gl trans table. So it's not possible to get it back.

Yes dude I have got your email and replied you back.

I am not sure it covers you full. But check the inventory planning report. And if it's not there. Check inventory valuation report. Other than that if you are looking specific report you need to make them with a developer.

349

(6 replies, posted in Reporting)

Usually it's connected with debtor trans and trans tax details. May be If you customized the fa code you might face this issue..  if possible  try with core new fa. I am sure it will work

350

(6 replies, posted in Reporting)

Edit this post you will get attachment option or post it on some link sharing sites and share link here to access it.