• From: Kenya, Nairobi
  • Registered: 01/25/2020
  • Posts: 52

Topic: Add db_prevoid hook for voiding bank transaction

Since other transactions have a prevoid hook, It would be usefull to extension developers to have a pre_void hook for bank_transactions also.

I would suggest putting below line before 

void_bank_trans($type, $type_no);

(line 41) of admin/db/voiding_db.inc file:

hook_db_prevoid($type, $type_no);
  • From: Kenya, Nairobi
  • Registered: 01/25/2020
  • Posts: 52

Re: Add db_prevoid hook for voiding bank transaction

And also for void_journal_trans. Or basically all transactions that can be voided and don't have this hook

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,160

Re: Add db_prevoid hook for voiding bank transaction

@joe: ??

apmuthu's Website

  • From: Kenya, Nairobi
  • Registered: 01/25/2020
  • Posts: 52

Re: Add db_prevoid hook for voiding bank transaction

@joe what do you say here?

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,107

Re: Add db_prevoid hook for voiding bank transaction

Hello guys.

Sorry for the delay. Will look into this

Joe

  • Registered: 12/25/2007
  • Posts: 2,448

Re: Add db_prevoid hook for voiding bank transaction

Yes, seems good idea. The hooks were implemented to allow extension modules deal with extra fields in databases. I think the overall pre/post hooks system needs some review. I have added mantis report for this issue.