Deleting a fiscal year problem

I am giving the way of my solution. Because I tried one functionality before for the users who are coming to FA from other software's.  Like they wanted to keep the journal of previous customer opening balances as journal entry. And when the customer make payment record the payment against that journal entries.

So the solution is to separate the invoices which are paid on 2015 and invoiced in 2014.  And than we have to summarise the balance of it and make one journal entry.  And change the allocation of invoices to that newly created journal entry to take effect. Let's say if you have 50 invoices in 2014 and paid in 2015. All these invoices needs to be removed and created one journal entry with all its balance.  After that we have to reallocate the payments against that journal entry.  Like this. We can remove all the other entries like stock balance in stock moves,

You have to remove related entries in
audit trail
Bank trans
Comments,
Cust allocations
Debtor trans
Debtor trans details
Gl trans
Journal
Grn_items, batch
Purch_orders
Purch_order_details
Sales orders
Sales orders details
Stock moves
Supp trans
Supp trans details
Trans tax details
Wo orders,

And other tables if anything affecting the yearly data. 
May be If you see tother

The existing delete fiscal year function already handles to delete in other entries. And you don't need to study much of it. But you have to study something to create journal entry for opening balance in sales and purchase.  Before deleting it on customer invoice and supplier invoice.  We have to make this function to create opening balance. And than you can allow it to delete the entries. I can understand it would take more time to delete it. Probably . You can wrote a cron job to run it for every 10mins and in a certain length of invoices and data. The system won't freeze or fail to remove. You can run it in free time like your night time or in holidays. So you can achieve it in less time and you don't need to worry about timeouts. There you have more data. So you have to write a separate function and call it inside FA. Or call it inside cron job. That will do the process.

One more thing to do. The allocation of old entries will be deleted so i have to make new allocation for opening balance and unallocated payments.

Yes you're right. Thanks for the idea
I'll inform you when finished.

This is a difficult task. I remember writing these routines years back and we really tried to get it all at that time.
I will try to look into it asap.

Joe

How ever there is a problem with payment of next year for previous year invoice.

Let's take his example. He issued several invoices  at the end of last year and collected the payment in next year.  Which means the system needs to make one journal entry for a customer at least to record the invoice balances as opening balance and that should be allocated in the next year.

The allocations has been revised and should now work. Committed to stable repo. The fixed file can be downloaded here.

Joe

@joe, your solution is good. Instead of rewriting it as journal entry. We keep the invoices alive and it's allocations alive. So it will be removed if they remove next fiscal year. 

@madosk, This is definitely a time saving way for you to implement it.  Hope your problem fixed with this. And post an reply after using this updated program. It would be a solved solution for future referring users.

I have compatibility problem. I 'm using 2.3.26 but commited file compatible with 2.4.x.
2.3.26 neither has add_journal method nor 0_journal table.
I removed this part of code and tried to delete year but unfortunately customer balance calculated wrong.
I'm investigating why balance is wrong. I'll inform you more if i find something.

Looks like this is a strange issue. I feel the below code is missing the cust allocation.

  while ($row = db_fetch($result))
    {
        if ($row['type'] == ST_SALESINVOICE)
        {
            $deliveries = get_sales_parent_numbers($row['type'], $row['trans_no']);
            foreach ($deliveries as $delivery)
            {
                $sql = "DELETE FROM ".TB_PREF."debtor_trans_details WHERE debtor_trans_no = $delivery AND debtor_trans_type = ".ST_CUSTDELIVERY;
                db_query($sql, "Could not delete debtor trans details");
                $sql = "DELETE FROM ".TB_PREF."debtor_trans WHERE trans_no = $delivery AND type = ".ST_CUSTDELIVERY;
                db_query($sql, "Could not delete debtor trans");
                delete_attachments_and_comments(ST_CUSTDELIVERY, $delivery);
            }        
        }    
        $sql = "DELETE FROM ".TB_PREF."cust_allocations WHERE trans_no_from = {$row['trans_no']} AND trans_type_from = {$row['type']}";
        db_query($sql, "Could not delete cust allocations");
.
.
.
}

And may be it should be like this

while ($row = db_fetch($result))
    {
        if ($row['type'] == ST_SALESINVOICE)
        {
            $deliveries = get_sales_parent_numbers($row['type'], $row['trans_no']);
            foreach ($deliveries as $delivery)
            {
                $sql = "DELETE FROM ".TB_PREF."debtor_trans_details WHERE debtor_trans_no = $delivery AND debtor_trans_type = ".ST_CUSTDELIVERY;
                db_query($sql, "Could not delete debtor trans details");
                $sql = "DELETE FROM ".TB_PREF."debtor_trans WHERE trans_no = $delivery AND type = ".ST_CUSTDELIVERY;
                db_query($sql, "Could not delete debtor trans");
                delete_attachments_and_comments(ST_CUSTDELIVERY, $delivery);
            }        
                      $sql = "DELETE FROM ".TB_PREF."cust_allocations WHERE trans_no_to = {$row['trans_no']} AND trans_type_to = {$row['type']}";  // newly added 
        db_query($sql, "Could not delete cust allocations");  // newly added. 
        }    
        $sql = "DELETE FROM ".TB_PREF."cust_allocations WHERE trans_no_from = {$row['trans_no']} AND trans_type_from = {$row['type']}";
        db_query($sql, "Could not delete cust allocations");
}

I have added two more lines added newly to collect the respective invoice allocation entires delete. Like the same for supplier allocations.

If it helps feedback us to fix it in core.