Tax Inquiry - Does not show output tax info (Page 4 of 5)

@boxygen

Thanks for setting up the testing for this.

The bug arises only when adding g/l tax accounts to a supplier invoice, otherwise all seems to work correctly.   Then the totals do not match and the tax report shows a double entry.   I reproduced this on your testsite with supplier invoice reference "abcde".

#4 is a separate issue and results in different totals, because as I recall, the inquiry adds the journal amount to both input and output and the report adds it just once.

Hello guys,

Adding config.php option for including Bank transactions is good idea (please, set it off by default). Probably due to time constraints suffering me recently I was not fortunate enough to reproduce the other problems, but I believe you they really exists. Please allow me only make final review on the code you are working on, then I will push proposed changes to the code repo. Thank you all for the time spent on this bugfix.

Janusz

My vote is to add a yes/no option to the tax report and a checkbox to the inquiry where the default is not checked.   Most people do not think to look at configuration or preferences or do not have access.  Or they might need to prepare the report both ways from time to time.

Hello Guys,

I would say that this is rather region specific so I suggest following a global setting like the one selected by Janusz.
We simply put the setting in config.php. That is my opinion.

Joe

config.php would be useful if one FA instance is used for one Company only. Since FA has the power to operate multiple companies with one instance, putting in config.php will contradict with each other may be.

Number 3 is also important, since the Bank Account is technically a supplier of service to you, and you pay VAT on Bank transaction Costs, Aditional serves, and Bank Account fees and any other fees that the bank would charge. These services carry service Input Tax that needs to be part of the claim back against your invoice, Supplier and Customer Credit Notes VAT payble.

Part of payments through the bank account might be cash transaction with till slips wher some amounts are VAT claimable. These are normally done through the Cash Payment or Petty Cash Paymnts, since you are not setting up a supplier account for every shop where you are going to buy stuff for the business, but they do issue a Cash Till VAT Receipt (Invoice).

Must I now setup the Bank as a supplier, Issue Supplier Invoices for each line item that is Vatable on the bank statement, and then make a supplier payment. This is tons of extra work that is not neeeded.

When you write Customer payments off as bad debt, you cannot use the Customer Credit Note so that you can claim back the VAT. I created a Bad Debt recon Account as a "Bank Account" so that the process against a Customer with bad debt is easier, but under 2.4 that did not pull through to the Tax report.

If in other areas they d not use GL accounts or Banking and General Journa to write back VAT, then they will have no such line transaction. It should only display where youve the folliwng:

Bank Cost: $2.00
Vat:  $0.20

Then this transaction will be displayed in the tax report as INPUT VAT. this is not happening with the current 2.4 reports, but was displaying in the 2.3 report709. So something clearly changed between 2.4 and 2.3 report709.

@Braath changes did address this issue in report709.

I did not specifically noticed the problem in the beginnig but had to resubmit the bank cost and cash payments in the Petty Cash after noticing the issue.

Trust this will help.

W

I made a pull request on github FrontAccountingERP:master with my original code changes plus the addition of a company preferences option.

The pull request requires an addition to the sys_prefs table and there is no built-in 2.4 minor release upgrade.   You will need to login to the mysql client and make the addition manually.

INSERT INTO `0_sys_prefs` VALUES ('tax_bank_payments','setup.company', 'tinyint', 1, '0');

Good evening gents,

I kind of stepped out of the conversation as it got me completely bamboozled.
Looks to me that my CoA was not the (only) problem. But I'm pretty lost where we are now. Can I update again from v3x to v4x and safely carry on with my bookkeeping?

Following @rafat's suggestion in this thread https://frontaccounting.com/punbb/viewtopic.php?id=6975 I worked through this thread to try an resolve the issue by implementing the pull request from @BraathWaate but could not get it to work (ended up with a blank screen when trying to logon so I reverted to the old files).

I ended up only keeping the tax report (rep709) that seems mostly fine for my reporting requirements, except for:
- The absence of the bank payments/deposits to the gl tax accounts (as discussed in this thread)
- And a bug I think, because whereas the report does show the supplier invoice credit note item, it is not taking the value into account when calculating the report totals.

Thanks for all your hard work, but I must say it seems like the update to 2.4 caused a lot of issues in the tax reporting that need to be fixed. Is there any more progress on this?

@rafat thanks for the suggestion; if I have a chance I'll have another crack at it.

As for the supplier invoice credit note, I have modified line #162 in rep709 from @BraathWaate (I added "ST_SUPPCREDIT,") which seems to have done the trick as my report is now looking good and matches my .xls , but I haven't done extensive testing.

If anybody would like to test it, the line now reads:

        } elseif ($trans['reg_type'] !== NULL || in_array($trans['trans_type'], array(ST_SUPPINVOICE, ST_SUPPCREDIT, ST_BANKPAYMENT))) {