Tax Inquiry - Does not show output tax info (Page 3 of 5)

@rafat

Sorry, the memo is in the tax table and not the ref# for bank payments, although with some more sql it may be possible to retrieve it.

Note that for suppliers the report prints the supplier reference number, usually the supplier check number.   But FA lacks bank check numbers, so if one enters the bank check number into the memo field, then it appears on the report, which is actually what we do.

Here is the blank name fix:
rep_709.php.

@rafat

Double check if your rep_709.php has the code change:

+++ b/core/reporting/rep709.php
@@ -35,9 +35,10 @@ function getTaxTransactions($from, $to)
 
        $sql = "SELECT tt.name as taxname, taxrec.*, taxrec.amount*ex_rate AS amount,
                    taxrec.net_amount*ex_rate AS net_amount,
-                               IF(taxrec.trans_type=".ST_BANKPAYMENT." OR taxrec.trans_type=".ST_BANKDEPOSIT.", 
-                                       IF(gl.person_type_id<>".PT_MISC.", gl.memo_, gl.person_id), 
-                                       IF(ISNULL(supp.supp_name), debt.name, supp.supp_name)) as name,
+                IF(ISNULL(supp.supp_name),
+                    IF(ISNULL(debt.name),
+                        IF(gl.person_type_id<>".PT_MISC.", gl.memo_, gl.person_id), debt.name),
+                        supp.supp_name) as name,
                                branch.br_name
                FROM ".TB_PREF."trans_tax_details taxrec
                LEFT JOIN ".TB_PREF."tax_types tt

With the new code, if the transaction (including bank payments and deposits) has a supplier name or customer name, it will be used.  Then if it has a miscellaneous name, it will be used.  Finally, it would use the memo.

So I think the name field must be non-blank, unless the payment was a quickentry and the memo was blank.

@Braath Waate,

Are you suggesting a correction in the core? I have some problems following this thread.

Please be a little more specific if I should change something in the core. Thanks in advance.

/Joe

Yes we need more time to test this..
The name field to me is important but more important are the transactions and the totals..
After Braath fork  they are 100% correct. I compare them to the manual spreadsheet I have, as well as the report I have from FA. I am a happy lad.
FA core is very correct in Tax reports that are only based on customer/supplier invoices... after the correction that Braath's  done to supplier invoices thru gl entry..this needs to be accounted for in the core of course.

@rafat

The tax report fails to show miscellaneous names because they are missing from the gl_trans table.  The gl_trans table neglects to store the person_id for miscellaneous names because the function add_gl_trans in gl_db_trans.inc calls this code:

    if (!is_subledger_account($account) || $account==get_company_pref('grn_clearing_act'))
        $person_id = $person_type_id = null;

The function is_subledger_account returns true only for customer or supplier names, so clears the name for miscellaneous names.

I have run into this before and do not understand why it does this, but the names can be retrieved with an additional sql step.  So this is a bug that I suspect you may see on other reports as well.

I updated the rep_709.php with this change.

@Seahawk
Are you able to test the above and see if all OK?  I am asking this because the 2.3.25 report is full of bugs if you are still using it..it has double entries and is somehow accounting for void entries when I test it. The above is working ok for me. It makes sense if you test it so we can have another user environment experience.

Sorry Lads, been out of action for a while and forgot to subscribe to the topic. I will test now and report back, Just made a new installation with 2.4.6

Regards

@seahawk

Were you testing the 2.4.6 tax report or my version?

If you were using my version, and the report showed a bank payment or journal with the bottom memo, was the person a quick entry or a supplier, customer, or miscellaneous name?

It looks good I like it.. and its correct.
Last request please can Journal Entries be included in the Inquiry..it is shown in the report but not accounted for the Inquiry.
Thanks again.

@rafat
@itronics

I think the reason why tax inquiry and the tax report are not working in 2.4 is because of the changes introduced by adding reg_type to the trans_tax_details table.  This commit added the reg_type and changed how these pages work.  As I said earlier in this thread, it would be nice if reg_type was not NULL in several cases which perhaps has defeated the reason why reg_type was added to 2.4.   Here is the latest gl/includes/db/gl_db_trans.inc which seems to fix the tax inquiry page for journal entries by removing more code that was deliberately introduced in 2.4 and which I do not understand.

@Braath Waate

I'm not sure I understand the problem right, but the change in gl_db_trans.inc effectively excludes from tax summary all journal entries which user explicitly included into input tax register, which is not acceptable. Instead the change proposed includes bank payments and deposits, transactions which are not taxable per se, at least in EU tax system.

I understand that tax rules may differ in other jurisdictions, so I would like to include a fix solving problems you have encountered. But to avoid any misunderstanding, it is much better to maintain more complex issues like this via our Mantis bugtracker. Mantis really helps in bugfixing process, encouraging clear problem description. Please put the issue on bugtracker together with some short step by step description how to reproduce the issue. You can also attach proposed code change for completness (I'm not sure all the changes are in gl_db_trans.inc).

Janusz

I have gone through the whole thread today. Unfortunately none of my Sites are using Purchase Taxes so I never hear of any bug from my clients. I will try to test it myself and shall revert.