• From: India, TN, Karur
  • Registered: 05/16/2014
  • Posts: 1,195

Topic: A function line misplaced

From this commit

The function was misplaced. It was like this now.

https://github.com/kvcodes/FA/commit/42751ff1e05ac803548a07d412f4a173cd0e0450 

if ($order->fixed_asset)
            stock_disposable_fa_list_cells(null,'stock_id', null, _('[Select item]'), true, $order->line_items);
        else
        if (list_updated('stock_id')) {
                            sales_items_list_cells(null,'stock_id', null, false, true, true);

And it should be like this.

if ($order->fixed_asset)
            stock_disposable_fa_list_cells(null,'stock_id', null, _('[Select item]'), true, $order->line_items);
        else
            sales_items_list_cells(null,'stock_id', null, false, true, true);
        if (list_updated('stock_id')) {
Subscription service based on FA
HRM CRM POS batch Themes

kvvaradha's Website

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,160

Re: A function line misplaced

@joe: the whole commit can be reviewed instead of the fixed part alone.

apmuthu's Website

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,160

Re: A function line misplaced

Looks like a rollback of this commit is in order if no new workaround is found.

apmuthu's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,107

Re: A function line misplaced

This item has been rolled back due to new bugs in the fixed solution.

Committed with whitespace fixes.

/Joe