Editable Item Description's Input is TextBox. How to Enable TextArea

boxygen · 07/12/2018 12:40:35 pm

boxygen
Senior Member
Offline

From: Pakistan, Karachi
Registered: 03/03/2015
Posts: 650

Topic: Editable Item Description's Input is TextBox. How to Enable TextArea

The following function returns a TextBox to Edit Item Description if Item is Editable. Some Item Descriptions needs to be multi lines. How can this function returns TextArea for Editable Items.

function sales_items_list_cells($label, $name, $selected_id=null, $all_option=false, $submit_on_change=false, $editkey=false)
{
    if ($editkey)
        set_editor('item', $name, $editkey);

    if ($label != null)
        echo "<td>$label</td>\n";
    echo sales_items_list($name, $selected_id, $all_option, $submit_on_change,
        '', array('cells'=>true));
}

www.boxygen.pk

cristiart · 07/12/2018 04:44:24 pm

cristiart
Senior Member
Offline

From: USA
Registered: 03/26/2013
Posts: 93

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

this should be a great feature, resizable textarea instead of textbox. I think this post should move to Wish List...

kvvaradha · 07/13/2018 02:06:18 am

kvvaradha
Senior Member
Offline

From: India, TN, Karur
Registered: 05/16/2014
Posts: 1,181

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

Open ui_list.inc and goto line number 259 around and find the below code.

."<input type='text' $disabled name='{$name}_text' id='{$name}_text' size='".
                $opts['editable']."' maxlength='".$opts['max']."' $rel value='$edit'>\n";

and replace with below one.

."<textarea $disabled name='{$name}_text' id='{$name}_text' cols='35' rows='5"    .($name ? " title='$name'" : '')    .">$edit</textarea>\n";

this is code helps you to change it multi-line input(TextArea). But it wont save them like multi lines. There are few other files needs to be edited to allow it to process multi line inputs

Subscription service based on FA
HRM CRM POS batch Themes

apmuthu · 07/13/2018 05:59:56 am

apmuthu
Moderator
Offline

From: Singapore, India, Chennai
Registered: 05/02/2009
Posts: 6,089

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

@joe: a nice functionality but may affect a lot more tables fields / scripts.

boxygen · 07/13/2018 07:07:11 am

boxygen
Senior Member
Offline

From: Pakistan, Karachi
Registered: 03/03/2015
Posts: 650

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

I have tested the recommended code of @kvvaradha. It is working fine and data is correctly displayed even in reports. The only problem mentioned in this screen short

The TextArea is encompassing the second column

Post's attachments

Sales_Mod_Overlap.png 161.7 kb, file has never been downloaded.

You don't have the permssions to download the attachments of this post.

www.boxygen.pk

boxygen · 07/13/2018 07:30:49 am

boxygen
Senior Member
Offline

From: Pakistan, Karachi
Registered: 03/03/2015
Posts: 650

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

I have set the cols='35' and rows='3' and now its OK for me

www.boxygen.pk

apmuthu · 07/13/2018 07:31:23 am

apmuthu
Moderator
Offline

From: Singapore, India, Chennai
Registered: 05/02/2009
Posts: 6,089

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

A screenshot using the standard default theme (and not the dashboard/canvas) theme would be better for design purposes.

kvvaradha · 07/13/2018 12:49:48 pm

kvvaradha
Senior Member
Offline

From: India, TN, Karur
Registered: 05/16/2014
Posts: 1,181

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

@boxygen , I gave it as simple and stand to replace the textbox with textarea. But it requires to save the multi lines as like it inputted. For that, we need to change some more to take effect. Also it may possible to add a option to change it either textbox or textarea

Subscription service based on FA
HRM CRM POS batch Themes

poncho1234 · 07/13/2018 02:32:53 pm

poncho1234
Senior Member
Offline

From: Colombia
Registered: 12/29/2014
Posts: 627

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

I like this too
Notes:-

Editable desc is stored in sales_order_details & debtor_trans_details which are both tinytext so 255 char max
@apmuthu it should only affect combo_input fields which are editable.
When selecting an editable desc item in purchases the textarea is only visible after selecting quantity or price - Is anyone else getting this?

The FrontAccounting Wiki(Manual, examples, tips, setup info, links to accounting sites, etc) https://frontaccounting.com/fawiki/

boxygen · 08/19/2018 03:57:24 am

boxygen
Senior Member
Offline

From: Pakistan, Karachi
Registered: 03/03/2015
Posts: 650

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

I can see this commit by @joe for Item Editable Description. I have applied this but I couldn't find any change in Behaviour of Editable Item Description. Any Idea how shall I expect the change?

www.boxygen.pk

apmuthu · 08/19/2018 04:37:22 am

apmuthu
Moderator
Offline

From: Singapore, India, Chennai
Registered: 05/02/2009
Posts: 6,089

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

Try clearing the js and other browser cache and try it.

kvvaradha · 08/20/2018 04:27:42 am

kvvaradha
Senior Member
Offline

From: India, TN, Karur
Registered: 05/16/2014
Posts: 1,181

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

@boxygen - The commit code was adjusted by myself. it was discussed here. I hope you understand, when you check this thread.

Subscription service based on FA
HRM CRM POS batch Themes

boxygen · 08/20/2018 05:59:11 pm

boxygen
Senior Member
Offline

From: Pakistan, Karachi
Registered: 03/03/2015
Posts: 650

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

@kvvaradha, thanks got it.

www.boxygen.pk

cristiart · 10/30/2019 02:56:15 am

cristiart
Senior Member
Offline

From: USA
Registered: 03/26/2013
Posts: 93

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

boxygen wrote:

I can see this commit by @joe for Item Editable Description. I have applied this but I couldn't find any change in Behaviour of Editable Item Description. Any Idea how shall I expect the change?

to view in pages and PDF add -nl2br- in -> sales\includes\ui\sales_order_ui.inc -> around line 183

label_cell($stock_item->item_description);

to

label_cell(nl2br($stock_item->item_description) );

you also want to replace in sales\includes\ui\sales_order_ui.inc around line 492

text_cells(null,'item_description', null, 45, 150);

to

textarea_cells(null, 'item_description', null, '45' , 5, $title = null);

Editable Item Description's Input is TextBox. How to Enable TextArea

Posts: 14

1 Topic by boxygen 07/12/2018 12:40:35 pm

Topic: Editable Item Description's Input is TextBox. How to Enable TextArea

2 Reply by cristiart 07/12/2018 04:44:24 pm

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

3 Reply by kvvaradha 07/13/2018 02:06:18 am

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

4 Reply by apmuthu 07/13/2018 05:59:56 am

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

5 Reply by boxygen 07/13/2018 07:07:11 am (edited by boxygen 07/13/2018 07:07:52 am)

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

6 Reply by boxygen 07/13/2018 07:30:49 am

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

7 Reply by apmuthu 07/13/2018 07:31:23 am

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

8 Reply by kvvaradha 07/13/2018 12:49:48 pm

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

9 Reply by poncho1234 07/13/2018 02:32:53 pm (edited by poncho1234 07/13/2018 02:34:45 pm)

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

10 Reply by boxygen 08/19/2018 03:57:24 am

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

11 Reply by apmuthu 08/19/2018 04:37:22 am

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

12 Reply by kvvaradha 08/20/2018 04:27:42 am

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

13 Reply by boxygen 08/20/2018 05:59:11 pm

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

14 Reply by cristiart 10/30/2019 02:56:15 am (edited by cristiart 10/31/2019 05:22:02 am)

Re: Editable Item Description's Input is TextBox. How to Enable TextArea

Posts: 14