1 (edited by boxygen 08/13/2018 08:19:39 am)

Topic: A bug in Report Supplier Balances rep201.php

I found a bug in Supplier Balances Report.

Check this screen shot of comparison. Opening Balance of the SUpplier was recorded on 30th June. When we query including 30th June the report shows value correctly under Charges Column But When we query from 1st July the Reports Shows the opening balance wrongly under Credits Column.

The reason is that the Opening Balance was entered through Journal Entry. and Journal Entry is not being checked in the get_open_balance() function in rep201.php.

Post's attachments

BugInSupplierBalances.png 75.1 kb, file has never been downloaded. 

You don't have the permssions to download the attachments of this post.
www.boxygen.pk

Re: A bug in Report Supplier Balances rep201.php

I copied the Logic from rep101.php and it worked.

function get_open_balance($supplier_id, $to)
{
    if($to)
        $to = date2sql($to);

        $sql = "SELECT SUM(IF(t.type = ".ST_SUPPINVOICE." OR (t.type IN (".ST_JOURNAL." , ".ST_BANKDEPOSIT.") AND t.ov_amount>0),
                        -abs(t.ov_amount + t.ov_gst + t.ov_discount), 0)) AS charges,";

 $sql .= "SUM(IF(t.type != ".ST_SUPPINVOICE." AND NOT(t.type IN (".ST_JOURNAL." , ".ST_BANKDEPOSIT.") AND t.ov_amount>0),
                        abs(t.ov_amount + t.ov_gst + t.ov_discount) * -1, 0)) AS credits,";

     $sql .= "SUM(IF(t.type != ".ST_SUPPINVOICE." AND NOT(t.type IN (".ST_JOURNAL." , ".ST_BANKDEPOSIT.")), t.alloc * -1, t.alloc)) AS Allocated,";

     $sql .=    "SUM(IF(t.type = ".ST_SUPPINVOICE.", 1, -1) *
             (abs(t.ov_amount + t.ov_gst + t.ov_discount) - abs(t.alloc))) AS OutStanding
        FROM ".TB_PREF."supp_trans t
        WHERE t.supplier_id = ".db_escape($supplier_id);
    if ($to)
        $sql .= " AND t.tran_date < '$to'";
    $sql .= " GROUP BY supplier_id";

    $result = db_query($sql,"No transactions were returned");
    return db_fetch($result);
}
Post's attachments

BugInSupplierBalances_Cmp.png 130.4 kb, file has never been downloaded. 

You don't have the permssions to download the attachments of this post.
www.boxygen.pk

Re: A bug in Report Supplier Balances rep201.php

@boxygen

I am out of office until Friday. Will fix it then and commit. Thanks.

Joe

Re: A bug in Report Supplier Balances rep201.php

Committed.
Kindly verify if the functionality is okay.

Re: A bug in Report Supplier Balances rep201.php

Yes, I can verify

www.boxygen.pk