Not working: Automatic Increase of reference number fields in FA 2.4.2 (Page 3 of 3)

For Bank Account Transfers, the solution is similar to the others: we update the ref before the check_reference() runs. The file to edit is gl/bank_transfer.php

    /////////////// update ref 
    $_POST['ref'] = $Refs->get_next(ST_BANKTRANSFER, null, $_POST['DatePaid']);
    if (!check_reference($_POST['ref'], ST_BANKTRANSFER, $trans_no)) {
        set_focus('ref');
        return false;
    }

@davidkumi, @itronics, @joe, @apmuthu

I have a suggestion and I have tested it with many transactions (not all) and it is working

Modify the function check_reference() with following single line change

function check_reference($reference, $trans_type, $trans_no=0, $context=null, $line=null)
{
    global $Refs;

    if (!$Refs->is_valid($reference, $trans_type, $context, $line))
    {
        display_error(_("The entered reference is invalid.")); return false;
    }
    elseif (!$Refs->is_new_reference($reference, $trans_type, $trans_no))
    {
        $_POST['ref'] = $Refs->get_next($trans_type, null, $context); //modified by faisal
        // display_error( _("The entered reference is already in use.")); return false;
    }
    return true;
}

Before applying to my main server I request you all to please authenticate it. I don't know if it conflicts with some other behaviour of FA

Also we need to add following lines in copy_to_cart () function in sales_order_entry.php page

function copy_to_cart()
{
    check_reference($_POST['ref'], $_SESSION['Items']->trans_type, $_SESSION['Items']->trans_no); //added by faisal

@joe and @apmuthu,

It is necessary in two scenarios

1. You have more than one data entry operators who are recording bank transactions at the same time. Both have same Next Reference say BP115 on their forms. The person who will commit transaction lately will see the error Transaction Reference Already in Use

2. Even if we have only one Data Entry operator but it happens many times that the next reference stucks and don't increase itself. Then one needs to manually go to Transaction References Page and increase it.

This is my point of view.

The effect of the return -1; above should be tested under various PHP dispensations - is it an error or is it a graceful change to a new_reference, the calling entity should know and act accordingly.

It would be nice to refresh the Extensions repo with the latest changes as in the FA24extensions repo. Tamil / Hindi translations are yet to be refreshed.

@joe - this would be great piece of code to fix  it for existing programs, i mean older version of FA.

The solution with automatic increment of references  only works with documents.

Joe