1 Topic by boxygen (edited by boxygen 12/31/2017 05:18:23 am)

  • From: Pakistan, Karachi
  • Registered: 03/03/2015
  • Posts: 654

Topic: Bug in Backups

@itronics, I think yours commit has created this bug in uploading a .sql backup file

Regards

Post's attachments

BackupRestoreBug.png 146 kb, 1 downloads since 2017-12-31 

You don't have the permssions to download the attachments of this post.
www.boxygen.pk

boxygen's Website

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,160

Re: Bug in Backups

Since you have pressed the upload button without selecting any flie to upload, the error arises. Hence change line 169 in admin/backups.php:

if (get_post('upload'))

to be:

if (get_post('upload') && isset($_FILES['uploadfile']) && array_key_exists('tmp_name', $_FILES['uploadfile']))

apmuthu's Website

  • From: Pakistan, Karachi
  • Registered: 03/03/2015
  • Posts: 654

Re: Bug in Backups

No you are wrong, I am pressing upload button while selecting a .sql file to upload.

If I apply your suggestion, It only avoid error shown in post#1 but the file is still not uploaded.

You have to review the commit mentioned in post#1, Better give it a try to upload a .sql file to understand the bug.

www.boxygen.pk

boxygen's Website

  • Alaa
  • Alaa
  • Senior Member
  • Offline
  • From: Jordan
  • Registered: 03/27/2015
  • Posts: 156

Re: Bug in Backups

yes, you can't restore a backup right now there is an error when trying to upload the backup file.
to restore my backup i had to upload it using ftp then i could restore.

so the bug shows up when trying to upload your backup file.

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,160

Re: Bug in Backups

Yes, there is no file uploaded since the $_FILES is empty on upload. The $_REQUEST is like:

Array
(
    [comments] => 
    [comp] => no
    [protect] => 1
    [uploadfile] => frontac24_1_1_20171206_1551.sql
    [upload] => Upload file
    [_focus] => comments
    [_modified] => 0
    [_confirmed] => 
    [_token] => pZNU0jkQsPSi05HaQyLGAQxx
    [FA9d3e45269bea7dab23238a920d251e93] => 33ebcyesul0lgdnms17d8nna35
)

The $_POST array does not have the last element above.

The fix is to make the start_form a multipart one - it was inadvertently changed during the last commit to this file.
Change line 190 in admin/backups.php

start_form(false, true);

to be:

start_form(true, true);

apmuthu's Website

  • From: Pakistan, Karachi
  • Registered: 03/03/2015
  • Posts: 654

Re: Bug in Backups

thanks

www.boxygen.pk

boxygen's Website

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,160

Re: Bug in Backups

@joe / @ itronics: can commit this.

apmuthu's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,107

Re: Bug in Backups

Committed to stable repo.

Joe