1 Topic by boxygen (edited by boxygen 09/15/2017 11:39:50 am)

  • From: Pakistan, Karachi
  • Registered: 03/03/2015
  • Posts: 654

Topic: Bug in rep108

Now since Transactions to customers can be recorded through Journal Entry also and It can be either Debit Or Credit to customer.

The following code is not sufficient to handle the transactions through Journal Entry

if ($myrow2['type'] == ST_SALESINVOICE || $myrow2['type'] == ST_BANKPAYMENT)
                $rep->TextCol(4, 5,    $DisplayTotal, -2);
            else
                $rep->TextCol(5, 6,    $DisplayTotal, -2);

Secondly one more thing is that If we Debit the Customer through JE then it appears in the ov_amount column in debtor_trans table as -ve value while if we credit the customer through JE the value appears as +ve value.

Except from the JE all values from any other transaction whether charges or credits appear as +ve value.

rep101 is also affected through JE Transactions. Debit is appearing on Credit Side and Credit is appearing on Debit Side.

www.boxygen.pk

boxygen's Website

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,160

Re: Bug in rep108

@joe: any separate code for JE?

apmuthu's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,107

Re: Bug in rep108

Will have a look at this.

Joe

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,107

Re: Bug in rep108

@boxygen

I have now testet the Journal Entries on the Account Receivable, and I see no errors.
Depending on how the JE are entered it will mirror correctly in the Accounts Receivable.
If you still think there is an error, then please give me the booked JE, so I can try to reproduce this.

/Joe

  • From: Pakistan, Karachi
  • Registered: 03/03/2015
  • Posts: 654

Re: Bug in rep108

@Joe

Please check some screen shots below

Customer Balances Before JE Transaction

JE Transaction

Customer Balances after JE

You will find that the JE Transaction is appearing on the Credit Side Not on Debit Side because in Code no proper condition defined to handle Customer Debit Or Credit Transactions through JE.

This Problem is also in rep108.

I guess not yet checked that Suppliers Balances must be affecting due to same logical bug.

Hope this helps to understand.

You can login here to check further

fa.boxygen.biz/fa24

id: demo
pass: password

Thanks

www.boxygen.pk

boxygen's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,107

Re: Bug in rep108

@boxygen

Now I see the error. Why didn't I do that before sad

On the customer side the AR was updated with a minus amount. Changed to a positive amount and it seems to work.

The repo has been updated. You can download the corrected file here.

/Joe

Post's attachments

items_cart.inc 15.9 kb, file has never been downloaded. 

You don't have the permssions to download the attachments of this post.
  • From: Pakistan, Karachi
  • Registered: 03/03/2015
  • Posts: 654

Re: Bug in rep108

Thanks @Joe. But I think your solution has worked for rep101 but not for rep108.

I recorded one AR and AP for a customer through JE. Compare images below

rep101

rep108

There is some problem in Aged Customer Analysis also have a look

Aged Customer Analysis

Similarly we need to screen out the affects in Supplier Balances and Supplier Aged Analysis and If any other area, inquiry or report being affected by JE Transactions for Customers and Suppliers.

Regards

Post's attachments

rep108_issue.zip 53.6 kb, file has never been downloaded. 

You don't have the permssions to download the attachments of this post.
www.boxygen.pk

boxygen's Website

  • From: Pakistan, Karachi
  • Registered: 03/03/2015
  • Posts: 654

Re: Bug in rep108

Hello @Joe, were you able to check it further the problem in rep108 as mentioned above.

www.boxygen.pk

boxygen's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,107

Re: Bug in rep108

I will try as soon as possible. This week has been rather busy.

Joe

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,107

Re: Bug in rep108

This has now been fixed. At least I hope.

This was quite complicated to fix, due to special handling before we had the option to enter direct to AR/AP accounts in Journal Entry.

The files can be downloaded from the Git Repo:

rep108.php

customers_db.inc

Joe

  • From: Pakistan, Karachi
  • Registered: 03/03/2015
  • Posts: 654

Re: Bug in rep108

Thanks @Joe I have tested and I think its fixed now.

www.boxygen.pk

boxygen's Website