Two bugs in backup module

Hi joe
Ad 1. Diff folows.

Ad 2. Nope. Report generator stores all reports (for all users and all companies) in one MySQL table xx_reports. This is not good solution, because all users has access to all other company data via 'Test the SQL statement' button. This is serious security issue.

On the other way if backup system is available for Admins only this implies backing up whole database, not only for one company. In one database can coexist table sets with 0_, 1_ etc prefixes and with no prefix at all. So why the code changes only tables with prefix 0_, but the others are backed up with table names leaved intact?

So is the diff:

--- /var/www/frontaccounting/admin/db/maintenance_db.inc    2007-10-01 10:13:28.000000000 +0200
+++ /var/www/fa/admin/db/maintenance_db.inc    2007-12-27 21:36:05.000000000 +0100
@@ -125,8 +125,8 @@
    {
        $line = trim($line);

-        $line = str_replace("0_", $connection["tbpref"], $line);
-        $line = str_replace("Y_", "0_", $line);
+//        $line = str_replace("0_", $connection["tbpref"], $line);
+//        $line = str_replace("Y_", "0_", $line);
        // the last line did not belong to a 'create' sql query
        if (!$table)
        {
@@ -397,7 +397,7 @@
                    for ($k = 0; $k < $nf = db_num_fields($res2); $k++)
                    {
                        // identify null values and save them as null instead of ''
-                        if ($field_type[$k] != "" && $row2[$k] == "")
+                        if ($field_type[$k] != "" && $field_type[$k] != "NO" && $row2[$k] == "")
                            $out .= "NULL";
                        else
                            $out .= "'" . db_escape($row2[$k]) . "'";

Hello  joe
May be my previous post was not clear, but sorry - english is not my native language. I'll try again.

Yes, it is. This suggests backup of whole database in a manner which makes possible restoring all table sets for all companies from admin generated sql file. But:
1. db_import() function doesn't restore 0_ prefix.
2. what about such case:  you have in database 2 sets of tables for 2 companies with prefixes: 0_, 1_ . Assuming you are logged on admin account with '1_' prefix, after export you have sql backup file with  statements creating table sets with prefixes: '1_' and '1_' (once again). How will look your database after restoring from such backup file? Answer: as before restore operation, or worse - dataset '1_' will be updated with '0_'.

This is no problem. If you want to use backup module to make 'reference' sql files on development system - you can. Play with database with only one table set with prefix '0_', logging from its account. Then none prefix substitution is necessary.

I've answered in that thread.

Regards
janusz

Hi joe
I double checked the problem and found that you are partially right.
If the backup tool is used on account with any standard prefix or to install fresh new company from reference files (sql statements with prefix 0_)  all is correct.

But the problem exists. If you are logged on account with no prefix db_export() makes backup file for the whole database (all table sets). And here problems described in my earlier posts arise.

Below is new patch which remove this issue. One issue still exists, but must be changed in report generator module. database xx_reports is backed up only for user which has empty prefix.

Regards
janusz

--- /var/www/frontaccounting/admin/db/maintenance_db.inc    2007-10-01 10:13:28.000000000 +0200
+++ /var/www/fa/admin/db/maintenance_db.inc    2007-12-30 13:20:45.000000000 +0100
@@ -126,7 +126,6 @@
        $line = trim($line);

        $line = str_replace("0_", $connection["tbpref"], $line);
-        $line = str_replace("Y_", "0_", $line);
        // the last line did not belong to a 'create' sql query
        if (!$table)
        {
@@ -321,7 +320,8 @@
     $all_tables = array();
     while($row = db_fetch($res))
     {
-        if ($conn["tbpref"] == "" || strpos($row['Name'], $conn["tbpref"]) !== false)
+        if (($conn["tbpref"] == '' && !preg_match('/[0-9]+_/', $row['Name']))
+         || ($conn["tbpref"] != '' && strpos($row['Name'], $conn["tbpref"]) !== false))
             $all_tables[] = $row;
     }

I am sure I have the case related to described in this tread - I made a backup of 0_ company (version 1.12 build 31) and now can not restore it. The database is getting corrupt as result of the restore.

I have setup v. 2.0 (beta build 22) but the issue remains - can't restore the backup.

Is there anything I can do about it? I have damn lots of transactions made, so will hate the idea of manual re-work.

Please help!

regarsd,
Alexey

hi Joe,

Thank you for the response - i had problems restoring the company still having version 1.12. Somebody told me that script file is inconsistent (data is conflicting with table descriptions - specifically, having NULL values where "NOT NULL" is declaired).

Is there anything I can do with my backup file? Shall I install later version compatible with 1.12? Or shall I set up the 1.12 and try to import (again) the data there?

Thank you in advance!!