• From: New Zealand, Wellington
  • Registered: 06/19/2014
  • Posts: 128

Topic: Fix for bug in suppliers.php

Hi,

Here's a PR for a bug introduced in 99df2fbc2f147b3a1e20a4cdfa70c2720e67e4cb 27 May 2016

Just one extra comma in line 312 of purchasing/manage/suppliers.php

https://github.com/FrontAccountingERP/FA/pull/17

BTW, this was picked up by the E2E tests on Travis when I brought my unstable-cp branch up to date.  Any chance of having these integrated some time?  The Travis tests can be viewed here:

https://travis-ci.org/cambell-prince/frontaccounting/branches

Cambell https://github.com/cambell-prince

cambell's Website

2 Reply by apmuthu (edited by apmuthu 08/06/2016 01:40:34 am)

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Re: Fix for bug in suppliers.php

@joe: Please fix this in the official unstable repo - error known for around 18 hours.

apmuthu's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: Fix for bug in suppliers.php

Fixed and committed in unstable (2.4) repo.

/Joe

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Re: Fix for bug in suppliers.php

@joe: Thanks. Commit Link.

apmuthu's Website