Amount in words in Invoice (Page 1 of 2)

You can fix it in file includes/ui_view.inc about line 830 changing it to

    if (!($document == ST_SUPPAYMENT || $document == ST_CUSTPAYMENT 
                || $document == ST_CHEQUE || $document == ST_SALESINVOICE))

Janusz

Any reason why this has not made it to the HG repo?

The file is:
includes/ui/ui_view.inc and the line to be changed is line no. 793:

     if (!($document == ST_SUPPAYMENT || $document == ST_CUSTPAYMENT || $document == ST_CHEQUE))

to

     if (!($document == ST_SUPPAYMENT || $document == ST_CUSTPAYMENT || $document == ST_CHEQUE || $document == ST_SALESINVOICE))

It would be nice to have a setting to be able to select in which documents we would like to have it.

The default English language one is available at lang/new_language_template/locale.inc and will possibly be taken when no specific one a any chosen language is unavailable.

Copy the locale file to say lang/en_US/locale.inc and edit the first method's name:

class hooks_xx_XX extends hooks {

to

class hooks_en_US extends hooks {

Now check it out by choosing the specific language en_US as US English in FA.

First, does the language specific option work?
Second, the default language is "C" which must exist in your lang/installed_languages.inc like:

<?php

/* How to make new entries here for non-packaged languages:

-- 'code' should match the name of the directory for the language under \lang
.-- 'name' is the name that will be displayed in the language selection list (in Users and Display Setup)
-- 'rtl' only needs to be set for right-to-left languages like Arabic and Hebrew
-- 'encoding' used in translation file
-- 'version' always set to '' for manually installed languages.
-- 'path' installation path related to FA root (e.g. 'lang/en_US').
*/


$installed_languages = array (
  0 => 
  array (
    'code' => 'C',
    'name' => 'English',
    'encoding' => 'iso-8859-1',
  ),
);

$dflt_lang = 'C';
?>

Now we need to study the code as to where these routines in the said file are called and how the defaults get assumed.

The file locale.inc is "included" in the
1. function install_hooks() in the file includes/hooks.inc
2. function set_language($code) in the file includes/lang/language.php

Thanks for the perseverance and testing.

Linux calls it "C" perhaps for "common" or just "C" as in C Language..... where it all started.

@joe: try to make this as part of the codebase or as comments in the generated lang/languages_installed.inc file.

I don't know about 2.4.3 but first of all check whether it shows when you set user languge and system default language to English 'C' .
If it works - something is wrong with your locale amount in words.

You quoted a reply...
What did you do? You tried with the mentioned file from the repo or you changed the code in the file of your system?

If you tried with the mentioned file, it's still not changed to add words to invoices.
You have to find it and change the mentioned code. When reply was made apmuthu mentioned line 793 but it obviously was quoted before some other changes which increased the lines.
As of today it is at line 829.

@rafat: FA now uses Sourceforge's Git and is mirrored on GitHub.

If the price hook exists for your locale, then it would automatically come. Only otherwise will the rest of the function price_in_words be executed when the default for the Invoices is needed to be overridden by my mod.

A more elegant mod version for Line 865 would be:

if (!in_array($document, array(ST_SUPPAYMENT, ST_CUSTPAYMENT, ST_CHEQUE, ST_SALESINVOICE))

The function price_in_words() that finally gets invoked if present is available as a skeleton in lang/new_language_template/locale.inc.

@joe: any reason why the Invoice did not default to the words like the others?

What is the standard procedure to include it in the invoice? Must we edit it like here or in the repXXX file in any different way? Should it be some choice in the company setup as candidates for the sys_prefs table?

@rafat if I remember well there was some session or cache issue with this filtering - delayed change.
If it's still not working and for you amount in words is important, you can simply comment the line and it will be active for all documents.