PayPal import issues

I also noticed some errors in the error.log:

Hi Ap.Muthu,

I am running Import Paypal transactions version 2.3.10-3. FA is version 2.3.24.
I made the change you suggested but it did not make a difference. I think the code in sales/includes/db/payment_db.inc is correct.

I found one of the issues: in modules/import_paypal/import_paypal_update.php at line 117, the call to write_customer_payment does not match with the definition in sales/includes/db/payment_db.inc. There are 13 arguments in the call, the function definition has only 12:

I replaced the line with the following:

Seems to be working, I don't get the Both parameters should have an equal number of elements error any more but I still get the database error.
Similarly, the calls to write_bank_transaction in modules/import_paypal/import_paypal_update.php have fewer arguments than defined in the definition.

I will investigate further and report back.
Ion

The write_bank_transaction() having less arguments in a call than defined in the function is okay here as the rest have default values defined in the function as well in gl/includes/db/gl_db_banking.inc.

You might want to check out any file differences between those in your import_paypal module install and those in my unofficial Github repo.

The function write_customer_payment() is defined in sales/includes/db/payment_db.inc with 12 arguments with the last 3 being optional with defaults provided. Furthermore, if there are less than 12 arguments, the rest are filled with zeroes in line 29 in it:

$args = func_get_args(); while (count($args) < 12) $args[] = 0;

The said function is called with 13 arguments in modules/import_paypal/import_paypal_update.php Lines 117 to 119 are:

      $payment_no = write_customer_payment(0, $customer_id, $branch_id,
          $paypal_bank_id, $recpt_date, $ref,
          $gross, 0, $company, 1, 0 - $fee, $gross, $paypal_fee_act);

The $gross appears twice.

I am still getting the database error:

Any suggestions?
Ion

If the TB_PREF = "1_", then execute :

SELECT 
   trans.*
  ,ov_amount+ov_gst+ov_freight+ov_freight_tax+ov_discount AS Total
  ,cust.name AS DebtorName
  , cust.address
  , cust.curr_code
  , cust.tax_id
  , com.memo_
  , shippers.shipper_name
  , sales_types.sales_type
  , sales_types.tax_included
  , branch.*
  , cust.discount
  , tax_groups.name AS tax_group_name
  , tax_groups.id AS tax_group_id  
FROM 1_debtor_trans trans
  LEFT JOIN 1_comments com ON trans.type=com.type AND trans.trans_no=com.id
  LEFT JOIN 1_shippers shippers ON shippers.shipper_id=trans.ship_via
  , 1_debtors_master cust
  , 1_sales_types sales_types
  , 1_cust_branch branch
  , 1_tax_groups tax_groups
WHERE trans.trans_no=''
  AND trans.type='10'
  AND trans.debtor_no=cust.debtor_no 
  AND sales_types.id = trans.tpe
  AND branch.branch_code = trans.branch_code
  AND branch.tax_group_id = tax_groups.id;

If you have a backup prior to the paypal imoprt, then revert to it.
Then manually do the transactions necessary for 1 paypal transaction.
Take a backup.
Now revert back to previous db state.
Now import the same transaction using the import_paypal extension
Take a backup again.
Now compare the last 2 backups using a diff tool like WinMerge and see what is different.

The fact that the SQL executed without error incicates that the absence of transactions is a functional application error. Need to also contact the module author.

Actually Paypal Import Transactions is more of a payment transaction basically and not an invoice generation / customer creation transaction although the code sports it. The Customer and their Invoice should generally pre-exist for a PayPal transaction to effect payment allocation to it. It is therefore no wonder that no transactions are related to existing customers and is  either not imported at all or is imported as an orphan record. You can try to create the customer and invoice manually if they do not exist and then manually allocate / edit allocation of the payment.