• From: UK, Norfolk
  • Registered: 12/03/2014
  • Posts: 28

Topic: Import Transactions 2.3.22-4 2.3.22-4

When testing this feature I get the message

67 Payments would have been successful if imported. Uncheck Trial check before importing.

Around line 238 of /modules/import_transactions/import_transactions.php change

// Commit import to database
if ((isset($_POST['trial'])) && ($_POST['trial']==null)){     
    $trial = null;
}
if (isset($_POST['trial']) && ($_POST['trial']!=null)) {
     $trial = !null;
}

To

// Commit import to database
if ((isset($_POST['trial'])) && ($_POST['trial']==null)){     
    $trial = null;
}
if (isset($_POST['trial']) && ($_POST['trial']!=null)) {
     $trial = !null;
}

if (!isset($_POST['trial']) ) {
     $trial = null;
}

seems to do the trick.

HTH

G

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,160

Re: Import Transactions 2.3.22-4 2.3.22-4

What is the version of your PHP?

apmuthu's Website

  • From: UK, Norfolk
  • Registered: 12/03/2014
  • Posts: 28

Re: Import Transactions 2.3.22-4 2.3.22-4

5.2.17

4 Reply by apmuthu (edited by apmuthu 12/17/2014 04:31:27 am)

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,160

Re: Import Transactions 2.3.22-4 2.3.22-4

What is the meaning of $trial = !null; ? Is the value true or false? Is it's value dependent on PHP version used?

This logic can certainly do with some housekeeping.

apmuthu's Website

  • From: UK, Norfolk
  • Registered: 12/03/2014
  • Posts: 28

Re: Import Transactions 2.3.22-4 2.3.22-4

I believe it sets the value to 1.

It is a very confusing way of testing if a box is checked or not.

It was failing to cater for the box not being checked.

if (isset($_POST['trial']) && ($_POST['trial']!=null)) {
     $trial = true;
} else {
     $trial = false;
}

Is probably neater.

HTH

G

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,160

Re: Import Transactions 2.3.22-4 2.3.22-4

$trial = (isset($_POST['trial']) && ($_POST['trial']!=null)) ;

is way better.

apmuthu's Website

  • From: UK, Scotland
  • Registered: 11/30/2014
  • Posts: 21

Re: Import Transactions 2.3.22-4 2.3.22-4

Code has been adjusted in the extension.

8 Reply by apmuthu (edited by apmuthu 03/19/2015 03:28:43 pm)

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,160

Re: Import Transactions 2.3.22-4 2.3.22-4

Link to commit would be useful. Your commit list does not show it as yet.

apmuthu's Website