Edit bank transfer

Joe please add this.

@cambell

Nice feature, however it needs some cleanups to be integrated in FA sources.

1. Edition can easily lead to negative balance on account which is not acceptable especially accounts of  on cash type. At least check_valid_entries() has to be  modified to forbid such situations testing change in transfer value against future account history.  But generally I guess it will be hard to achieve when edition is done as void/insert sequence instead of transaction modification, and without any limits (keep in mind situation, when one changes not only amount but also to/from accounts during edition).
2. Voided entries are still visible as zero amount transfers in bank account history.
3. There are a couple of small problems with variables declarations, which are not visible until debugging mode is on. Please set  $go_debug=1 in your config.php file during development to see it.
4. For better UI consistency I would also add edition links to bank transfers in 'Bank Account Inquiry' page.

Janusz

Consider following simple scenario:
1. Create new Bank Account of cash type;
2. Transfer $100 to this account from any other account;
3. Entry $60 payment to supplier from the cash account;
4. Edit transfer created in step 2 changing amount from $100 to $50

and you will end with -$10 balance on the cash account without any warning nor error.
The same negative balance issue you can trigger by simply changing target account to any other one during edition.

Regarding the zero entries displayed in bank account inquire they just should be omitted in Bank Inquiry listing. This can be achieved by sql modification in get_bank_trans_for_bank_account() function.

Janusz

No not yet.  See my Trello board if you want to track progress on anything I'm doing with FrontAccounting.

Please look closer on the check_bank_account_history() algorithm. This function scans all the bank history to find whether atomic change in balance made on some date is safe or not.

If you try implement transfer edition as void/entry sequence in general you have take into consideration two dates:
1. original date for which old transaction is voided (check against -ve balance in target account);
2. new date for which new transaction is entered (check against -ve balance in source account).

In addition you should consider special situation, when only amount changes (but from/to account and date don't): in this case only change in amount on the old transaction date should be tested, otherwise you can have 'false positive' results in case of small change made on big transfer amount.

Janusz

Updated code is here.  Unit tests are here.