1 (edited by jlinkels 02/03/2014 10:33:42 pm)

Topic: Credit note can be paid, this should not be allowed

This might or might not be related with this post:
https://frontaccounting.com/punbb/viewtopic.php?id=4670

FA version 2.3.19
Actually Apmuthu's repo from 2014-01-03, see this post
https://frontaccounting.com/punbb/viewtopic.php?pid=18921#p18921

Sequence is this:
I have purchased goods, received those goods and paid the invoice.
Now I discover that I should return the goods.
I return the goods and I receive a credit invoice from the supplier.
So in the Purchases tab I enter a Credit Invoice
During editing the Credit Invoice I can select goods which I have returned.
On the Credit Invoice screen I enter the credit invoice and the goods returned.

This is all completely correct.
Accounts Payable is debited.
Goods Transactions shows that I have returned the goods from stock.
Stock account is credited.

Now this is where the error is:
When I go to Purchases tab -> Enter Supplier payments.
The Credit Invoice shows up in the list of eligible invoices to pay.
I can select the Credit Invoice to pay
When I select the Credit Invoice and select Pay All, the credit invoice is actually paid.
That is, Accounts Payable is debited.
My bank account is credited.

I don't think it should be this way. Two options:
1. Either the Credit Invoice should not show up in the list of invoices to pay,
or a payment should not be accepted.
OR
2. If the Credit invoice shows up and is selected to be "paid", then actually the A/P should be credited and the bank account must be debited.

Option #2 is easy, but not really correct in the sense that you don't pay anything. The transactions are correct though.

jlinkels

Re: Credit note can be paid, this should not be allowed

You are right. Credit notes should not show up in the items for allocation. I also see some other strange things. Will have a look at this.

/Joe

Re: Credit note can be paid, this should not be allowed

Thanks!

Re: Credit note can be paid, this should not be allowed

This has now been fixed. The supp credit notes should not be seen in allocable list.

When crediting invoices from transaction invoices, the invoice is automatically been allocated.

HG repo is updated.

However when using crediting of specific lines (not necessarily whole invoice), the allocation must be done by the routines for allocation.

Please download the files, /purchasing/includes/db/invoice_db.inc and /purchasing/includes/db/suppalloc_db.inc and replace.

/Joe

Post's attachments

invoice_db.inc 27.6 kb, 4 downloads since 2014-02-04 

suppalloc_db.inc 9.8 kb, 5 downloads since 2014-02-04 

You don't have the permssions to download the attachments of this post.

Re: Credit note can be paid, this should not be allowed

Thanks very much Joe.
I'll download the new files and install them.
But the files are .bin files. Can I simply rename them to .inc?

jlinkels

Re: Credit note can be paid, this should not be allowed

Strange. Can you read them in an editor? If so, you can just rename them to .inc.

/Joe

7 (edited by jlinkels 02/05/2014 10:47:41 am)

Re: Credit note can be paid, this should not be allowed

am totally lost now. This is what I got yesterday:

-rw-r--r-- 1 jlinkels jlinkels   28218 Feb  4 23:03 invoice_db.bin
-rw-r--r-- 1 jlinkels jlinkels    9995 Feb  4 23:04 suppalloc_db.bin

IIRC I was working in Chrome when I downloaded them.
Also in Chrome, when I tried to post this answer, it wouldn't accept the pun bot question. Using a different browser did accept.

Now when I downloaded the files with the different bowser they saved correctly as .inc.
And yes, these bin files were readable and looked like normal php.

Anyway, today is a new day with new challenges smile

jlinkels

Re: Credit note can be paid, this should not be allowed

I can confirm that the credit invoices do not appear in the list of payable invoices anymore.

jlinkels