How to make a link popup a window? (Page 1 of 2)

Chris, I guess these items can be added as tabs, like 'Transactions' and 'Status'. Thanks for the idea. I will try to include these tabs. Then I will be back.

/Joe

Included Sales Pricing, Purchasing Prising, Cost update and Reorder Levels in tabs in Items form.

The HG repository is updated.

You can download the file new_tabs.zip that include these files:

/inventory/cost_update.php
/inventory/prices.php
/inventory/purchasing_data.php
/inventory/reorder_level.php
/inventory/includes/db/items_prices_db.inc
/inventory/includes/db/items_trans_db.inc
/inventory/manage/items.php

Unpack the zip file and replace the files in relevant folders.

Hope you are satisfied with this.

/Joe

Hi, Joe:

Thanks for the updated files.  Very nice!  It's all in one handy place now!  WOO HOO!

Thanks, too, for the pointers/tips on popup windows.  I'll take a look later today.

Regards,

Chris

Your second list item.
All the listboxes (comboboxes) are in the file /includes/ui/ui_lists.inc and the customer list is on line 486 and derivations from that further on.

Your first list item.
Well, I guess it is in one of the javascript files in the /js folder. I must ask Janusz to comment on that. He fixed the Ajax and Js scripts.

/Joe

HG Changeset 3162 has a set of changes to implement tabs.

There seems to be one mistake in the file inventory/cost_update.php for the number of arguments of the function called display_notification() that takes only 2 but is given 3, replacing the function called display_note() that took 4.

Both functions are defined in includes/ui/ui_msgs.inc.

First, thanks to everyone for the information provided so far!  I have spent many hours the last couple of days wandering around the FA code, and your pointing me in the right direction has been very helpful.

Unfortunately, while I can get the general idea of how the code is working, I just don't have sufficient PHP coding skills to truly understand what's going on.  FA is a very complex application, with many nested functions (i.e. functions calling other functions), and it's just too over my head and mind boggling.

So, let me explain what I'm trying to accomplish and then, maybe, someone with more skill that I can do it if they have the desire and time to do so.

Currently, in the purchasing module, when I'm using Purchase Order Entry, Direct GRN, or Direct Invoice I can hit F2 to pop-up the purchasing/manage/suppliers.php screen, create a new supplier and then click the "Select" button at the bottom of the screen.  When I do this, the purchasing/manage/supplier.php screen closes and fields on the purchasing screen (PO Entry, Direct GRN, or Direct Invoice) are populated with the data for the new supplier.  This is very handy as I don't have to leave the purchasing screen to create a new supplier.

Now, let's go to another scenario.  I'm entering items on the PO Entry, Direct GRN, or Direct Invoice screen.  I suddenly realize that the item I want to enter isn't in the database.  So, I now have to go over to the inventory module, create the item, and come back to the purchasing screen to finish entering my PO, GRN, or invoice  However, before I can continue, I must refresh the purchasing screen so that it will pick-up the new item in the database.  When I do this, I lose all previously entered items and have to start all over!

This isn't a big deal if it happens at the beginning of entering items, but if I have entered a lot of items it can be really frustrating!  And it's even more frustrating if it happens multiple times while trying to enter the same PO, Direct GRN, or Direct Invoice!  So, what I do now is before I go into the purchasing module to create a PO, Direct GRN, or Direct Invoice, I use inventory/manage/items.php to check each item to make sure it's in the database.  This is a lot of extra work for me, but is better than getting half-way through a PO, Direct GRN, or Direct Invoice and having to start over again because one or more items isn't in the database.

So, what I'm looking for is where I can hit another function key when I'm entering items into a PO, Direct GRN, or Direct Invoice which will pop-up the inventory/manage/items.php screen so that I can create a new item.  When I'm finished  doing that, I click on the "Select" button at the bottom of the inventory/manage/items.php screen.  It then closes and the fields on the line in the items section of the PO, Direct GRN, or Direct Invoice screen are updated with the data for the new item.  I can then save that line and carry on with entering the rest of my PO, Direct GRN, or Direct Invoice.  No more having to refresh the screen and start entering items all over again! 

I hope the above explanation is clear?  If not, let me know and I'll try explaining again.  If this is easily do-able, I think it would greatly improve FA's functionality in the purchasing module.  If it's not easily do-able, I guess I'll just have to keep checking items using inventory/manage/items.php and creating new items before I go into purchasing and use the PO, GRN, or invoice screens.

Thanks, again, for all your help!  I really do wish I were knowledgeable enough to figure this out on my own.  Maybe I will be someday, but not today. 

Regards,

Chris

In the purchasing data on Items and Inventory tab, you can setup the suppliers discription of an item.

/Joe

Right, but that's not what I'm trying to do.  A fuller explanation might help....

Rather than create an item for each and every piddly thing I purchase, I have created several generic items with their type set to "service" because I also don't want to track them through inventory.  Then, when I purchase the item I want to edit the description from the generic description to what the item actually is.  Because it's a generic item, there might be more than one on each purchase invoice (I just ignore the warning FA gives), but that's okay because the item description tells me what the item actually is.

The best example of this is office supplies.  I do not want to track any office supplies through inventory, and I do not want to create an item for every piddly bit of office supplies I use (pens, paper clips, paper, and on and on).  So, I have created a service item called "MISCOFF" (Misc. Office Supplies).  When I buy a bunch of office supplies, I want the direct purchase invoice I create to look like this:

• MISCOFF - Black Pens (12/Box) 1 EA @ 3.00 Total = 3.00

• MISCOFF - Paper Clips Large (100/Box) 2 EA @ 1.50 Total = 3.00

• MISCOFF - Paper Clips Small (100/Box) 2 EA @ 1.00 Total = 2.00

See what I mean?  So, like I said, being able to edit the description before saving the line instead of having to save the line, edit it, then save it again, would be a time saver.  It's not critical, but it sure would be handy!

Regards,

Chris

Okay, I did some more "exploring" and figured out how to get the inventory/manage/items.php window to pop-up while I'm in the sales direct invoice screen.  In includes/ui/ui_lists, I changed function customer_list by adding the hotkey for inventory.

Change line 495-496 from this...

    if ($editkey)
        set_editor('customer', $name, $editkey);

To this...

    if ($editkey)
        set_editor('customer', $name, $editkey);
        set_editor('item', $name, $editkey);

I can now view/create/edit items in the pop-up window.  However, when I click the "Select" button at the bottom of the screen, the items window closes but does not populate the item code field on the Direct Invoice screen.

Obviously, I'm missing a step here.  Any help provided will be greatly appreciated!

Thanks!

Regards,

Chris

Did you mean:

    if ($editkey) {
        set_editor('customer', $name, $editkey);
        set_editor('item', $name, $editkey);
    }

I am terrible sorry guys, and especially you @chris.

It turns out to be a little glitch when changing the Item list box fill a year ago. A parameter was missing in the new one.

The function in ui_lists.inc, line 776:

function stock_items_list_cells($label, $name, $selected_id=null, $all_option=false, 
    $submit_on_change=false, $all=false, $editkey = false)

indicates a final parameter $editkey. If this is true, a f4 key is available to call upp the items form in a popup window.

So in file /purchasing/includes/ui/po_ui.inc line 401:

        stock_items_list_cells(null, 'stock_id', null, false, true, false);
should have a last parameter set to true
        stock_items_list_cells(null, 'stock_id', null, false, true, false, true);

And finally there was a little bug in /inventory/manage/items.php on line 22. Should be:

page(_($help_context = "Items"), @$_REQUEST['popup'], false, "", $js);

Try to change theese lines and it will work with the f4 key. Some times you have to pres this key twice.

So F2 = customer/supplier, F3 = customer branches and F4 = items in forms where this is established.

This will be sent to the HG repository. First I will have a look into other scripts if it need changing.

You can also download the 2 files here. Rename the items.php1 to items.php and replace the files
/inventory/manage/items.php
/purchasing/includes/ui/po_ui.inc

/Joe

Btw, Joe, does this mean that the changes I made in includes/ui/ui_lists.php aren't needed and should be removed?  Or, should I leave them as is?

Thanks!

Regards,

Chris