email of quotes (Page 1 of 2)

An error happened when implementing the email of sales document.

In /reporting/rep111.php, line 83 
    
    $contacts = get_branch_contacts($branch['branch_code'], 'order', $branch['debtor_no'], false);

The last parameter in get_branch_contacts should be true

    $contacts = get_branch_contacts($branch['branch_code'], 'order', $branch['debtor_no'], true);

You can look up this function call in rep109.php, rep110.php, rep111.php nd rep113.php and change the last paraameter to true.

These change has been changed in the HG repository.

Thanks for pointing this out!

/Joe

If you are looking for easy way for maintaining local patches on top of latest FA, you should simply use mercurial. Just clone sourceforge repository on your development box and  maintain your local changes in separate branch e.g.:

hg clone https://frontaccounting.hg.sourceforge.net/hgroot/fontaccounting/frontaccounting
hg branch local_branch

Then apply all your local patches, and save the changes:

hg commit -m "my local patches"

When new changes appears in repo and you want to update your local_branch:

hg pull
hg checkout local_branch
hg merge default

When no conflicts happen between your changes and chnages in repo you are done. Otherwise you have to resolve conflicts and commit the effect of merge to the local_branch (more details about how to resolve the conflicts you will find in google).
Janusz

Yes, if you only use the possibility to keep your own report version in company folder, you even do not need mercurial. But AFAIR you have talked about some other customizations (added links on final transaction page) in another thread. The described worflow should make your life  easier in this case.
Regarding the company folder you can easily remove the company folder from Mercurial version control in your local_branch to be on safe side.
Janusz

Yes, this is the right way.
Janusz

Anyone integrated PHPMailer in the place of the existing class.mail.inc ? This will enable sending using a relay SMTP server like gmail.

class.mail.inc is called and instantiated only in sales/includes/db/sales_order_db.inc and reporting/includes/pdf_report.inc. Hence such integration with PHPMailer would be easy.

Lines 994-996 in reporting/includes/pdf_report.inc:

                        $mail = new email(str_replace(",", "", $this->company['coy_name']),
                            $this->company['email']);
                        $mail->charset = $this->encoding;

Line 104 in sales/includes/db/sales_order_db.inc:

        $mail = new email($company['coy_name'], $company['email']);

The charset is missing and the coy_name is not stripped of commas in the latter case.

The latter should be:

$mail = new email(str_replace(",", "", $this->company['coy_name']),    $this->company['email']);

Better still would be to move the stripping of the commas to the class method constructor itself by inserting the following in line 47 of reporting/includes/class.mail.inc:

$name = str_replace(",", "", $name);

and removing the str_replace from both files that use the class.

It is possible that the comma may be a delimiter somewhere and may need to be stripped out of the Name. Also was checking for consistency and alternatives to the existing mailer like the integration in similar context.

For your specific requirement, you may want to dump the variables just before the send() occurs in both the caller instance and in the class method as well.

Maybe I am not being clear on what I need.  The 'from' I am talking about is not what shows up on the from when you just look to see where the email is from but the Return Path you see when you look at the header source. In this case, it is Return-Path: <www-data@mydomain.com>.

The problem is since www-data is not a user on the smtp server the email will not be fwd and it is just dumped. So it needs to be one of our users, for example sally@mydomain.com.

Maybe this help explain my problem.

ed10

How did you fix the return path? Was it the addition of a reply-to header in the script or in the class.mail.inc ?

$this->user is the currently logged in user whose email should be in the users table.

From the PHP mail() manual:

If the $this->user correctly enters the from header variable, it can be made to enter the same value into a $reply-to variable and used as above.

There is a $sender variable that gets populated as well?
Or just use the from header directly for the 'Reply-to' header.

Line 47 of reporting/includes/class.mail.inc:

$this->header = "From: $name <$mail>\n";

may be replaced with:

$this->header = "From: $name <$mail>\nReply-to: $name <$mail>\n";

The $add_params variable in the class.mail.inc file remains unused. Quote from the PHP manual for mail():

The $this-user in the other files may have an issue of scope of being an included file's variable.

Line 269 in reporting/includes/pdf_report.inc, the function Info() sets:

$this->user = $_SESSION["wa_current_user"]->name;

Since it is taken from session variable, and the function Info() is not called anywhere within the FrontReport class at all, it is called by it's instance in each report.

Each report file repXXX.php has some function(s) that make an instance like $rep = new FrontReport(.... followed by $rep->Info($params, $cols, $headers, $aligns); This will set the $user FrontReport class variable

The FrontReport class method End() in lines 993-995 includes:

require_once($path_to_root . "/reporting/includes/class.mail.inc");
mail = new email(str_replace(",", "", $this->company['coy_name']),
    $this->company['email']);

This method End() is called at the very end of each repXXX.php file.

All seems fine and hence the syntax to set the $this->user is wrong.

includes/session.inc provides the correct syntax:

$user = $_SESSION["wa_current_user"]->user;

Therefore Line 269 in reporting/includes/pdf_report.inc should be::

$this->user = $_SESSION["wa_current_user"]->user;

The said variable:
$_SESSION["wa_current_user"]->name
appears in:

reporting/includes/pdf_report.inc
reporting/includes/excel_report.inc
admin/db/maintenance_db.inc
themes/aqua/renderer.php
themes/cool/renderer.php
themes/default/renderer.php

A few months ago, some repeating code in all the renderer.php files were siphoned out elsewhere to a single function and at that time the variable may have vanished from being set or when changes to includes/session.inc were made over time.

Therefore while retaining the variable $_SESSION["wa_current_user"]->name in the said files, it may be required to set the field real_name from the users table if the user is logged in - in the includes/session.inc file.

Come to think of it, thereal_namein theuserstable does not seem to be used anywhere! Optional field that may not have any value at all!