rounded errors

Ok , should I use 1e-6 or anything else (0.01 as I guess pretty much every currency have cents) or an actual decimal settings somewhere in FA ?

How should I send the files ?
/Elax

Well, I'm not sure where the problem appears, but in general case rounding errors should never appear in accounting application. This simply can break balances in some places. Please report where you have found the problem, maybe better approach is just to avoid the problem at the source?

Janusz

There are some situations, f.i. when you get payments from your customers or pay your suppliers in another currency than the customers/suppliers currency, that you may be left with a small rounding error. This is only located in the receivals / payment ledgers.
This is the reason for using this small rounding fix.

/Joe

It is not the double precission that causes this problem. Consider the following:

When you pay and allocate customers/suppliers in another currency than the customer/supplier there would occasionally be a small leftover, either positive or negative in the AR/AP ledger. FA does not consider the record as fully paid. That is the reason for doing the check for either 0.0001 or 1e-6 to check that the record is 'paid'.

So I guess we can can continue with double precission.

/Joe

I have an real example , and strangely it's a php problem
<?php
   echo (335.74+30.52) == (305.22+61.04) ? "equal" : "not equal";
?>

>> not equal.

If you do the same in SQL it's equal (I don't know why).
Anyway I have this real , you can do it yourself on a test database

The invoice is 305.22 + 61.04 of VAT
And I payed with 2 different payments : one of 335.74 and the second one of 30.52  (a credit note)

This payment appears in the list of overdue invoices but not in red. I think the "filtering" is done on the 'sales/inquiry/customer_inquiry.php' line 212.
If you change
   (abs($row["TotalAmount"]) - $row["Allocated"] != 0)
by
   (abs(abs($row["TotalAmount"]) - $row["Allocated"]) > 1e-6)

everything is fine.

(Even if the column was decimal we will still have the problem as the numbers will be added in PHP)

/Elax

Yes, Elax, you are right . This is really real example . Surely any reported issue of this kind will be fixed.
Janusz

elax, please add the following lines in /includes/current_user.inc after the function number_format2

/* price/float comparision helper to be used in any suspicious place for zero values? 
usage:
if (!floatcmp($value1, $value2)) 
    compare value is 0
*/

define('FLOAT_COMP_DELTA', 0.0000001);

function floatcmp($a, $b)
{
    return $a - $b > FLOAT_COMP_DELTA ? 1 : $b - $a > FLOAT_COMP_DELTA ? -1 : 0;
}

and see if it is ok with the floatcmp.
reporting/rep102.php had alreade a filter in the sql used in the file.

/Joe

ok, elax, please continue report files and lines that need the new floatcmp filter.

The following files have been updated in the HG repository:
/reporting/rep101.php
/reporting/rep102.php
/reporting/rep201.php
/reporting/rep202.php
/sales/inquiry/customer_inquiry.php

Other files will be added as we find more.

The theme exclusive has been updated for this about a month ago. Please re-install.

/Joe