• dz
  • Member
  • Offline
  • From: Pakistan
  • Registered: 10/07/2019
  • Posts: 48

Topic: Credit note can be posted without customer selected

If Search Customer List is checked in company setup, than customer credit note can be posted with blank customers in FA's previous builds. I have added following lines in /sales/credit_note_entry.php under can_process() function to fix this

    if (!get_post('customer_id'))
    {
        display_error(_("There is no customer selected."));
        set_focus('customer_id');
        return false;
    }
   
    if (!get_post('branch_id'))
    {
        display_error(_("This customer has no branch defined."));
        set_focus('branch_id');
        return false;
    }


Thanks

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Re: Credit note can be posted without customer selected

@joe: Can this make it to the core? Credit Note and Debit Note can be posted to both Customer and Supplier.

apmuthu's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: Credit note can be posted without customer selected

I will have a look.

Joe

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: Credit note can be posted without customer selected

This has been fixed both on Customer and supplier side. Committed to stable repo.

/Joe