• From: India, TN, Karur
  • Registered: 05/16/2014
  • Posts: 1,181

Topic: money_format is also deprecated in aove PHP 7.4.

From our pdf_reports.inc 

$ret = $this->TextCol($c, $n, money_format($amount_format, $txt), $corr, $r, $border, $fill, $link, $stretch);

Here is the only place we have used the money_format. It has a definition for windows  from current_users.inc

if (!function_exists('money_format'))
{
    function money_format($format, $number) 
    {
        return price_format($number);
    } 
}

I think we better use the price_format or number_format2 here to fix this issue,

@joe, looking word from you.

Subscription service based on FA
HRM CRM POS batch Themes

kvvaradha's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: money_format is also deprecated in aove PHP 7.4.

Will have a look.

Joe

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: money_format is also deprecated in aove PHP 7.4.

i have amended the text in current_user.inc, line 369.

We will let it be for a while, for backwards compatibility in modules.

/Joe

  • From: India, TN, Karur
  • Registered: 05/16/2014
  • Posts: 1,181

Re: money_format is also deprecated in aove PHP 7.4.

may be you need to check in the new version.

Subscription service based on FA
HRM CRM POS batch Themes

kvvaradha's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: money_format is also deprecated in aove PHP 7.4.

@kvvaradha

I see no problem here. Do you?

/Joe

6 Reply by kvvaradha (edited by kvvaradha 07/24/2021 02:43:33 am)

  • From: India, TN, Karur
  • Registered: 05/16/2014
  • Posts: 1,181

Re: money_format is also deprecated in aove PHP 7.4.

here is the screenshot of error from my php, which is PHP8

Post's attachments

screenshot-localhost-2021.07.24-08_12_39.png 299.7 kb, 1 downloads since 2021-07-24 

You don't have the permssions to download the attachments of this post.
Subscription service based on FA
HRM CRM POS batch Themes

kvvaradha's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: money_format is also deprecated in aove PHP 7.4.

Ok, I am also using php 8, $go_debug=2 and not getting this error. I am an old C and C++ programmer and these languages always take care of old versions (backward compatible), so I am getting really weird of this php language.

We will simply change the function in pdf_report.inc.

We still have some other issues in php 8. Working on it. One of them is crediting in Customer Transactions.. Not reading the original invoice.

So please do NOT use php 8 seriously yet.

Joe

  • From: India, TN, Karur
  • Registered: 05/16/2014
  • Posts: 1,181

Re: money_format is also deprecated in aove PHP 7.4.

No I am not using it for live.  I am testing it on new version to update the deprecated codes. The live is 7.3 sofar it works fine.

Subscription service based on FA
HRM CRM POS batch Themes

kvvaradha's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: money_format is also deprecated in aove PHP 7.4.

Hello again,

The fix for money_format has been replaced by price_format and is committed to stable repo.

The php 8 version is progressing. the bugs with crediting an invoice and direct Invoicing is working again both for customers and suppliers. The fix has just been committed by Itronics to stable repo.

Please help testing if you have time and access to php 8. So we can get php 8 ready.

/Joe

10 Reply by kvvaradha (edited by kvvaradha 07/26/2021 04:12:44 am)

  • From: India, TN, Karur
  • Registered: 05/16/2014
  • Posts: 1,181

Re: money_format is also deprecated in aove PHP 7.4.

Great to hear joe. I am constantly checking it and if I find further issues, I will provide you solution.

and please look into the updated module of Cash flow statement

Subscription service based on FA
HRM CRM POS batch Themes

kvvaradha's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: money_format is also deprecated in aove PHP 7.4.

Cash flow statement fixed and sent to extension repo.

Will be updated asap.

/Joe