• rafat
  • Senior Member
  • Offline
  • From: UAE, Dubai
  • Registered: 11/28/2017
  • Posts: 540

Topic: The new Dashboard

As of 2.4.10 we have a new dashboard.. It looks very nice.
Been testing and two little observations.

1. In Sales dashboard If the Customer Name in Top 10 customers in fiscal year with Donut or Half Dont chosen is  long then the name overlaps the value and it becomes unreadable. If I change the languae to RTL then it is ok. See attached screen.

2. On all dashboards In RTL language all label text is still Left aligned. It should be right aligned. IMHO both (RTL and LTR) should be centered..See attached Screen.

Will keep experimenting..

Post's attachments

Sales_Dashboard_RTL.zip 81.3 kb, 8 downloads since 2021-06-21 

You don't have the permssions to download the attachments of this post.

rafat's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: The new Dashboard

Hello @rafat.

I enclose 2 files dashboard.inc and class.graphic.inc. Will you replace the two files and try again.

I will not commit before we are satisfied.

/Joe

Post's attachments

class.graphic.inc 64.9 kb, 6 downloads since 2021-06-21 

dashboard.inc 49 kb, 7 downloads since 2021-06-21 

You don't have the permssions to download the attachments of this post.
  • rafat
  • Senior Member
  • Offline
  • From: UAE, Dubai
  • Registered: 11/28/2017
  • Posts: 540

Re: The new Dashboard

Thanks @joe,
I will test and come back to you..

rafat's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: The new Dashboard

Hello again @rafat.

Here is a slightly modified version, with improved legend layout for RTL pie, donut and half donut.

/Joe

Post's attachments

class.graphic.inc 64.9 kb, 3 downloads since 2021-06-22 

You don't have the permssions to download the attachments of this post.
  • rafat
  • Senior Member
  • Offline
  • From: UAE, Dubai
  • Registered: 11/28/2017
  • Posts: 540

Re: The new Dashboard

Hi @joe

Looking better day after day. We still have a little problem with long Customer names as it still overlaps. I guess using the Customer Short Name will solve this issue. Attached screen shot

Post's attachments

shot_210623_085346.png 39.5 kb, file has never been downloaded. 

You don't have the permssions to download the attachments of this post.

rafat's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: The new Dashboard

HI @rafat,

And again a slightly modified RTL pie, donut and half donot legend.

I have now made it calculated on label length and value length and came up with this.
Also changed for LTR.

You may feel that the label is to much left, but with short strings it seems ok.

Well, we can change back if not good smile

/Joe

Post's attachments

class.graphic.inc 65.2 kb, 3 downloads since 2021-06-23 

You don't have the permssions to download the attachments of this post.
  • rafat
  • Senior Member
  • Offline
  • From: UAE, Dubai
  • Registered: 11/28/2017
  • Posts: 540

Re: The new Dashboard

This morning I took a first run at it , but was very busy to continue. I will take a look at it after the Sweden vs Poland game .ie Joe vs Januze ...if I am not mistaken. That is if I am still awake. lol

rafat's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: The new Dashboard

Ok, @rafat,

Sweden won by 3 to 2. Good for us smile

I upload the last example, with better RTL legends in pie,donut andhalf donut.

/Joe

Post's attachments

class.graphic.inc 65.3 kb, 1 downloads since 2021-06-23 

You don't have the permssions to download the attachments of this post.
  • rafat
  • Senior Member
  • Offline
  • From: UAE, Dubai
  • Registered: 11/28/2017
  • Posts: 540

Re: The new Dashboard

@joe,

We will get there somehow..Sales Dashboard as an example.. Customer Names are Truncated and left justified and the color legend is lost.. This is also reflected in the Settings Dashboard..I guess if this is fixed it will reflect on all dashboards..

Post's attachments

Sales_Dashboard_RTL2.png 62.2 kb, file has never been downloaded. 

You don't have the permssions to download the attachments of this post.

rafat's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: The new Dashboard

@rafat

The text justification in the table is browser html treated. So this is a tricky one.
The right justificationfor for text in the SVG graphics legends could be fixed, however.
What should we do?

Joe

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: The new Dashboard

@rafat

To sum up. In most places in FA tables, transaction lists, the text columns are left justified also for RTF.

In some other places, f.i. reports, the text columns are right justified.

So I think we should leave the html table columns be as is.

But we could fix the graphics legends to be right justfied in all graphic types. What do you say?

Joe

  • rafat
  • Senior Member
  • Offline
  • From: UAE, Dubai
  • Registered: 11/28/2017
  • Posts: 540

Re: The new Dashboard

@joe I agree

The html tables can be taken care of by changing the the theme default.css a little. I tried it and it works. All the changes are mentioned in the forum.

https://frontaccounting.com/punbb/viewtopic.php?id=8220

Yes then lets get the graphics working>

rafat's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: The new Dashboard

Ok, I will continue tomorrow with the right justified text legends.

/Joe

14 Reply by poncho1234 (edited by poncho1234 06/24/2021 09:22:35 pm)

  • From: Colombia
  • Registered: 12/29/2014
  • Posts: 627

Re: The new Dashboard

@joe, @rafat

As per https://www.w3.org/ the default text alignment for LTR is left and for RTL is right.

So removing from File:default.css

32: table {
33:     text-align: left;
34: }

Will give control of text alignment back to HTML as it probably should be, giving the correct alignment for both LTR and RTL.

Further reference:https://www.w3.org/TR/html401/present/graphics.html

and

https://www.w3.org/TR/html401/struct/tables.html

The FrontAccounting Wiki(Manual, examples, tips, setup info, links to accounting sites, etc) https://frontaccounting.com/fawiki/
  • rafat
  • Senior Member
  • Offline
  • From: UAE, Dubai
  • Registered: 11/28/2017
  • Posts: 540

Re: The new Dashboard

@poncho1234 is absolutely correct..  nailed it. Removing the above lines makes the shift from RTL to LTR and vice versa very smooth. I tested on Chrome, Firefox and IE. All OK

rafat's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: The new Dashboard

Hello @rafat and @poncho1234

I am glad that you, @poncho1234, is contributing in this important matter.

You wrote that eliminating the table class in default.css would do it automatically. I couldn't reporduce this, will you upload your default.css, so I can test this.

Regarding the Graphics Legends in class.graphic.in . It should now work both in LTR and RTL. Please replace the attached file in /reporting/includes folder and let me know.

@rafat

It surely looks better now wink

/joe

Post's attachments

class.graphic.inc 65.2 kb, 6 downloads since 2021-06-25 

You don't have the permssions to download the attachments of this post.
  • rafat
  • Senior Member
  • Offline
  • From: UAE, Dubai
  • Registered: 11/28/2017
  • Posts: 540

Re: The new Dashboard

@joe..Attached is the default.css.. I needed to restart Apache for it to show.
Meanwhile I keep tetsting wit the new file.

Post's attachments

default.css 10.4 kb, 2 downloads since 2021-06-25 

You don't have the permssions to download the attachments of this post.

rafat's Website

  • rafat
  • Senior Member
  • Offline
  • From: UAE, Dubai
  • Registered: 11/28/2017
  • Posts: 540

Re: The new Dashboard

Sorry @joe.. no change with the new file. Same as before. Text truncated and color legend does not show.

rafat's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: The new Dashboard

@rafat,

I only had to clear my browser cache, then it worked with removing the table class in default.css.
So now we should just fix the default.css and it should be ok. Cool smile. Good work, @poncho1234!!
Anyhow it is good to also test that the LTR still works everywhere.

Ok, you still have some problem with your test. I will have to look at this. Any thing to reproduce this? Long text or so?

We are celebrating the Mid Summer today, so don't expect to much work here smile

/Joe

  • rafat
  • Senior Member
  • Offline
  • From: UAE, Dubai
  • Registered: 11/28/2017
  • Posts: 540

Re: The new Dashboard

@joe....have a nice weekend. See you Monday.

rafat's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: The new Dashboard

Hi again, @rafat

I have now gone through all the graphics on both SVG and traditional Graphics (JPG, PNG etc.).

The Graphic engine will truncate all labels longer than 27 chars in all the graphics. This make it much more flexibel to work with.

All the Graphics are now unified and will work as you want it to do.

Download the attached and replace it in /reporting/includes/class.graphic.inc and /includes/dashboard.inc folders.

You might try the reports Customer Aged.. and Supplier Aged (try the various graphic types). Also Balance Sheet and PL Sheet.

There was a reported bug under 'Report Bugs here'. Have a look here, there are 2 new files that should fix the issues here.

See ya Monday smile

/Joe

Post's attachments

class.graphic.inc 65.6 kb, 1 downloads since 2021-06-26 

dashboard.inc 49 kb, 1 downloads since 2021-06-26 

You don't have the permssions to download the attachments of this post.
  • rafat
  • Senior Member
  • Offline
  • From: UAE, Dubai
  • Registered: 11/28/2017
  • Posts: 540

Re: The new Dashboard

Hello again
@joe

The Dashboard seems fine for LTR. A little buggy with RTL. Let me take Arabic as an example as am testing that language.
Now I am in Preferences and chose Default theme and Arabic Language:
Sales --->Dashboard  Top 10 Customers
Arabic Customer Names are Truncated to fit---OK
English Customer Names are not Truncated---Overlap
Please note we do mix Arabic and English -- I dont know if this is a problem and we should not.
Only in pie or donut.

As for the reports definitely there is an overlap for Donut and Pie only for Balance and PL sheets.

See attached.

Post's attachments

Balance_and_Sales.zip 76.3 kb, 3 downloads since 2021-06-28 

You don't have the permssions to download the attachments of this post.

rafat's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: The new Dashboard

@rafat

The graphics for balance-sheet, pie, donut and half donut shold now be ok.

The graphics for sales customers top 10 is not changed, but you could try to reduce the MAXLEN in the define on line 63.
It is currently 27.
I see a big fontsize on the graphics, so try with 23 or so.

This is difficult to do when you mix Arabic and English language in the same graph.

But try to experiment a little.

/joe

Post's attachments

class.graphic.inc 65.8 kb, 1 downloads since 2021-06-28 

You don't have the permssions to download the attachments of this post.
  • rafat
  • Senior Member
  • Offline
  • From: UAE, Dubai
  • Registered: 11/28/2017
  • Posts: 540

Re: The new Dashboard

@joe

Reports look good now.. Where are the fonts size in the graphics of the Top 10 Customers are defined?

Thanks

rafat's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: The new Dashboard

I meant, try to set the currently defined value of 27 to 23 on line 63 in class.graphic.inc.

Joe