• From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Topic: Coding Constructs

Those developing the core FA code and / or extensions are advised to follow some of the common constructs espoused in PSR-1 other than namespace advisories for now.

For those using const and define, the differences are listed here.

apmuthu's Website

  • From: New Zealand, Wellington
  • Registered: 06/19/2014
  • Posts: 128

Re: Coding Constructs

Sounds good to me.  If the reports could be modified to comply that would be wonderful. All the report files both declare and execute which makes them difficult to call from custom modules.  Currently I hack the input to prevent execution when including the file so that I can then execute from the module.

If core devs are keen to progress with this I'm happy to contribute some time.

Cambell https://github.com/cambell-prince

cambell's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: Coding Constructs

@cambell

Look into reporting/includes/reporting.inc line 128, function print_link how to make a link to the core report you want.

Also look into manufacturing/workorder_entry.php line 64 how to build a report link.

Joe