@seahawk,

I can confirm rafat's statement. It works like a charm on v2.4.8

Thank you for the confirmation apmuthu, just as I hoped for. That leaves me happy with your modification that I've applied.

Thanks Joe, Apmuthu and Rafat.

Is it safe to state this possible SQL injection can only be executed by logged in users of my FA installation and not by unauthorised visitors crawling by?

I'll stick around to see the answers to this question.

And with that, is it reversible once updated to v2.4.8 or are the relating fields in the existing DB trimmed to 50 characters?

Much appreciated on behalf of the Dutch @apmuthu.
I know we're a minority here (unfortunately), but keeping things like this up to date helps to attract more Dutch people.

For the record, to fix the headers I modify file "../reporting/includes/header2.inc"

Original (Lines 182-189)

        // Line headers
        $this->row = $iline5 - $this->lineHeight - 1;
        $this->Font('bold');
        $count = count($this->headers);
        $this->cols[$count] = $right - 3;
        for ($i = 0; $i < $count; $i++)
            $this->TextCol($i, $i + 1, $this->headers[$i], -2);
        $this->Font();

Modified - add line 185 (Lines 182-190)

        // Line headers
        $this->row = $iline5 - $this->lineHeight - 1;
        $this->Font('bold');
        $this->headers = array(_("Item Description"),'', _("Quantity"),_("Unit"), _("Price"), _("Discount %"), _("Total"));
        $count = count($this->headers);
        $this->cols[$count] = $right - 3;
        for ($i = 0; $i < $count; $i++)
            $this->TextCol($i, $i + 1, $this->headers[$i], -2);
        $this->Font();

I agree that modifying file "../reporting/includes/doctext.inc" would be preferable, but that has a lot of consequences for a many other reports.

I recently upgrade from v2.3 to v2.4
As my business mainly supplies services, I used to remove the Article Codes column from the invoices (rep107). The codes are not much of use in my case and this leaves more white space to enter an appropriate description.

I've noticed the rep107 template changed quite a lot between v2.3 and v2.4.
I've got my adjustment working, but I think there is a better way of doing it, which preserves the '$c++, $c' instead of fiddling around with column numbers.

My work around;
Original (Lines 162-180)

                $c=0;
                $rep->TextCol($c++, $c,    $myrow2['stock_id'], -2);
                $oldrow = $rep->row;
                $rep->TextColLines($c++, $c, $myrow2['StockDescription'], -2);
                $newrow = $rep->row;
                $rep->row = $oldrow;
                if ($Net != 0.0 || !is_service($myrow2['mb_flag']) || !$SysPrefs->no_zero_lines_amount())
                {
                    $rep->TextCol($c++, $c,    $DisplayQty, -2);
                    $rep->TextCol($c++, $c,    $myrow2['units'], -2);
                    $rep->TextCol($c++, $c,    $DisplayPrice, -2);
                    $rep->TextCol($c++, $c,    $DisplayDiscount, -2);
                    $rep->TextCol($c++, $c,    $DisplayNet, -2);
                }
                $rep->row = $newrow;
                //$rep->NewLine(1);
                if ($rep->row < $summary_start_row)
                    $rep->NewPage();
            }

Modified (Lines 162-180)

                $c=0;
                //$rep->TextCol($c++, $c,    $myrow2['stock_id'], -2);
                $oldrow = $rep->row;
                $rep->TextColLines(0, 2, $myrow2['StockDescription'], -2);
                $newrow = $rep->row;
                $rep->row = $oldrow;
                if ($Net != 0.0 || !is_service($myrow2['mb_flag']) || !$SysPrefs->no_zero_lines_amount())
                {
                    $rep->TextCol(2, 3,    $DisplayQty, -2);
                    $rep->TextCol(3, 4,    $myrow2['units'], -2);
                    $rep->TextCol(4, 5,    $DisplayPrice, -2);
                    $rep->TextCol(5, 6,    $DisplayDiscount, -2);
                    $rep->TextCol(6, 7,    $DisplayNet, -2);
                }
                $rep->row = $newrow;
                //$rep->NewLine(1);
                if ($rep->row < $summary_start_row)
                    $rep->NewPage();
            }

Anyone?

TLDR; Time to pop the champagne!

What did I do?
===Trial 6===
6.1) Made a fresh DB dump from my v2.3.26 production
6.2) Did a clean install of v2.3.26
6.3) Created USA DEMO DB v2.3.26
6.4) Compared DBs and adjusted my version, even reorganised columns (probably not required). Had to adjust a handful (secondary) keys. Imported my adjusted DB and thoroughly confirmed working
6.5) Imported my adjusted DB into v.2.4.7 with applied Braath Wate changes and upgraded my DB
6.6) Compared USA DEMO DB v2.4.7 with my DB to make it 100% tickety-boo
6.7) Made a copy of my DB and went nuts on everything I could think of, comparing (with v2.3.26), adding entries and so on.
6.8) Finally Braath's last comment made sense (make sure that "Include in tax register" is checked)

Still journal entries on closed booking years will make discrepancies on tax reports of those relative timespans. A theoretically and minor issue, as it has zero operational impact. All other balances and reports have a 100% historical match with my v2.3.26. With that I now fully grasp Braath his last comment and have seen the outcome. This works during regular accounting and future journal entries.

6.9) I've backed up my v2.3.26 production environment, updated my php to v7.3 and am running v2.4.7-Braath now smile

I have a two minor things. One is regarding a invoice-report and I will probably open a new topic for that, if I can't figure it out. The other one might be answered here straight away. It seems like I have two obsolete tables in my DB, knowing;
    `0_company`
    `0_sys_types`
A quick search on the forum shows that `x_sys_types`indeed became obsolete. However, for `x_company` I can't seem to find any details at first sight (however, looking at the content of the table I'm happy to bin it).
Can someone confirm I can delete both tables?



Ps. As can been seen in this Trial 6, I've completely skipped the Dutch COA that was created by Apmuthu in this topic. It shows quite some discrepancies with the empty USA COA. Other than the differences between 'char' and 'varchar' (which will probably not cause any harm at all), it shows a couple 'KEY'-differences which might have severe impact (way out of my league). In example on tables;
    - `0_bom`
    - `0_crm_contacts`
    - `0_cust_allocations`
    - `0_debtor_trans_details`
    - `0_loc_stock`
    - `0_sales_orders`
    - `0_supp_allocations`
    - `0_tax_types`
Just to let you guys know, as you are the frontaccount guru's. I do appreciate all efforts made to help me, including the creation of the custom made Dutch COA. Thank you!

Finally, to all: Thank you so much for all effort in general and help to me especially. Awesome community!

My apologies on that bit Braath, I wasn't completely clear:
I was looking (comparing) historical tax data. Noted some small differences and concluded they exist due to journal entries dated on 31st of Decembers of different years made by my accountant.

Okay gents, I had some time to waste.

TLDR; I'm not out of the woods yet.

What did I do?
===Trial 5===
5.1) Started with a clean install of v2.4.7
5.2) Applied file changes from the @Braath Wate branch v2.4.6
5.3) Grabbed converted DB from Trial 1
5.4) Applies DB change from the @Braath Wate branch v2.4.6
5.5) Ticked the "Setup->Company Setup->Tax Bank Payments and Deposits" box
5.6) Compared several report (especially tax related) between this installation and my production v2.3.6

It looks very very promising. There is only one thing not taken into account, which IMHO needs to be. My accountant generally makes some journal entries at the end of the booking year to cross the t's and dot the i's (most entries concerns partly private use of company goods). Quite often this implies a small rectification of tax. In v2.3.26 this was correctly reflected in the Tax Inquiry. It is not reflected at all in v2.4.x and/or @Braath Wate branch.

Even though I can't figure out why v2.4 has changed big time on the tax part (other people have accountant and do journal entries, right?), I thought it would be a relative minor issue for now as I only have journal entries once a year. So I carried on to see how all was working.

I probably missed it before, but it turns out that the conversion of my DB from v2.3.6 to 2.4.x is not that good after all. I lost access to all my customers. After digging into the DB, and comparing it to my v2.3.6 DB, I noticed two or three major issues;

A - in table `0_cust_branch, column `br_address`is stripped to something like 60 characters or so, losing the majority of the second half of the adresses

B - Table `0_debtors_master` turned out to be completely empty, as in 'no data entries'

I've tried to restore/repair things manually, a bit tricky though as some columns were moved around and so. I gain various results, but I'm running out of time for today. I'm thinking of doing a new conversion of v2.3.6 to v2.4.x and meanwhile keep an close eye on this.

However, I stumbled on another significant difference between both DBs. Not sure if it is related. Not even sure if it will cause an issue, but I find it very odd.

C - The last two columns of table `0_gl_trans` (known as respectively `person_type_id` and `person_id') are transformed into NULL for the big majority (like 90 to 95%) of my entries.



As said, I plan on doing another DB upgrade from v2.3.6 to v2.4.x. However, any tips are more than welcome.

Quick reply just to thank you both, Braath and rafat.
First tests look promising (v2.4.6 branch). I'm a bit short on time now, but will return soon with my findings on a brand new install of v2.4.7. Either later today or after the weekend.

Big thank you for all participants of this topic. It took (me) a while, but you've really made my day. Awesome! Now I can stick to FA smile)

12

(8 replies, posted in Translations)

Awesome @itronics, much appreciated!

Hello all,

I stepped out of the conversation for about a year, my financial year was running and I was too busy (and confused) to focus/follow the conversation/solution.
As a new years resolution and with high hopes, I gave it another swing. A proper one.

So what is the deal?
My production version is v2.3.26 and running alright, but I like to move forward in order to use new functions and be able to use PHP 7.x

What did I do?
===Trial 1===
1.1) Clean install of v2.4.7
1.2) Upgraded old DB (no errors)
1.3) Encountered the tax issue

===Trial 2===
2.1) Clean install of v2.4.7
2.2) Upgraded old DB (no errors)
2.3) Used dutch COA as posted by @apmuthu in this topic for a new company
2.4) Compared my production DB with the fresh DB from the @apmuthu COA (no real biggies, but several small changes)
2.5) Inserted all my production data into the fresh DB from the @apmuthu COA
2.6) Looked around and gained a lot confidence in my upgraded production DB
2.7) Encountered tax issue

===Trial 3===
3.1) Applied the 8 file changes from @Braath Wate git branch on v2.4.7
3.2) Carried on with my upgraded production DB from Trial 2
3.2) Encountered tax issue

===Trial 4===
4.1) Pulled complete git branch from @Braath Wate
4.2) Used that to install clean version of v2.4.6
4.3) Imported my my upgraded production DB from Trial 2
4.4) Slipped in DB row in table  `0_sys_prefs` as per his branche
4.5) Encountered tax issue

All 4 trials show exact same tax issue

As an image says more than words (available for 31 days)....
Tax 2018 on v2.3.26 https://i.postimg.cc/jq8VHJ2t/image.png
Tax 2018 on v2.4.x https://i.postimg.cc/52WMyWjC/image.png

I have no idea how to resolve this and/or how to move forward. Any ideas?

14

(8 replies, posted in Translations)

Stefan66 wrote:

I have edited the Dutch language

Great job Stefan, thank you.

Bit disappointing that it is (still) not (yet) included in the downloader *hint*hint*

Good evening gents,

I kind of stepped out of the conversation as it got me completely bamboozled.
Looks to me that my CoA was not the (only) problem. But I'm pretty lost where we are now. Can I update again from v3x to v4x and safely carry on with my bookkeeping?

apmuthu wrote:

The official Dutch (nl_NL) Chart has been updated to match the fields and field orders in the FA24extensions repo.

Does this mean, I can do a new upgrade of the software and apply updated COA from the repository? That is awesome Apmuthu, thanks!
Now, in my understanding there is still something going on with rep709 which might or might not be part of my initially issue. I will keep a close eye on this topic.

Looks like Rafat & Braath have some history on a related/the subject. Apmuthu has found some additional information.

Seen some happy faces. But I'm not sure where this leaves me at the moment #confused

Woow, lots of comments! Thank you for that and your encouraging words. I would love to stay, I prefer open source, I love FA. In generally I try to contribute to OS communities. I've spent quite some time with the FA DB when I started 8 years ago, mainly to try to import exports from my bank account. From that time I know the FA DB is complex for an 'outsider', because of the nature of proper accounting and accounting rules. Even more as I have to trust it for my company, it has to be correct, it is not a kindergarten.

I know you guys are willing to help me, but I don't have enough faith in myself, I can not oversee the implications of what I'm doing in the database. As the error is easily re-produced (take current FA, load the 'official' dutch COA from the repository, do some accounting and check if the tax report matches) I was hoping for some support (read: fix) from the core community who knows what they're talking about. I fully understand if this is too much from me to expect, there is no blaming in here. But I've tried and drowning (I hate to admit, but it's true).

As said in my previous post, I'm not gone yet, but I do realise I can't stick with old version forever (with risk of not being able to update at all in a couple major versions from now). In the upcoming days I will work my way trough recent comments.

Much appreciated guys, really!

(edited typo's)

Okay, I have definitely reverted to the old version and will stick to that for a while. In between I'm afraid I have to start looking for some other software.

The differences between Apmunthu's dummy NL-COA (I'm still grateful for that, thank you) and the 'official' one from the repository might be severe or not, but way too much for me to handle.. There is too much stuff in there of which I have no clue how it will affect my accounting. Even if I would be able to fix things for now, I would have zero trust that all reports, closure of a book-year etc etc will either be correct or even more screwed by my adjustments.
And if that is not enough, if (big if) I would be able to correct differences between COA's, I'm not sure how to apply these correction on my years of accounting.

I guess this is the end of my 8 years of FA use sad

Sorry for my late reply, work picked up.
I'll start digging in to it. I have to travel quite a lot in the upcoming weeks and will do some trial and error on a local LAMPP.

I'll get back to you, but it might take some time. But I do appreciate your help a lot!

Hi Apmuthu, thanks for checking in.
I've downloaded your files, but I'm not sure what I'm supposed to do with it.

Best guess is uploading the SQL to see if it works. If it does (pretty sure it will), how can I apply it on my current 8 years of accounting?

Hi Poncho,

Just completed another test with a clean install of v2.4.6
Default company has an empty (no demo data) USA COA
Added a new company, assigning the Dutch COA

Exported the DB, but have no clue where to look. I was hoping for some community support on this, a FA DB guru who knows in which corner to start looking.

I started rebuilding from my working version back in November (v2.3.25)

Updated to v2.3.26 - fine, no errors
Updated to v2.4.1 - no errors, updated DB, update COA, all fine ----- got the same issue on the Taxes

If I make a fresh install on v2.4.1 with new company and Dutch COA, there is not showing any taxes after some dummy entries.

Other than solving the issue, I'm a bit in doubt .... should I carry on my current version keeping my fingers crossed on a solution. Or should I go back to November with v2.3.5 and redo the last two months......

Hi Poncho1234,

Thank you for your reply. And that makes perfect sense. I had a quick look in the DB with phpMyAdmin, but seems far from easy to compare COA's. Is there an easier way to compare them?

The 'System and General GL Setup' seems alright compared with older versions and compared with USA demo data.

corporatei wrote:

I checked the Tax Inquiry report and it does not show the Purchases taxes, only the Sales Invoices taxes.

But in the GL report, I can see  both purchases and sales invoices taxes, when I select the GST Tax account of GL.

Unfortunately I encounter the exact same issue after updating.
I've update last November to 2.4.4 and all seemed working. Continued my accounting up to now and preparing myself for the taxes of the last quarter of 2018. Exactly as above, only Sales taxes are showed and zero Purchases.

Doens't matter which period I select, or even all year. Zero Purchases. Exactly as TS, it does show correctly in GL.

Before posting here, I tried the following;
- Updated from 2.4.4 to 2.4.6
- Clean installation of 2.4.6, importing latest backup (php 5.6)
- Clean installation of 2.4.6, importing latest backup (php 7.3)
- Clean installation of 2.4.6, importing old backup november (php 5.6) - updating DB table set (from v2.3rc to v2.4.1)
- Clean installation of 2.4.6, importing old backup november (php 7.3) - updating DB table set (from v2.3rc to v2.4.1)

All without luck, the Tax Inquiry keeps showing zero's on Purchases.
And yes, if I install a dummy company with 'Standard USA COA + demo data' it works fine. (I use 'Dutch general COA     2.4.1-4')

Not sure if the issue of TS has been resolved via PM. But it would be great if somebody could help wink