2,226 Reply by apmuthu

(55 replies, posted in Report Bugs here)

OpenSSL issue?

Go to forum: Report Bugs here

2,227 Reply by apmuthu

(3 replies, posted in Accounts Receivable)

Refer this post and the wiki page.

However, a payment terms of Cash does not show Customer Pre payment link.

Go to forum: Accounts Receivable

2,228 Reply by apmuthu

(23 replies, posted in Report Bugs here)

Even if just 1 invoice is chosen and no currency filter is in place - all currencies will be allowed - there is no change in the code / sql for this choice of no currency.

@joe: should the file be committed?

Go to forum: Report Bugs here

2,229 Reply by apmuthu

(19 replies, posted in Reporting)

The effect of the Report End is achieved if the last ruled line is bolded or is a double bold line.

The spaces should not be implemented as a translatable string even if you use it. The column widths and their paddings are better adjusted instead.

Go to forum: Reporting

2,230 Reply by apmuthu

(23 replies, posted in Report Bugs here)

Try to use the attached rep107 and provide feedback.
This method has the ability make the report quicker on currency filter doing it in the sql itself.

@joe: see if it is fit to be committed into the core.

Go to forum: Report Bugs here

2,231 Reply by apmuthu

(23 replies, posted in Report Bugs here)

Actually, if the currency is not available, the report can be programmed to skip it. PARAM_2 is the Currency and the records should be skipped if it is to be filtered out in line 104.

Go to forum: Report Bugs here

2,232 Reply by apmuthu

(19 replies, posted in Reporting)

@joe: Nice work removing _("  ") (how did I miss it and why did @stefan put it in?). Also consolidating the comments and removing $loc2 (why did @stefan put it in?) apart from NewLine() and font size adjustments.

Go to forum: Reporting

2,233 Reply by apmuthu

(1 replies, posted in Installation)

@joe: Thanks. Committed.

Go to forum: Installation

2,234 Topic by apmuthu

(1 replies, posted in Installation)

In 2011, local install of packages was introduced where the hooks.php would encompass all install tasks - but that is available in the target company only after activation and not in the default company for the available extensions and their install buttons where the version is "Unknown" and the name is the folder name itself.

This post shows how the third party extensions get listed in the installed_extensions.php file as version  => '-' , whereas, it is listed as blank elsewhere so that the "Install Extension" icon in the extensions listing gets enabled. This happens at the end of includes/packages.inc:

/*
    Check basic extension source compatibility.
*/
function check_src_ext_version($ext_v)
{
    global $src_version;

    $compat_levels = 2;    // current policy is keeping compatibility on major version level.
    $app = explode('.', substr($src_version, 0, strspn($src_version, "0123456789.")));
    $pkg = explode('.', substr($ext_v, 0, strspn($ext_v, "0123456789.")));

    for ($i=0; $i < min($compat_levels, count($app)); $i++)
        if ($pkg[$i] < $app[$i])
            return false;

    return true;
}

which should now be corrected to be effective only when it is not a third party extension like:

/*
    Check basic extension source compatibility.
*/
function check_src_ext_version($ext_v)
{
    global $src_version;
    if ($ext_v != '-') {
        $compat_levels = 2;    // current policy is keeping compatibility on major version level.
        $app = explode('.', substr($src_version, 0, strspn($src_version, "0123456789.")));
        $pkg = explode('.', substr($ext_v, 0, strspn($ext_v, "0123456789.")));

        for ($i=0; $i < min($compat_levels, count($app)); $i++)
            if ($pkg[$i] < $app[$i])
                return false;
    }
    return true;
}

The logic to display the "Install extension" button/icon should be altered to read from a _init/config file if present in the third party module folder itself thereby populating the version and name fields as well instead of being "-" and folder name respectively as obtains now.

Currently the presence of a Version in the _init/config file in the official packages is provided to the available parameter on install when extracted using the function get_extensions_list() defined in includes/packages.inc.

@joe: kindly incorporate the fix listed here for a start so that third party installs do not get broken and / or resorting to use kludgy workarounds.

Go to forum: Installation

2,235 Reply by apmuthu

(24 replies, posted in Accounts Receivable)

Also we can make sure that if the Invoice Date becomes 29 to 31 we need to push it to the end of the month if it is invalid (like 31st Feb). That way, can we do away with the "-1" days by always choosing 31st of some valid / invalid month?

Go to forum: Accounts Receivable

2,236 Reply by apmuthu

(24 replies, posted in Accounts Receivable)

The method of date calculation for add_months() has been hardcoded for
1 leap day each 4 years,
1 more leap day each 100 years and
1 less leap day every 400 years.
The number of days each month are looked up in an array in this manner.

This translates into the famous "What day would Christmas be in the year ####" as absolute day of Christmas for a known year + no. of years to required year from known year * 1.2496.

That is why I wanted the Gregorian year php function to be used. Even then I doubt this issue would get solved fully.

Let us first determine what we want for each of the 29 (non leap years), 30, 31 dates.

Go to forum: Accounts Receivable

2,237 Reply by apmuthu

(55 replies, posted in Report Bugs here)

Looks like you have a php.ini issue as well.

Set in php.ini: allow_url_fopen=1 and restart your webserver.
It works well in PHP 5.3.1, 5.3.3 and 5.5.

Go to forum: Report Bugs here

2,238 Reply by apmuthu

(3 replies, posted in Reporting)

Sales => Sales Types => Tax Incl. => Yes / No.

Go to forum: Reporting

2,239 Reply by apmuthu

(9 replies, posted in Dimensions)

There are only 2 Dimensions possible in FA as of now. However, each Dimension can have multiple sibling heads. If Dimension 1 is Department, then there can be several Departments in it.

Go to forum: Dimensions

2,240 Reply by apmuthu

(55 replies, posted in Report Bugs here)

What versions of PHP did you check earlier?

Go to forum: Report Bugs here

2,241 Reply by apmuthu

(24 replies, posted in Accounts Receivable)

Shall we code so that:

Test expected    -1    1    31-12-2016        1    31-01-2017    31-12-2016 - 30-01-2017.

The last sent will then become 31-01-2017 ?

Go to forum: Accounts Receivable

2,242 Reply by apmuthu

(5 replies, posted in Installation)

@stefan: would you like to submit the function changes?

Go to forum: Installation

2,243 Reply by apmuthu

(55 replies, posted in Report Bugs here)

Do a Winmerge diff check on your FA install root and the Github master codebase and see if there are any other file differences.

You can also use online diff tools like:

https://www.diffnow.com/
https://www.diffchecker.com/
http://www.comparemyfiles.com/

Go to forum: Report Bugs here

2,244 Reply by apmuthu

(55 replies, posted in Report Bugs here)

The existing code does not use floatval.

Line 318 of includes/current_user.inc should be:

    $num = number_format($number, $dec, $dsep, $tsep);

Like I said, the locale specific (like comma) separators do not have any say in the current exchange rate extraction.

Go to forum: Report Bugs here

2,245 Reply by apmuthu

(19 replies, posted in Reporting)

The report can be rep310.php with appropriate inclusions in the report request forms. Whitespace synch has been done with respect to rep306.php (since it is based upon it) in FA 2.4.3+ as on date.

Screenshots and files for inclusion into the core attached.

@stefan: please verify if it works well at your end and whether it needs some fixes / enhancements.
@joe: see if can be included if it serves some useful purpose.

Go to forum: Reporting

2,246 Reply by apmuthu

(9 replies, posted in Setup)

This must a a user preference and not a site-wide or company-wide setting.
This will entail a flag in the user table but settable by the sysadmin and not the user themselves as that could be leveraged for security violations like brute forcing.

Go to forum: Setup

2,247 Reply by apmuthu

(55 replies, posted in Report Bugs here)

I can confirm that the new way to compute the Google rate does not need to depend on any locale specific inputs and hence the latest commit in the gl_db_rates.inc will take care of it.

Clear your browser cache and company js_cache and login afresh in a sole instance of a new browser and see what gives. I have tested it extensively in PHP 5.3.1 on Windows and PHP 5.3.3 on Debian Squeeze. I will be building a fresh OpenVZ template for it on Debian Squeeze and will test on that as well.

YAHOO Exchange rate is broken due to upstreamn blockage. They rely on OFX, a Yahoo Widget.

Those who wish to see a backport if they are still using FA 2.3.x, let me know. There may be some die hard fans of FA 2.3.x - if it ain't broke why fix it - who may need extended support - they can contact the FA support facilitators.

Go to forum: Report Bugs here

2,248 Reply by apmuthu

(55 replies, posted in Report Bugs here)

@joe: Thanks for the Bloomberg commit.

The incremental patch file for the Google fix is attached herewith.

Go to forum: Report Bugs here

2,249 Reply by apmuthu

(55 replies, posted in Report Bugs here)

Both Google and Bloomberg Exchange rates work with the new fix attached herewith.

Go to forum: Report Bugs here

2,250 Reply by apmuthu

(55 replies, posted in Report Bugs here)

No need to bother with the number_format statement. The Bloomberg fix uses another part of the page which does not have any locale formatting. I have changed it a bit and re-uploaded it. If you were the first to download it then download it again.

PHP Simple XML Parsing

Go to forum: Report Bugs here