you can see my changes on my fork over
update is on 2.4.6 /includes/references.inc file
1. line no 55 updated the placeholder array to
$refline_placeholders = array(
'MM' => 'date',
'Y' => 'date',
'YY' => 'date',
'YYY' => 'date',
'YYYY' => 'date',
'UU' => 'user',
'P' => 'pos',
// FIXME: for placeholders below all the code should work, but as the ref length is variable,
// length specification in placeholder format should be implemented.
// 'C' => 'customer',
// 'B' => 'branch',
// 'S' => 'supplier',
// 'L' => 'location'
);2. added new template in switch case line no 124
case 'Y':
case 'YYY':
list($begin_day, $begin_month, $begin_year) = explode_date_to_dmy(begin_fiscalyear());
list($end_day, $end_month, $end_year) = explode_date_to_dmy(end_fiscalyear());
$out .= $ph == 'Y' ? sprintf('%04d', $begin_year) : sprintf('%04d', $begin_year) . "-" . sprintf('%02d', $end_year % 100);
break;3. updated is_valid function line no 266
function is_valid($reference, $type, $context=null, $line=null)
{
if (!isset($line))
$line = $this->reflines->find_refline_id($reference, $type, true);
if (!isset($line))
return false;
$refline = $this->reflines->get($line);
if ($this->_legacy_line($refline)) //legacy non-templated line
return strlen(trim($reference)) > 0;
$regex = preg_quote($refline['prefix'].$refline['pattern']);
if (!is_array($context))
$context = array('date'=>$context);
$context['pos'] = $_SESSION["wa_current_user"]->pos;
if (is_date(@$context['date']))
{
list($year4, $month, $day) = explode("-", date2sql($context['date']));
list($begin_year, $begin_month, $begin_day) = explode("-", date2sql(begin_fiscalyear()));
list($end_year, $end_month, $end_day) = explode("-", date2sql(end_fiscalyear()));
$year2 = substr($year4, 2);
$year3 = $begin_year."-".substr($end_year, 2);
} else
{
$month = '\d{2,}';
$year2 = '\d{2,}';
$year4 = '\d{4,}';
$begin_year = '\d{4,}';
$year3 = '\d{4,}-\d{2,}';
}
$cust = @$context['customer'] ? $context['customer'] : '\d+';
$supp = @$context['supplier'] ? $context['supplier'] : '\d+';
$branch = @$context['branch'] ? $context['branch'] : '\d+';
$location = @$context['location'] ? $context['location'] : '[a-z0-9]+';
$pos = @$context['pos'] ? $context['pos'] : '\d+';
$user = sprintf("%02d", $_SESSION['wa_current_user']->user);
$regex = preg_replace(
array(
'/\\\{/', // unquote placeholders
'/\\\}/',
'/\{MM\}/',
'/\{Y\}/',
'/\{YY\}/',
'/\{YYY\}/',
'/\{YYYY\}/',
'/\{C\}/',
'/\{B\}/',
'/\{S\}/',
'/\{L\}/',
'/\{UU\}/',
'/\{P\}/',
'/\{\d+}/',
),
array(
'{',
'}',
$month,
$begin_year,
$year2,
$year3,
$year4,
$cust,
$branch,
$supp,
$location,
$user,
$pos,
'\d+',
), $regex);
$regex = '"^'.$regex.'"i';
return preg_match($regex, $reference, $match) ? 1 : 0;
}@joe: Along with {Y}, try to include {YYY} to indicate both years if they lie in different calendar years like /2018-19.
]]>Joe
]]>Thanks and its very easy to do by calling begin fiscal year method
]]>Just take the Year of the fiscal year beginning only!
Besides, this will all go wrong if the template is created with all the date elements for when there are too many transactions each day and a template like {DD}{MM}{YYYY} is used! A separate template like {Y} may be used for this kind of resetting of the year each fiscal beginning.
There is a function get_fiscalyear_begin_for_date($date) that obtains the financial year beginning in the file admin/db/fiscalyears_db.inc. Also available in it is get_current_fiscalyear(). These functions return the MySQL date format whilst taking the user date format as input where needed.
There is another function begin_fiscalyear() that gets the current fiscal year's begin date in user date format in includes/date_functions.inc.
]]>for eg. 31st December reference was SO201800080 but on January 1st it became SO201900001 which cant be accepted because current fiscal year is not closed and it should be continuation of last reference (SO201800081) till 31st March.
My ugly hack to resolve this is
1. get current fiscal year begin
2. check context date is in fiscal year and both year is not same
3. if its matching create a new date with previous year and set it as date in reference context
list($day, $month, $year) = explode_date_to_dmy(begin_fiscalyear());
list($day1, $month1, $year1) = explode_date_to_dmy($context['date']);
if(is_date_in_fiscalyear($context['date'])&&$year!=$year1){
$mdate=sql2date($year."-".$month1."-".$day1);
$context['date']=$mdate;
}added above code in reference.inc line number 99
Please suggest me if there is better way to resolve this
]]>