Topic: Report Selector Orientation (Portrait, Landscape) implmented in FA 2.3

Stay cool guys, we felt that we have to implement the Page Orientation also in the upcoming 2.3.14 that are about to release tomorrow.

We will use the night for testing, so no side-effect should be there.

/Joe

Re: Report Selector Orientation (Portrait, Landscape) implmented in FA 2.3

Analysing what and how to backport from Unstable 2.4 to Stable 2.3.13 Mer Build 3141:

Copy over reporting/includes/reporting.inc from Unstable to Stable
Others can be backported directly for orientation:
101 - 106, 114, 201-204, 301-306, 401, 501, 701, 704-710
rep 107, 110 & 113 (can backport block of logic), must exclude new FA 2.4 field while backporting
rep 108, 109, 111, 409 block of logic can be backported with / without orientation
rep 112 backport with removal of inline deprecated function (3027 mer build done in unstable) with / without orientation
rep 209 - beware that get_tax_for_items() function has changed due to new tax_algorithm field in 2 tables.
rep 210 - backport with removal of inline deprecated function get_allocations_for_remittance() (3027 mer build done in unstable) with / without orientation

rep 601 - only beware of new fa 2.4 function get_counterparty_name in includes/types.inc used instead of older function payment_person_name which is still available
rep 702 - only beware of new fa 2.4 function get_subaccount_name() in gl/includes/db/gl_db_accounts.inc used instead of older function payment_person_name


function payment_person_name from includes/types.inc used in reports 601, 702 and 704 (in 602 [copy of 601 with reconcile] and 704 in unstable as well)
function get_subaccount_name() [rep 702] and is_subledger_account() in FA 2.4 in gl/includes/db/gl_db_accounts.inc

Re: Report Selector Orientation (Portrait, Landscape) implmented in FA 2.3

Thanks, I have already done it. However much appreciated for info to check. Thanks again. Will be checked before testing.

Joe

4 (edited by apmuthu 01/16/2013 09:04:06 pm)

Re: Report Selector Orientation (Portrait, Landscape) implmented in FA 2.3

Attached is the patch file to update the reporting/repXXX.php files in synch with the unstable branch prior to the Orientation Feature induction. This will help clarify errors if any before orientation inclusion.

Post's attachments

repXXX_V2.3.13_mer_3141_prior_to_orientation_feature.patch.zip 3.3 kb, 5 downloads since 2013-01-16 

You don't have the permssions to download the attachments of this post.

Re: Report Selector Orientation (Portrait, Landscape) implmented in FA 2.3

Thanks Joe. Mercurial Changeset v3142 did it.

recalculate() is now a normal function in includes/current_user.inc instead of being in 2 different class files. It can be further modified to (intelligently) selectively expand only the text fields needed - possibly through an array containing boolean values in each report for allowing expansion.