Search options (Page 1 of 2)

I doubt that sys_prefs table could be of any use for my problem.

If you look at my code above, you can see I am using _SESSION variables, as you did (in original file). These are exactly the same in the first instance, in the second instance and so on (if I click edit the invoice more than just once - to have one instance to work on it, and post it at the end, but have another / unmodified version till the end to copy something out of it, or to post it as another new invoice, or whatever...).

I've thought to concatenate a random string to their names, but can not do that as I should do it only the first time (when already posted invoice is read), but not later anymore (next time something is changed and the screen is refreshed, but invoice not saved / posted yet). On the other hand, I would need to know their names (containing random string) next time, to be able to read them.

So, I see no way to have them different for one and another window within the same session.

Is there an easy way to have some variables kept between form submits for each window instance separately, and not for the session. I mean, without passing all of them all the time with GET / POST, when the form is submitted (as it is now)?

The way I've intended to resolve it above, my changes were relatively simple and safe, as I haven't directly save no information (I was just preprocessed the form for the new invoice) in the database. All critical code is still yours. If I should change it more in depth, I'm afraid I would do something incomplete / wrong, without being even aware of that (you know all the logic about what goes where, but I have absolutely not a clear picture about that!).

Is it a bit more clear to you what is my problem now? I'm sorry, but have no idea how to explain it in a better way...

rmartino0913,

I guess voiding a transaction means more or less to just delete it.

What you need is a transaction reversal, what would be "the right way" (in particular for a traditional / old-fashioned accountant) to handle mistakes. And, sometimes the only possible / allowed option (in case of stock / inventory and changing purchase prices).

It would be generally great to have an option to use any already posted transaction as a template for a new transaction. This way it would be relatively quick and easy to:
1. Enter a reversed transaction (just editing quantities or amounts to negative before posting)
2. Add a new (correct) transaction (just editing the wrong item before posting)

I am missing a comfortable way to handle vendor invoice mistakes in the first place (where can be quite a nubmer of lines / data, which have to be typed in again and again, with a possibility of new mistakes, now...).

I can confirm it works fine in 2.3.3 (function seems to be quite different now).

What about some other - a bit more capable - platform?  By the way - where have you found this punBB at all?!  ;-)

By the way, my temporary solution above can be tricky. After you edit one invoice, some sessin variables remain set, so some extra lines have to be added to prevent any new invoice added after (within the same session) to be voided imediately.

My latest patch (for 2.3.0) is:

=============================================================================================================
--- purchasing/supplier_invoice.php.ORIGINAL    2010-12-10 14:12:44.000000000 +0100
+++ purchasing/supplier_invoice.php        2010-12-27 22:28:52.000000000 +0100
@@ -25,7 +25,73 @@ if ($use_popup_windows)
    $js .= get_js_open_window(900, 500);
if ($use_date_picker)
    $js .= get_js_date_picker();
-page(_($help_context = "Enter Supplier Invoice"), false, false, "", $js);
+
+if (isset($_GET['ModifySI'])) {
+//display_notification_centered(_("Modify SI TRUE<br>"));
+    $help_context = "Modifying Supplier Invoice";
+    $error_msg = '';
+
+    if (isset($_GET["trans_no"])) {
+        $trans_no = $_GET["trans_no"];
+    }
+    elseif (isset($_POST["trans_no"])) {
+        $trans_no = $_POST["trans_no"];
+    }
+    else    $trans_no = null;
+
+    if ($trans_no != null) {
+        $_SESSION['page_title'] = sprintf(_("Modifying Supplier Invoice # %d."), $trans_no);
+        if (is_closed_trans(ST_SUPPINVOICE, $trans_no)) {
+            $error_msg = _("The selected transaction was closed for edition.");
+        }
+        else {
+            $void_entry = get_voided_entry(ST_SUPPINVOICE, $trans_no);
+            if ($void_entry != null) {
+                $error_msg = _("The selected transaction has already been voided.");
+            }
+            else {
+                $result = get_gl_trans(ST_SUPPINVOICE, $trans_no);
+                if (db_num_rows($result) == 0) {
+                    $error_msg = _("Cannot find Supplier Invoice # ") . $trans_no;
+                }
+            }
+        }
+    }
+    else {
+        $_SESSION['page_title'] = _("Modifying Supplier Invoice (with missing #).");
+        $error_msg = _("Supplier Invoice # is missing!");
+    }
+
+    if ($error_msg == '') {
+        $supp_trans = new supp_trans(ST_SUPPINVOICE);
+        read_supp_invoice($trans_no, ST_SUPPINVOICE, $supp_trans);
+        page($_SESSION['page_title'], false, false,'', $js);
+        $_SESSION['supp_trans'] = $supp_trans;
+        $_SESSION['inv_modify'] = true;
+        $_SESSION['old_trans'] = $trans_no;
+        $_SESSION['old_date'] = $supp_trans->tran_date;
+    }
+    else {
+        $_SESSION['inv_modify'] = false;
+        $_SESSION['old_trans'] = null;
+        $_SESSION['old_date'] = null;
+        page($_SESSION['page_title'], false, false,'', $js);
+        display_error($error_msg);
+        end_page(true);
+        exit;
+    }
+}
+elseif (isset($_GET['New'])) {
+//display_notification_centered(_("New TRUE, Modify SI FALSE<br>"));
+    $_SESSION['inv_modify'] = false;
+    $_SESSION['old_trans'] = null;
+    $_SESSION['old_date'] = null;
+    page(_($help_context = "Enter Supplier Invoice"), false, false, "", $js);
+}
+else {
+//display_notification_centered(_("Modify SI unchanged...<br>"));
+    page(_($help_context = "Enter Supplier Invoice"), false, false, "", $js);
+}

//----------------------------------------------------------------------------------------

@@ -193,6 +259,27 @@ function check_data()

//--------------------------------------------------------------------------------------------------

+function handle_void_invoice()
+{
+
+    if (!exists_supp_trans(ST_SUPPINVOICE, $_SESSION['old_trans']))
+        return false;
+    if (!post_void_supp_trans(ST_SUPPINVOICE, $_SESSION['old_trans']))
+        return false;
+
+    $ret = void_transaction(ST_SUPPINVOICE, $_SESSION['old_trans'], $_SESSION['old_date'], 'Invoice Modification - Old Version');
+
+    if ($ret)
+    {
+        display_notification_centered(_("Old invoice has been voided."));
+    }
+    else {
+        display_error(_("Old invoice cannot be voided."));
+        set_focus('trans_no');
+    }
+    return $ret;
+}
+
function handle_commit_invoice()
{
    copy_to_trans($_SESSION['supp_trans']);
@@ -212,7 +299,14 @@ function handle_commit_invoice()

if (isset($_POST['PostInvoice']))
{
-    handle_commit_invoice();
+    if ($_SESSION['inv_modify']) {
+        if (handle_void_invoice($_SESSION['old_trans'], $_SESSION['old_date'])) {
+            handle_commit_invoice();
+        }
+    }
+    else {
+        handle_commit_invoice();
+    }
}

function check_item_data($n)
=============================================================================================================

Patch for gl/inquiry/journal_inquiry.php above is OK (and also needed).

Also be careful If you open another tab in your browser with another invoice in between (while you "edit" one invoice). I think session variables mix up and results are unpredictable (in any case things are not as they should be). This should somehow be resolved before I could consider my patch really usable. So, take care before using this solution (altough it seems to work otherwise...).

In any case, I hope as well there will be a safe solution in the near future available.

What about all defaults all around, which are linked to certain accounts?

It would however be good to have an option to start from scratch (as empty databese as possible), and to have some script to check what it yet to be entered (all defaults we have to select, after the COA is established, but before we can actually start using FA).

It seems it isn't too complicated to make account / account types names longer. I've changed in MySQL:
`0_chart_master`.`account_name` to VARCHAR 255
`0_chart_types`.`name` to VARCHAR 255

and modifications to 2 files, as in attachment.

Up to now, everything seems to work quite OK. I'd appreciate any feedbacks.