Search options (Page 1 of 5)

Thanks @kvvaradha, I will fix and commit.

Joe

@itronics: I hope this has not affected the depreciation / fixed assets reports

For straight line method, you need to use the purchase cost. so the purchase cost may be 15000 USD, this is a chance.

and probably you need to trace it with calculation from the compute_gl_rows_for_depreciation with some display errors placed in between locations i cant understand full concept of straight line method here programmed. it looks they are getting remaining months and process with new one. so in the each line place some display errors to make it readable for you.

function next_depreciation_date($depreciation_date) {

  $start = strtotime($depreciation_date);

  $y = date('Y', $start);
  $m = date('n', $start) + 1;

  if ($m > 12) {
    $m = 1;
    $y++;
  }

  return strtotime("$y-$m-1");
}

function depreciation_months($depreciation_start) {

  // assume that depreciation start is the same fiscal year
  //$start = strtotime($depreciation_start);
  //$end = strtotime($year['end']);

  $start = next_depreciation_date($depreciation_start);

  return 12 - date('n', $start) + 1;

  //$d1 = date('j', $start); // day of the month
  //$d2 = date('t', $start); // number of days in month

  //if ($d2 > $d1)
    //$months++;
}

function months_between_dates($start, $end) {
  $start = strtotime($start);
  $end = strtotime($end);

  $y1 = date('Y', $start);
  $m1 = date('n', $start);

  $y2 = date('Y', $end);
  $m2 = date('n', $end);

  return 12 * ($y2 - $y1) + $m2 - $m1;
}

function compute_gl_rows_for_depreciation($item, $no_months, $period) {
  $rows = array();

  $year = get_current_fiscalyear();
  $y = date('Y', strtotime($year['end']));

  switch ($item['depreciation_method']) {
    case 'D':
        $line_value = $item['purchase_cost']*$item['depreciation_rate']/100/12;
        $value = $item['material_cost'] * $item['depreciation_rate'] * $item['depreciation_factor']/100/12;
        if ($value < $line_value)
            $value = $line_value;
        break;

    case 'S':    // purchase_cost stores start cost of item
        $done_months = months_between_dates($item['depreciation_start'], $item['depreciation_date']);
        $remaining_months = 12.0 * 100.0/$item['depreciation_rate'] - $done_months;
        $value = $item['purchase_cost']*$item['depreciation_rate']/100/12;
        break;

    case 'N':
        $N = $item['depreciation_rate'];
        $done_years = months_between_dates($item['depreciation_start'], $item['depreciation_date'])/12;
        $value = $item['purchase_cost']* ($N-$done_years)/($N*($N+1)/2)/12;
        break;

    case 'O':
        $value = $item['material_cost'];
        break;
  }

  $next = next_depreciation_date($item['depreciation_date']);
  $m = date('n', $next);

  $total = 0;
  $cnt = 0;
  for ($i=$m; $i < $m + $no_months; $i++) {

    if ($item['depreciation_method'] == 'S') {
        if ($cnt >= $remaining_months)
            $value = 0;
    }

    $date = sql2date(date("$y-$i-t", strtotime("$y-$i-1")));

    $total += $value;

    if (FA_YEARLY == $period) {
      // yearly
      if ($i == $m + $no_months - 1)
        $rows[] = array('date' => $date, 'value' => $total);
      /*else
        $rows[] = array('date' => $date, 'value' => 0);
        */
    }
    else {
      // monthly
      $rows[] = array('date' => $date, 'value' => $value);
    }

    $cnt++;

    if ($item['depreciation_method'] == 'O') {
        // depreciate only in the first month
        $value = 0;
    }
}

  return $rows;
}

When making a Payment or a Deposit, The bank Amount is rounded to 2 Digits. Example:
A payment of 50.555 it is rounded to 50.560,  our currency is 3 digits.

The rounding error happens only for the the (Payment or a Deposit) only

https://ibb.co/L5yYp1S  Input Picture
https://ibb.co/4RRkJsJ  Output Picture

if (strlen($_POST['check_no']) == 0 || $_POST['check_no'] == "") // new line validation added on sunday november 21 2020
    {
        display_error(_("The cheque no  reference field must be entered.")); // new line validation
         if (get_post('currency') != get_company_pref('curr_default'))
        set_focus('check_no'); if (isset($_POST['_ex_rate']) && !check_num('_ex_rate', 0.000001))
        return false; {
    }                  display_error(_("The exchange rate must be numeric and greater than zero."));
                set_focus('_ex_rate');
            $input_error = 1;
        }

function write_bank_transaction($trans_type, $trans_no, $from_account, $items, $date_,
    $person_type_id, $person_id, $person_detail_id,    $ref, $check_no, $source_ref ,$memo_, $use_transaction=true, $settled_amount=null)
{
    global $Refs, $SysPrefs;

    // we can only handle type 1 (payment)and type 2 (deposit)
    if ($trans_type != ST_BANKPAYMENT && $trans_type != ST_BANKDEPOSIT)
        display_db_error("Invalid type ($trans_type) sent to add_bank_transaction");

    $do_exchange_variance = false;
    $exchanged = false;
    if ($use_transaction)
        begin_transaction();

    $args = func_get_args(); if (count($args) < 11) $args[] = true;
    $args = (object)array_combine(array('trans_type', 'trans_no', 'from_account', 'items', 'date_',
        'person_type_id', 'person_id', 'person_detail_id', 'ref','check_no','source_ref', 'memo_', 'use_transaction', 'settled_amount'),
        $args);

Undefined offset: 1 in file: /var/www/html/finance/includes/date_functions.inc at line 386Undefined offset: 2 in file: /var/www/html/finance/includes/date_functions.inc at line 386DATABASE ERROR : The bank transaction could not be inserted
error code : 1366
error message : Incorrect integer value: 'ETB' for column 'person_type_id' at row 1
sql that failed was : INSERT INTO bank_trans (type, trans_no, bank_act, ref, check_no, source_ref, trans_date, amount, person_type_id, person_id) VALUES (0, 1406, '5', '126/2021', '01/28/2021','-45','0000-00-00', '0', 'ETB', 'Cannot insert a destination bank transaction')