Search options (Page 1 of 5)

For the sake of completeness, there is an error in the apache logs when visiting the reconcile page:

Fri Jul 22 08:52:05.754731 2022] [php:notice] [pid 2431809] [client 192.168.25.212:46626] 0:bob:sysprefs.inc:36: Undefined property: sys_prefs::$time_zone, referer: https://fa.computerisms.ca/gl/bank_account_reconcile.php?

However, this error raises on every page, so not sure it is relevant.

Hi @Joe,

Thanks for checking!

just to update;

Paypal page is working now

Checkboxes on the recconcile page are working after upgrading from 2.4.11 to 2.4.12.

Unfortunately, today, I am not having any luck generating recurring invoices, but I will make a separate post for that.

Aha!

I found a new release is available, 2.4.12.  problem is fixed in this version.

@Joe,

just a little bit more follow up.

I restored my original company that I had been working on and using to report this issue, removed the BCC field, and set rep107 to 'invoice' and false and branch contacts to invoice and mail delivery works as expected.

To see what would happen, I set rep107 to 'general' and false, and this caused it to email the customer contact, which was still set to general.  I guess this is expected behaviour in that if it couldn't find a correct contact type in branch contact, it fails over the customer contact, so good up to here.

From here, I change the action type on the two branch contacts to general, and I get the same behaviour as the BCC field being set; a duplicate email is sent to the 2nd branch contact.  My expectation is that it would behave the same for general contacts as it would for invoice contacts, ie send one email to each general contact type in the branch contacts.

Maybe these two anomalies causing duplicate mails are related, or a clue that point to the same root cause?

As per the wiki, invoice type will do invoices, receipts and statements, but not quotations.  I don't do a lot of quotes, but it's not like I never use the feature, so my prediction is that if branch contacts are set to invoice, it will fail over to customer contact of general type; testing proves this to be true, the quote is emailed to the general type of customer contact.  And set customer contact to invoice, and error says no contact of the correct type to email to.  So all of that behaving as expected, can't be sending quotes if all the contact types are set to invoice.

My concern here is that if I need to keep the same list of contacts in both branch and customer and make sure one is set to invoice and one is set to general, or eliminate one set of contacts altogether, then I am back in the same position I am trying to fix, which is to make contact management less error prone and more intuitive for other users.  It would seem that being able to use general type for multiple contacts in the branch would be the solution; that way contacts just go in with more or less default settings and the end users don't have to remember to do special things every time they add a customer or contact.

Hi Joe,

Thanks for the clarification, tested and working as you described.

@Joe

Thanks for the reply, and the clarification.  I took Apmuthu's comments in the original post to mean it should work for general and invoice action types, but when you pointed out the "invoice" type requirement it became obvious.  My bad for not connecting that before.

For testing, I am using 2 branch contacts with different emails that are both configured on my desktop, and one of those contacts is auto-created from the contact that was created when I entered the customer.  As mentioned I am working on a fairly pristine instance; a few things setup under company setup to make the system work, but only one customer and 1 service item in inventory.  To test the sending of mail I have generated a single invoice in the system and am using the reports and analysis page to print/email invoices as required.

I copied rep107 and changed line 138 to false as you suggested, and set the action types to invoice for my 2 branch contacts, and it is now sending me 3 emails; 1 to the first branch contact and 2 to the 2nd branch contact.  I am not clear where it is getting the idea to send 2 emails to the 2nd contact from, but I can see in the local exim logs that it is indeed sending 3 mails instead of 2.  the 0_crm_contacts table is showing one general type of contact for customer, and 2 invoice types of contact for cust_branch.

For grins and giggles, I changed 'invoice' to 'general' on line 138 of rep107.php, on the premise that that will send to all the general type branch contacts, and set the contact types back to general for both branch contacts.  This results in a yellow triangle on the web page, and 4 emails being sent.  Either 3 to the first branch contact and 1 to the second, or one to each branch contact and one to the customer contact and one extra because it is over achieving. 

I deleted both branch contacts, so left with only one customer contact, and this results in one invoice going to the customer contact.  Add a 2nd contact to the customer (not the branch), and I again get the yellow triangle, and 3 emails; one to the first contact and 2 to the 2nd contact.  change rep107 to be 'general' and true, and back to one email to the first contact (expected behaviour).

Change rep107 back to 'general' and false, added 2 contacts back to the branch, so now have 2 branch contacts, 2 customer contacts where one contact is the same between customer and cust_branch, and rep107 is set to general and false.  Now I get 1 email to first customer contact, 2 emails to first branch contact, and 2 emails to second customer contact (using different names on all the contacts so I can see it is sending to both customer and cust_branch), and nothing to the second branch contact.  Exim logs confirm 5 mails leave the system.

So I think still not working as expected.  I can't imagine what, but is it possible I am doing or not doing something that is causing this to not work? 

Very much open to further suggestions.

Did not find the issue reported in Mantis, so I created an entry there.

To save the next person some mental gymnastics, the following query worked for me:

SELECT `name`,email FROM crm_persons where id IN (SELECT person_id FROM crm_contacts WHERE type='customer');

I think most people will have to set

type='cust_branch'

, but should be easy enough to figure out how to modify the statement for your own system.

nailed this a while back, but posting here in case I need it later, and in case it helps others:

                //text_row(_('Invoice notice:'), 'memo', sprintf(_("Recurrent Invoice covers period %s - %s."), $from, add_days($to, -1)),
        $newto = add_months($to, $myrow['monthly']);
        $newto = add_days($newto, $myrow['days']);
        text_row(_('Invoice notice:'), 'memo', sprintf(_("Recurrent Invoice covers period %s - %s."), $to, add_days($newto, -1)),